Follow up to bug 14549 - we handled the case here to fill a patron's reserve when they get another copy, however, we didn't cover the case where their reserve is title level. To recreate: 1 - Place a hold for patron A on item #1 of a record 2 - Place a hold for patron B on item #2 of a record 3 - Issue item #2 to patron A - their hold on item #1 is filled incorrectly
Created attachment 175335 [details] [review] Bug 38650: Unit tests
Created attachment 175336 [details] [review] Bug 38650: Only fill title level reserves, or reserves on the exact item We change the conditions for filling holds to require that either: - the hold is title level - the hold is on the exact item To test: 1 - Place a hold for patron A on item #1 of a record 2 - Place a hold for patron B on item #2 of a record 3 - Issue item #2 to patron A - their hold on item #1 is filled incorrectly, check the item in 4 - Apply patch, restart all 5 - Place hold for patron A on item #1 6 - Issue item #2 to patron A - their hold on item #1 is not filled, check the item in 7 - Cancel that hold 8 - Place a title level hold for the record for patron A 9 - Check item #1 in at a different branch and confirm transfer 9 - Issue item #2 to patron A 10 - The hold is filled as title level, even though item #1 was selected for the hold, check the item in 11 - Place an item level hold for item #2 for patron A 12 - Issue item #2 to patron A, hold is filled
At step 10 my title-level hold is not filled when checking out an item other than the item that is already in transit. The hold should be marked filled when checking out an item that would have triggered the hold had it been checked in first.
Hi - we are the library that originally encountered this bug and it continues to be a major issue for us. We use item specific holds to recall hotspots and Chromebooks that have been disabled or expired so they aren't sent out to new patrons in non-working condition. However, when these item-specific, first-in-queue holds keep disappearing, patrons end up borrowing non-working devices. It also takes significant amounts of time for our staff to search these out and re-place them over and over again. Any movement to resolve this issue would be greatly appreciated.
Created attachment 181143 [details] [review] Bug 38650: Unit tests Current status: Failed QA
Created attachment 181144 [details] [review] Bug 38650: Only fill title level reserves, or reserves on the exact item We change the conditions for filling holds to require that either: - the hold is title level - the hold is on the exact item To test: 1 - Place a hold for patron A on item #1 of a record 2 - Place a hold for patron B on item #2 of a record 3 - Issue item #2 to patron A - their hold on item #1 is filled incorrectly, check the item in 4 - Apply patch, restart all 5 - Place hold for patron A on item #1 6 - Issue item #2 to patron A - their hold on item #1 is not filled, check the item in 7 - Cancel that hold 8 - Place a title level hold for the record for patron A 9 - Check item #1 in at a different branch and confirm transfer 9 - Issue item #2 to patron A 10 - The hold is filled as title level, even though item #1 was selected for the hold, check the item in 11 - Place an item level hold for item #2 for patron A 12 - Issue item #2 to patron A, hold is filled
Created attachment 181369 [details] [review] Bug 38650: Unit tests Signed-off-by: Stephanie Petruso <spetruso@aacpl.net>
Created attachment 181370 [details] [review] Bug 38650: Only fill title level reserves, or reserves on the exact item We change the conditions for filling holds to require that either: - the hold is title level - the hold is on the exact item To test: 1 - Place a hold for patron A on item #1 of a record 2 - Place a hold for patron B on item #2 of a record 3 - Issue item #2 to patron A - their hold on item #1 is filled incorrectly, check the item in 4 - Apply patch, restart all 5 - Place hold for patron A on item #1 6 - Issue item #2 to patron A - their hold on item #1 is not filled, check the item in 7 - Cancel that hold 8 - Place a title level hold for the record for patron A 9 - Check item #1 in at a different branch and confirm transfer 9 - Issue item #2 to patron A 10 - The hold is filled as title level, even though item #1 was selected for the hold, check the item in 11 - Place an item level hold for item #2 for patron A 12 - Issue item #2 to patron A, hold is filled Signed-off-by: Stephanie Petruso <spetruso@aacpl.net>
Created attachment 182017 [details] [review] Bug 38650: Unit tests Signed-off-by: Stephanie Petruso <spetruso@aacpl.net> Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk>
Created attachment 182018 [details] [review] Bug 38650: Only fill title level reserves, or reserves on the exact item We change the conditions for filling holds to require that either: - the hold is title level - the hold is on the exact item To test: 1 - Place a hold for patron A on item #1 of a record 2 - Place a hold for patron B on item #2 of a record 3 - Issue item #2 to patron A - their hold on item #1 is filled incorrectly, check the item in 4 - Apply patch, restart all 5 - Place hold for patron A on item #1 6 - Issue item #2 to patron A - their hold on item #1 is not filled, check the item in 7 - Cancel that hold 8 - Place a title level hold for the record for patron A 9 - Check item #1 in at a different branch and confirm transfer 9 - Issue item #2 to patron A 10 - The hold is filled as title level, even though item #1 was selected for the hold, check the item in 11 - Place an item level hold for item #2 for patron A 12 - Issue item #2 to patron A, hold is filled Signed-off-by: Stephanie Petruso <spetruso@aacpl.net> Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk>
When following the test plan, on step 3, this message is shown: "Item Nordic roots (39999000003154) has been on hold for Johnny Bryan (23529000120056) at Centerville since 05/07/2025" Which is great, as it informs the staff member that the item being checked out to Henry is on hold for Johnny. I wonder if in this case we should also show a message, along the lines of: 'The patron has an item-level hold on a different item of "Nordic roots", barcode 39999000003192'
Can we get some additional notes or some more descriptive bug title? ... only fill title level or specific item holds... What other holds are there?
Pushed for 25.05! Well done everyone, thank you!