Bugzilla – Attachment 181432 Details for
Bug 39677
Add the role presentation to the vertical divider in the navigation
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39677: Add the role presentation to the divider vertical tags
Bug-39677-Add-the-role-presentation-to-the-divider.patch (text/plain), 4.28 KB, created by
Owen Leonard
on 2025-04-24 10:55:04 UTC
(
hide
)
Description:
Bug 39677: Add the role presentation to the divider vertical tags
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2025-04-24 10:55:04 UTC
Size:
4.28 KB
patch
obsolete
>From baa7cb74db9c9538c104ae716a31cb5dcec6e452 Mon Sep 17 00:00:00 2001 >From: nina martinez <nina.martinez@biblibre.com> >Date: Tue, 22 Apr 2025 11:25:06 +0200 >Subject: [PATCH] Bug 39677: Add the role presentation to the divider vertical > tags > >Test plan: > >Enable the following system preferences: CookieConsent, >EnableOpacSearchHistory, and OpacLangSelectorMode (both top and >footer). > >- Apply the patch. >- Go to the Koha OPAC. >- Check the vertical dividers in the navigation. >- If they are present with a coherent design, the test is successful. > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >--- > koha-tmpl/opac-tmpl/bootstrap/en/includes/langmenu.inc | 2 +- > koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc | 8 ++++---- > 2 files changed, 5 insertions(+), 5 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/langmenu.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/langmenu.inc >index 06815665fb..bd87b6db21 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/langmenu.inc >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/langmenu.inc >@@ -60,7 +60,7 @@ > <!-- /# .dropdown-menu --> > </li> > <!-- / .dropdown --> >- <li class="divider-vertical" aria-hidden="false"></li> >+ <li class="divider-vertical" aria-hidden="false" role="presentation"></li> > </ul> > <!-- /.navbar-nav --> > </div> >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc >index 9eb4e7b5d1..4720d37894 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc >@@ -46,7 +46,7 @@ > </a> > </li> > [% END %] >- <li class="divider-vertical"></li> >+ <li role="presentation" class="divider-vertical"></li> > [% IF ( Koha.Preference( 'virtualshelves' ) == 1 ) %] > [% IF Koha.Preference( 'opacuserlogin' ) == 1 || some_public_shelves.count > 0 %] > <li class="nav-item dropdown"> >@@ -169,7 +169,7 @@ > [% IF Koha.Preference( 'EnableOpacSearchHistory' ) %] > <p> > <a tabindex="-1" role="menuitem" class="login-link" href="/cgi-bin/koha/opac-search-history.pl" title="View your search history">Search history</a> >- <span class="divider-vertical"></span> >+ <span role="presentation" class="divider-vertical"></span> > <a class="clearsh" href="/cgi-bin/koha/opac-search-history.pl?action=delete" title="Delete your search history"><i class="fa fa-trash-can" aria-hidden="true"></i> Clear</a> > </p> > [% END %] >@@ -180,7 +180,7 @@ > </li> > <!-- Cookie consent button for non logged-in users --> > [% IF !loggedinusername %] >- <li style="display:none" id="cookieConsentDivider" class="divider-vertical" aria-hidden="true"></li> >+ <li role="presentation" style="display:none" id="cookieConsentDivider" class="divider-vertical" aria-hidden="true"></li> > <li style="display:none" id="cookieConsentLi" class="nav-item" aria-hidden="true"> > <a id="cookieConsentButton" href="#" name="Your cookies" class="nav-link" title="View and amend cookies you have consented to" role="button"> > <i class="fa fa-cookie-bite fa-fw fa-icon-black" aria-hidden="true"></i> >@@ -190,7 +190,7 @@ > [% END %] > [% IF OpacPublic && ( !Koha.Preference( 'opacuserlogin') || !loggedinusername ) %] > [% IF Koha.Preference( 'EnableOpacSearchHistory' ) %] >- <li class="divider-vertical"></li> >+ <li role="presentation" class="divider-vertical"></li> > <li class="nav-item search_history"> > <a class="nav-link" href="/cgi-bin/koha/opac-search-history.pl" title="View your search history"> > <i class="fa fa-calendar-days fa-fw fa-icon-black" aria-hidden="true"></i> >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39677
:
181239
|
181432
|
181565
|
182248