Bug 39677 - Add the role presentation to the vertical divider in the navigation
Summary: Add the role presentation to the vertical divider in the navigation
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement
Assignee: Nina Martinez
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 23003
  Show dependency treegraph
 
Reported: 2025-04-18 13:22 UTC by Nina Martinez
Modified: 2025-05-12 07:52 UTC (History)
6 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 39677: Add the role presentation to the divider vertical tags (4.23 KB, patch)
2025-04-22 09:55 UTC, Nina Martinez
Details | Diff | Splinter Review
Bug 39677: Add the role presentation to the divider vertical tags (4.28 KB, patch)
2025-04-24 10:55 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 39677: Add the role presentation to the divider vertical tags (4.33 KB, patch)
2025-04-26 03:50 UTC, David Nind
Details | Diff | Splinter Review
Bug 39677: Add the role presentation to the divider vertical tags (4.32 KB, patch)
2025-05-12 07:50 UTC, Nina Martinez
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nina Martinez 2025-04-18 13:22:36 UTC
In the OPAC navigation, the vertical dividers are presentational but do not have the role="presentation". It would be great if we could add it to semantic tags that are used only for presentation.

This could be helpful for assistive technologies.
Comment 1 Nina Martinez 2025-04-22 09:55:18 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2025-04-24 10:55:04 UTC
Created attachment 181432 [details] [review]
Bug 39677: Add the role presentation to the divider vertical tags

Test plan:

Enable the following system preferences: CookieConsent,
EnableOpacSearchHistory, and OpacLangSelectorMode (both top and
footer).

- Apply the patch.
- Go to the Koha OPAC.
- Check the vertical dividers in the navigation.
- If they are present with a coherent design, the test is successful.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 David Nind 2025-04-26 03:50:28 UTC
Created attachment 181565 [details] [review]
Bug 39677: Add the role presentation to the divider vertical tags

Test plan:

Enable the following system preferences: CookieConsent,
EnableOpacSearchHistory, and OpacLangSelectorMode (both top and
footer).

- Apply the patch.
- Go to the Koha OPAC.
- Check the vertical dividers in the navigation.
- If they are present with a coherent design, the test is successful.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: David Nind <david@davidnind.com>
Comment 4 David Nind 2025-04-26 03:52:17 UTC
I added my sign off, in case Owen's can count as QA.

However, running the QA script generates errors, but that may be because of something wrong my setup:

qa
testing 1 commit(s) (applied to 9640d5d '38 Bug 38842: (follow-up) Fix TT filt')

Processing files before patches
|========================>| 2 / 2 (100.00%)
Processing files after patches
[error] Cannot find package '@koha-community/prettier-plugin-template-toolkit' imported from /kohadevbox/koha/noop.js at misc/devel/tidy.pl line 112.
[error] Cannot find package '@koha-community/prettier-plugin-template-toolkit' imported from /kohadevbox/koha/noop.js at misc/devel/tidy.pl line 112.


 FAIL	koha-tmpl/opac-tmpl/bootstrap/en/includes/langmenu.inc
   FAIL	  tidiness
		File is not tidy, please run `perl misc/devel/tidy.pl koha-tmpl/opac-tmpl/bootstrap/en/includes/langmenu.inc`

 FAIL	koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc
   FAIL	  tidiness
		File is not tidy, please run `perl misc/devel/tidy.pl koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc`


Processing additional checks OK!


	* Was this bug sponsored by anyone?
Comment 5 Katrin Fischer 2025-04-26 08:55:40 UTC
Something in main is not right - that will cause the errors you see.
Comment 6 Lucas Gass (lukeg) 2025-05-08 19:30:48 UTC
Needs a rebase
Comment 7 Nina Martinez 2025-05-12 07:50:32 UTC
Created attachment 182248 [details] [review]
Bug 39677: Add the role presentation to the divider vertical tags

Test plan:

Enable the following system preferences: CookieConsent, EnableOpacSearchHistory, and OpacLangSelectorMode (both top and footer).

-Apply the patch.
-Go to the Koha OPAC.
-Check the vertical dividers in the navigation.
-If they are present with a coherent design, the test is successful.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: David Nind <david@davidnind.com>