In the OPAC navigation, the vertical dividers are presentational but do not have the role="presentation". It would be great if we could add it to semantic tags that are used only for presentation. This could be helpful for assistive technologies.
Created attachment 181239 [details] [review] Bug 39677: Add the role presentation to the divider vertical tags Test plan: Enable the following system preferences: CookieConsent, EnableOpacSearchHistory, and OpacLangSelectorMode (both top and footer). -Apply the patch. -Go to the Koha OPAC. -Check the vertical dividers in the navigation. -If they are present with a coherent design, the test is successful.
Created attachment 181432 [details] [review] Bug 39677: Add the role presentation to the divider vertical tags Test plan: Enable the following system preferences: CookieConsent, EnableOpacSearchHistory, and OpacLangSelectorMode (both top and footer). - Apply the patch. - Go to the Koha OPAC. - Check the vertical dividers in the navigation. - If they are present with a coherent design, the test is successful. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 181565 [details] [review] Bug 39677: Add the role presentation to the divider vertical tags Test plan: Enable the following system preferences: CookieConsent, EnableOpacSearchHistory, and OpacLangSelectorMode (both top and footer). - Apply the patch. - Go to the Koha OPAC. - Check the vertical dividers in the navigation. - If they are present with a coherent design, the test is successful. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com>
I added my sign off, in case Owen's can count as QA. However, running the QA script generates errors, but that may be because of something wrong my setup: qa testing 1 commit(s) (applied to 9640d5d '38 Bug 38842: (follow-up) Fix TT filt') Processing files before patches |========================>| 2 / 2 (100.00%) Processing files after patches [error] Cannot find package '@koha-community/prettier-plugin-template-toolkit' imported from /kohadevbox/koha/noop.js at misc/devel/tidy.pl line 112. [error] Cannot find package '@koha-community/prettier-plugin-template-toolkit' imported from /kohadevbox/koha/noop.js at misc/devel/tidy.pl line 112. FAIL koha-tmpl/opac-tmpl/bootstrap/en/includes/langmenu.inc FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl koha-tmpl/opac-tmpl/bootstrap/en/includes/langmenu.inc` FAIL koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc` Processing additional checks OK! * Was this bug sponsored by anyone?
Something in main is not right - that will cause the errors you see.
Needs a rebase
Created attachment 182248 [details] [review] Bug 39677: Add the role presentation to the divider vertical tags Test plan: Enable the following system preferences: CookieConsent, EnableOpacSearchHistory, and OpacLangSelectorMode (both top and footer). -Apply the patch. -Go to the Koha OPAC. -Check the vertical dividers in the navigation. -If they are present with a coherent design, the test is successful. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com>
Hi! Looks like we might need another rebase -- Applying: Bug 39677: Add the role presentation to the divider vertical tags Using index info to reconstruct a base tree... M koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc error: Failed to merge in the changes. Patch failed at 0001 Bug 39677: Add the role presentation to the divider vertical tags hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-39677-Add-the-role-presentation-to-the-divider-q9yymcu4.patch
Created attachment 184728 [details] [review] Bug 39677: Add the role presentation to the divider vertical tags Test plan: Enable the following system preferences: CookieConsent, EnableOpacSearchHistory, and OpacLangSelectorMode (both top and footer). -Apply the patch. -Go to the Koha OPAC. -Check the vertical dividers in the navigation. -If they are present with a coherent design, the test is successful. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com>