Bugzilla – Attachment 181503 Details for
Bug 39569
When cancelling a hold waiting past expiration date triggers a transfer the libraries name is not in alert
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39569: Fix branch name in alert when cancelling holds over x
Bug-39569-Fix-branch-name-in-alert-when-cancelling.patch (text/plain), 2.06 KB, created by
Nick Clemens (kidclamp)
on 2025-04-25 11:11:02 UTC
(
hide
)
Description:
Bug 39569: Fix branch name in alert when cancelling holds over x
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2025-04-25 11:11:02 UTC
Size:
2.06 KB
patch
obsolete
>From 1ff232f070f532fe0e41e0dd4ff1b39d970aaf8a Mon Sep 17 00:00:00 2001 >From: Brendan Lawlor <blawlor@clamsnet.org> >Date: Fri, 4 Apr 2025 18:41:54 +0000 >Subject: [PATCH] Bug 39569: Fix branch name in alert when cancelling holds > over x > >To test: >1. On a bib with one item place a hold for pickup at library A and Library B >2. Check the item into library A >3. Set the first hold's expiration date to the past >4. On Holds awaiting pickup > Holds waiting past their expiration date > In the actions column click the 'Cancel hold' button >5. Notice the alert says 'This item is on hold for pick-up at' > with no library name >6. Apply patch and redo steps 1-4 >7. Confirm the alert include's Library B's name > This item is on hold for pick-up at Library B > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/circ/waitingreserves.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/waitingreserves.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/waitingreserves.tt >index b3059e65abd..44a65e7c971 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/waitingreserves.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/waitingreserves.tt >@@ -54,7 +54,7 @@ > [% FOREACH cancel_result %] > [% IF ( messagetransfert ) %] > <div class="alert alert-info"> >- <h2>This item is on hold for pick-up at [% Branches.GetName( branchname ) | html %]</h2> >+ <h2>This item is on hold for pick-up at [% Branches.GetName( branchcode ) | html %]</h2> > <p><strong>[% nextreservtitle | html %]</strong> is on hold for <strong> [% nextreservsurname | html %], [% nextreservfirstname | html %]</strong>. Please retain this item and check it in to process the hold. </p> > <form name="cancelReservewithtransfert" action="waitingreserves.pl#[% tab | html %]" method="get"> > <button type="submit" class="btn btn-default approve"><i class="fa fa-fw fa-check"></i> OK</button> >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39569
:
180670
| 181503