To recreate: - Use a bib with a single item to make this easier - Place two holds on a bib with pickup at one library - Place some more holds for pickup at a different library - Check the item in to the first library - Set the expiration date back in time, using ktd --dbshell can help update reserves set expirationdate = DATE('2024-01-01') where branchcode='CPL'; - On Holds awaiting pickup > Holds waiting past their expiration date use the button in the actions tab to 'Cancel hold' the alert says: This item is on hold for pick-up at your library' - click OK - Check the item in again and set expiration date to expired again - On Holds awaiting pickup > Holds waiting past their expiration date use the button in the actions tab to 'Cancel hold and transfer to: [libraryname]' - Notice the alert says 'This item is on hold for pick-up at' with no library name
Created attachment 180670 [details] [review] Bug 39569: Fix branch name in alert when cancelling holds over x To test: 1. On a bib with one item place a hold for pickup at library A and Library B 2. Check the item into library A 3. Set the first hold's expiration date to the past 4. On Holds awaiting pickup > Holds waiting past their expiration date In the actions column click the 'Cancel hold' button 5. Notice the alert says 'This item is on hold for pick-up at' with no library name 6. Apply patch and redo steps 1-4 7. Confirm the alert include's Library B's name This item is on hold for pick-up at Library B
Created attachment 181503 [details] [review] Bug 39569: Fix branch name in alert when cancelling holds over x To test: 1. On a bib with one item place a hold for pickup at library A and Library B 2. Check the item into library A 3. Set the first hold's expiration date to the past 4. On Holds awaiting pickup > Holds waiting past their expiration date In the actions column click the 'Cancel hold' button 5. Notice the alert says 'This item is on hold for pick-up at' with no library name 6. Apply patch and redo steps 1-4 7. Confirm the alert include's Library B's name This item is on hold for pick-up at Library B Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Trivial fix, PQA
Pushed for 25.05! Well done everyone, thank you!