Bugzilla – Attachment 181668 Details for
Bug 39775
Serials claims table filters aren't working
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39775: Restore filtering to the serials claims table
Bug-39775-Restore-filtering-to-the-serials-claims-.patch (text/plain), 4.03 KB, created by
Jonathan Druart
on 2025-04-29 14:43:43 UTC
(
hide
)
Description:
Bug 39775: Restore filtering to the serials claims table
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2025-04-29 14:43:43 UTC
Size:
4.03 KB
patch
obsolete
>From 16d928eb941ed853321c9cf5af879d4135fb9191 Mon Sep 17 00:00:00 2001 >From: Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> >Date: Tue, 29 Apr 2025 15:22:15 +0100 >Subject: [PATCH] Bug 39775: Restore filtering to the serials claims table > >This patch implements the 'add_filters' argument for kohaTable() to restore filtering to the serials claims table > >Test plan: >1) Navigate to Serials and then Claims (if prompted to create a notice, please do this) >2) If you have no claims listed, return to the serials page and create a new serial (the details of this aren't too important) >3) Return to the serials claims page, try to use one of the filters at the bottom of the table >4) Nothing will happen and the table won't filter >5) Apply patch >6) Hard refresh the browser >7) The filters will now be at the top of the table and should work > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > .../prog/en/modules/serials/claims.tt | 34 ++++++------------- > 1 file changed, 10 insertions(+), 24 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt >index aa6e6f770dd..172ab160bc4 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt >@@ -133,24 +133,6 @@ > </tr> > [% END # /FOREACH missingissue %] > </tbody> >- <tfoot> >- <tr> >- <td></td> >- <td><input type="text" class="filter" data-column_num="1" placeholder="Search vendor" /></td> >- <td><input type="text" class="filter" data-column_num="2" placeholder="Search library" /></td> >- <td><input type="text" class="filter" data-column_num="3" placeholder="Search title" /></td> >- <td><input type="text" class="filter" data-column_num="4" placeholder="Search ISSN" /></td> >- <td><input type="text" class="filter" data-column_num="5" placeholder="Search issue number" /></td> >- <td><input type="text" class="filter" data-column_num="6" placeholder="Search status" /></td> >- <td><input type="text" class="filter" data-column_num="7" placeholder="Search since" /></td> >- <td><input type="text" class="filter" data-column_num="8" placeholder="Search publication date" /></td> >- <td><input type="text" class="filter" data-column_num="9" placeholder="Search claim count" /></td> >- <td><input type="text" class="filter" data-column_num="10" placeholder="Search claim date" /></td> >- [% FOR field IN additional_fields_for_subscription %] >- <td><input type="text" class="filter" data-column_num="[% loop.count + 10 | html %]" placeholder="Search [% field.name | html %]" /></td> >- [% END %] >- </tr> >- </tfoot> > </table> > <!-- /#claimst --> > </div> >@@ -238,12 +220,16 @@ > var sTable; > $(document).ready(function () { > enableSelectedActions(); >- sTable = $("#claimst").kohaTable({ >- dom: "t", >- order: [[7, "asc"]], >- columnDefs: [{ sortable: false, targets: ["no-sort"] }], >- paging: false, >- }); >+ sTable = $("#claimst").kohaTable( >+ { >+ dom: "t", >+ order: [[7, "asc"]], >+ columnDefs: [{ sortable: false, targets: ["no-sort"] }], >+ paging: false, >+ }, >+ null, >+ true >+ ); > > // Checkboxes : Select All / None > $("span.checkall").html('<input type="checkbox" name="CheckAll"> ' + _("Check all") + "</input>"); >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39775
:
181666
| 181668 |
181669