Bug 39775 - Serials claims table filters aren't working
Summary: Serials claims table filters aren't working
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Serials (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Matt Blenkinsop
QA Contact: Jonathan Druart
URL:
Keywords: regression
Depends on: 36640
Blocks:
  Show dependency treegraph
 
Reported: 2025-04-29 14:21 UTC by Matt Blenkinsop
Modified: 2025-05-16 15:07 UTC (History)
2 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
This restores the table filters for serial claims search results - they are now located at the top of the table, and actually work. This was a regression.
Version(s) released in:
25.05.00
Circulation function:


Attachments
Bug 39775: Restore filtering to the serials claims table (3.96 KB, patch)
2025-04-29 14:23 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 39775: Restore filtering to the serials claims table (4.03 KB, patch)
2025-04-29 14:43 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 39775: Remove no-sort def (984 bytes, patch)
2025-04-29 14:43 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 39775: Restore filtering to the serials claims table (4.08 KB, patch)
2025-05-06 16:20 UTC, David Nind
Details | Diff | Splinter Review
Bug 39775: Remove no-sort def (1.01 KB, patch)
2025-05-06 16:20 UTC, David Nind
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Blenkinsop 2025-04-29 14:21:15 UTC
To reproduce:
1) Navigate to Serials and then Claims (if prompted to create a notice, please do this)
2) If you have no claims listed, return to the serials page and create a new serial (the details of this aren't too important)
3) Return to the serials claims page, try to use one of the filters at the bottom of the table
4) Nothing will happen and the table won't filter
Comment 1 Matt Blenkinsop 2025-04-29 14:23:59 UTC
Created attachment 181666 [details] [review]
Bug 39775: Restore filtering to the serials claims table

This patch implements the 'add_filters' argument for kohaTable() to restore filtering to the serials claims table

Test plan:
1) Navigate to Serials and then Claims (if prompted to create a notice, please do this)
2) If you have no claims listed, return to the serials page and create a new serial (the details of this aren't too important)
3) Return to the serials claims page, try to use one of the filters at the bottom of the table
4) Nothing will happen and the table won't filter
5) Apply patch
6) Hard refresh the browser
7) The filters will now be at the top of the table and should work
Comment 2 Jonathan Druart 2025-04-29 14:43:43 UTC
Created attachment 181668 [details] [review]
Bug 39775: Restore filtering to the serials claims table

This patch implements the 'add_filters' argument for kohaTable() to restore filtering to the serials claims table

Test plan:
1) Navigate to Serials and then Claims (if prompted to create a notice, please do this)
2) If you have no claims listed, return to the serials page and create a new serial (the details of this aren't too important)
3) Return to the serials claims page, try to use one of the filters at the bottom of the table
4) Nothing will happen and the table won't filter
5) Apply patch
6) Hard refresh the browser
7) The filters will now be at the top of the table and should work

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 3 Jonathan Druart 2025-04-29 14:43:45 UTC
Created attachment 181669 [details] [review]
Bug 39775: Remove no-sort def

Not needed.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 David Nind 2025-05-06 16:20:49 UTC
Created attachment 181990 [details] [review]
Bug 39775: Restore filtering to the serials claims table

This patch implements the 'add_filters' argument for kohaTable() to restore filtering to the serials claims table

Test plan:
1) Navigate to Serials and then Claims (if prompted to create a notice, please do this)
2) If you have no claims listed, return to the serials page and create a new serial (the details of this aren't too important)
3) Return to the serials claims page, try to use one of the filters at the bottom of the table
4) Nothing will happen and the table won't filter
5) Apply patch
6) Hard refresh the browser
7) The filters will now be at the top of the table and should work

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: David Nind <david@davidnind.com>
Comment 5 David Nind 2025-05-06 16:20:51 UTC
Created attachment 181991 [details] [review]
Bug 39775: Remove no-sort def

Not needed.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: David Nind <david@davidnind.com>
Comment 6 David Nind 2025-05-06 16:23:28 UTC
Adding my sign off, so that Jonathan's can be counted as QA.
Comment 7 Katrin Fischer 2025-05-06 16:54:17 UTC
Pushed for 25.05!

Well done everyone, thank you!