Bugzilla – Attachment 181670 Details for
Bug 39597
When cancelling multiple holds on a bib record cancel_hold_alert has very low contrast
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39597: Fix cancel_hold_alert badge color contrast for accesibilty
Bug-39597-Fix-cancelholdalert-badge-color-contrast.patch (text/plain), 1.62 KB, created by
Lucas Gass (lukeg)
on 2025-04-29 15:22:00 UTC
(
hide
)
Description:
Bug 39597: Fix cancel_hold_alert badge color contrast for accesibilty
Filename:
MIME Type:
Creator:
Lucas Gass (lukeg)
Created:
2025-04-29 15:22:00 UTC
Size:
1.62 KB
patch
obsolete
>From ba50366d3bd0ce47726bd2285dbe273a2f46ee18 Mon Sep 17 00:00:00 2001 >From: Brendan Lawlor <blawlor@clamsnet.org> >Date: Thu, 10 Apr 2025 13:27:28 +0000 >Subject: [PATCH] Bug 39597: Fix cancel_hold_alert badge color contrast for > accesibilty > >This patch add a class for the background on the badge element to fix color contrast > >To test: >1. Go to a bib record and place multiple holds on it >2. Select multiple holds and click 'Cancel selected (4)' >3. The Alert says 'This action will cancel 4 hold(s).' >4. Note that the contrast on the number of holds is very low >5. Click 'Cancel' apply patch and restart_all >6. Repeat steps 2-3 >7. Note that the contrast on the number of holds is good > >Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> >Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >index c7783e21971..9884d6c9caa 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >@@ -1467,7 +1467,7 @@ > } > > var MSG_CANCEL_SELECTED = _("Cancel selected (%s)"); >- var MSG_CANCEL_ALERT = _("This action will cancel <span class='badge'>%s</span> hold(s)."); >+ var MSG_CANCEL_ALERT = _("This action will cancel <span class='badge bg-danger'>%s</span> hold(s)."); > $.fn.select2.defaults.set("width", "100%" ); > $.fn.select2.defaults.set("dropdownAutoWidth", true ); > >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39597
:
180747
|
180748
|
180749
|
180776
|
180777
|
180885
| 181670