Bug 39597 - When cancelling multiple holds on a bib record cancel_hold_alert has very low contrast
Summary: When cancelling multiple holds on a bib record cancel_hold_alert has very low...
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Brendan Lawlor
QA Contact: Testopia
URL:
Keywords:
Depends on: 39274
Blocks:
  Show dependency treegraph
 
Reported: 2025-04-09 20:32 UTC by Brendan Lawlor
Modified: 2025-04-11 17:44 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
screnshot (57.38 KB, image/png)
2025-04-09 20:32 UTC, Brendan Lawlor
Details
Bug 39597: Fix cancel_hold_alert badge color contrast for accesibilty (1.51 KB, patch)
2025-04-09 20:41 UTC, Brendan Lawlor
Details | Diff | Splinter Review
contrast with patch (29.14 KB, image/png)
2025-04-09 20:43 UTC, Brendan Lawlor
Details
Bug 39597: Fix cancel_hold_alert badge color contrast for accesibilty (1.51 KB, patch)
2025-04-10 13:30 UTC, Brendan Lawlor
Details | Diff | Splinter Review
screenshot with patch (25.78 KB, image/png)
2025-04-10 13:34 UTC, Brendan Lawlor
Details
Bug 39597: Fix cancel_hold_alert badge color contrast for accesibilty (1.57 KB, patch)
2025-04-11 17:44 UTC, Phil Ringnalda
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Brendan Lawlor 2025-04-09 20:32:49 UTC
Created attachment 180747 [details]
screnshot

To recreate:
- Go to a bib record and place multiple holds on it
- Select multiple holds and click 'Cancel selected (4)'
- The Alert says 'This action will cancel 4 hold(s).'
- Note that the contrast on the number of holds is very low
Comment 1 Brendan Lawlor 2025-04-09 20:41:01 UTC
Created attachment 180748 [details] [review]
Bug 39597: Fix cancel_hold_alert badge color contrast for accesibilty

This patch updates the classes on the badge element to fix color contrast

To test:
1. Go to a bib record and place multiple holds on it
2. Select multiple holds and click 'Cancel selected (4)'
3. The Alert says 'This action will cancel 4 hold(s).'
4. Note that the contrast on the number of holds is very low
5. Click 'Cancel' apply patch and restart_all
6. Repeat steps 2-3
7. Note that the contrast on the number of holds is good
Comment 2 Brendan Lawlor 2025-04-09 20:43:36 UTC
Created attachment 180749 [details]
contrast with patch
Comment 3 Owen Leonard 2025-04-10 12:17:44 UTC
I think this is correct, but for the full fix it needs to be on top of Bug 39274, but drop the 'text-dark' part:

<span class='badge bg-danger'>
Comment 4 Brendan Lawlor 2025-04-10 13:30:17 UTC
Created attachment 180776 [details] [review]
Bug 39597: Fix cancel_hold_alert badge color contrast for accesibilty

This patch add a class for the background on the badge element to fix color contrast

To test:
1. Go to a bib record and place multiple holds on it
2. Select multiple holds and click 'Cancel selected (4)'
3. The Alert says 'This action will cancel 4 hold(s).'
4. Note that the contrast on the number of holds is very low
5. Click 'Cancel' apply patch and restart_all
6. Repeat steps 2-3
7. Note that the contrast on the number of holds is good
Comment 5 Brendan Lawlor 2025-04-10 13:34:09 UTC
Created attachment 180777 [details]
screenshot with patch

Thanks Owen!

With bug 39274 applied this looks good
Comment 6 Phil Ringnalda 2025-04-11 17:44:38 UTC
Created attachment 180885 [details] [review]
Bug 39597: Fix cancel_hold_alert badge color contrast for accesibilty

This patch add a class for the background on the badge element to fix color contrast

To test:
1. Go to a bib record and place multiple holds on it
2. Select multiple holds and click 'Cancel selected (4)'
3. The Alert says 'This action will cancel 4 hold(s).'
4. Note that the contrast on the number of holds is very low
5. Click 'Cancel' apply patch and restart_all
6. Repeat steps 2-3
7. Note that the contrast on the number of holds is good

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>