Bugzilla – Attachment 181989 Details for
Bug 39814
Filters on subscription search are broken
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39814: Restore filtering to the serials search table
Bug-39814-Restore-filtering-to-the-serials-search-.patch (text/plain), 3.27 KB, created by
David Nind
on 2025-05-06 16:10:30 UTC
(
hide
)
Description:
Bug 39814: Restore filtering to the serials search table
Filename:
MIME Type:
Creator:
David Nind
Created:
2025-05-06 16:10:30 UTC
Size:
3.27 KB
patch
obsolete
>From bf9167e635d4dec6c361a0719e6734904e9e8fad Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 6 May 2025 15:49:56 +0200 >Subject: [PATCH] Bug 39814: Restore filtering to the serials search table > >Similar to bug 39775, but for the serials search. > >Test plan: >Create some serials then go to http://localhost:8081/cgi-bin/koha/serials/serials-search.pl >and confirm that the filters now appear at the top of the table (which >is consistent with the other tables) and that they work correctly. > >Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> >Signed-off-by: David Nind <david@davidnind.com> >--- > .../prog/en/modules/serials/serials-search.tt | 24 ++----------------- > 1 file changed, 2 insertions(+), 22 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt >index ea6aa2ec6a..1ad0ab6fef 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt >@@ -200,26 +200,6 @@ > [% END # /UNLESS subscription.cannotdisplay %] > [% END # /FOREACH subscription %] > </tbody> >- <tfoot> >- <tr> >- <td></td> >- <td><input type="text" class="dt-filter" data-column_num="1" placeholder="Search ISSN" /></td> >- <td><input type="text" class="dt-filter" data-column_num="2" placeholder="Search title" /></td> >- <td><input type="text" class="dt-filter" data-column_num="3" placeholder="Search notes" /></td> >- <td><input type="text" class="dt-filter" data-column_num="4" placeholder="Search library" /></td> >- <td><input type="text" class="dt-filter" data-column_num="5" placeholder="Search location" /></td> >- <td><input type="text" class="dt-filter" data-column_num="6" placeholder="Search callnumber" /></td> >- [% SET column_num = 6 %] >- [% UNLESS closed %] >- <td><input type="text" class="dt-filter" data-column_num="7" placeholder="Search expiration date" /></td> >- [% SET column_num = column_num + 1 %] >- [% END %] >- [% FOR field IN additional_fields_for_subscription %] >- <td><input type="text" class="dt-filter" data-column_num="[% loop.count + column_num | html %]" placeholder="Search [% field.name | html %]" /></td> >- [% END %] >- <td></td> >- </tr> >- </tfoot> > </table> > </div> > [% END # /BLOCK subscriptions_table %] >@@ -337,13 +317,13 @@ > var osrlt = $("#opened_panel table").kohaTable({ > pagingType: "full", > order: [[2, "asc"]], >- }); >+ }, null, true); > > var csrlt = $("#closed_panel table").kohaTable({ > // FIXME sort function of additional_fields! > order: [[2, "asc"]], > pagingType: "full", >- }); >+ }, null, true); > > var manarlt = $("#mana_results_datatable").kohaTable({ > pagingType: "full", >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39814
:
181973
|
181984
|
181989
|
182019