On following pages: 1/ serials/claims.pl 2/ serials/serials-search.pl There are filters at the bottom of each array, but they are not related to any action, hence are totally useless. This was introduced by https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 which removed "sTable.fnAddFilters("filter", "200");" Is the solution to add it to columnsettings ? Is there a policy to add tables to columnsettings ?
Created attachment 181973 [details] [review] Bug 39814: Restore filtering to the serials search table Similar to bug 39775, but for the serials search. Test plan: Create some serials then go to http://localhost:8081/cgi-bin/koha/serials/serials-search.pl and confirm that the filters now appear at the top of the table (which is consistent with the other tables) and that they work correctly.
serials/claims.pl is fixed on bug 39775.
Created attachment 181984 [details] [review] Bug 39814: Restore filtering to the serials search table Similar to bug 39775, but for the serials search. Test plan: Create some serials then go to http://localhost:8081/cgi-bin/koha/serials/serials-search.pl and confirm that the filters now appear at the top of the table (which is consistent with the other tables) and that they work correctly. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Created attachment 181989 [details] [review] Bug 39814: Restore filtering to the serials search table Similar to bug 39775, but for the serials search. Test plan: Create some serials then go to http://localhost:8081/cgi-bin/koha/serials/serials-search.pl and confirm that the filters now appear at the top of the table (which is consistent with the other tables) and that they work correctly. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: David Nind <david@davidnind.com>
Note that the library and location column filters only work with what is displayed, and that the codes for the values (such as CPL) don't work.
Created attachment 182019 [details] [review] Bug 39814: Restore filtering to the serials search table Similar to bug 39775, but for the serials search. Test plan: Create some serials then go to http://localhost:8081/cgi-bin/koha/serials/serials-search.pl and confirm that the filters now appear at the top of the table (which is consistent with the other tables) and that they work correctly. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com>
Pushed for 25.05! Well done everyone, thank you!
How to apply on 24.11.x since it uses dataTable() not kohaTable() ?
@Jonathan Druart I'm trying to backport this for 24.11, I've seen the required is in Bug 38255 -- koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt but it looks like something is still missing after adding this chunk. Maybe it depends on a change in datatables I missed ?
Created attachment 187983 [details] [review] Bug 39814: [24.11] Restore filtering to the serials search table
Here is a patch for 24.11, but we won't be able to backport all the changes we pushed to 25.05. That's exactly why all the DT work must have been pushed into the same branch...
Backport tested and pushed to 24.11.x for 24.11.10
Bug appeared with 24.11 DT update, setting to needs documenting
Bug fix/regression, no changes to the manual required.