Bug 39814 - Filters on subscription search are broken
Summary: Filters on subscription search are broken
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Serials (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Jonathan Druart
QA Contact: Baptiste Wojtkowski (bwoj)
URL:
Keywords: rel_24_11_candidate
Depends on: 36640
Blocks:
  Show dependency treegraph
 
Reported: 2025-05-02 11:29 UTC by Baptiste Wojtkowski (bwoj)
Modified: 2025-10-26 23:12 UTC (History)
4 users (show)

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: ---
Comma delimited list of Sponsors:
Crowdfunding goal: 0
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
This restores the column filters to the top of the table for serials search - they are now located at the top of the table, and actually work. This was a regression.
Version(s) released in:
25.05.00,24.11.10
Circulation function:


Attachments
Bug 39814: Restore filtering to the serials search table (3.17 KB, patch)
2025-05-06 13:51 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 39814: Restore filtering to the serials search table (3.22 KB, patch)
2025-05-06 15:41 UTC, Roman Dolny
Details | Diff | Splinter Review
Bug 39814: Restore filtering to the serials search table (3.27 KB, patch)
2025-05-06 16:10 UTC, David Nind
Details | Diff | Splinter Review
Bug 39814: Restore filtering to the serials search table (3.33 KB, patch)
2025-05-07 12:07 UTC, Baptiste Wojtkowski (bwoj)
Details | Diff | Splinter Review
Bug 39814: [24.11] Restore filtering to the serials search table (4.65 KB, patch)
2025-10-16 09:54 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Baptiste Wojtkowski (bwoj) 2025-05-02 11:29:38 UTC
On following pages:
1/ serials/claims.pl
2/ serials/serials-search.pl
There are filters at the bottom of each array, but they are not related to any action, hence are totally useless.

This was introduced by https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 which removed "sTable.fnAddFilters("filter", "200");"


Is the solution to add it to columnsettings ? Is there a policy to add tables to columnsettings ?
Comment 1 Jonathan Druart 2025-05-06 13:51:42 UTC
Created attachment 181973 [details] [review]
Bug 39814: Restore filtering to the serials search table

Similar to bug 39775, but for the serials search.

Test plan:
Create some serials then go to http://localhost:8081/cgi-bin/koha/serials/serials-search.pl
and confirm that the filters now appear at the top of the table (which
is consistent with the other tables) and that they work correctly.
Comment 2 Jonathan Druart 2025-05-06 13:52:29 UTC
serials/claims.pl is fixed on bug 39775.
Comment 3 Roman Dolny 2025-05-06 15:41:25 UTC
Created attachment 181984 [details] [review]
Bug 39814: Restore filtering to the serials search table

Similar to bug 39775, but for the serials search.

Test plan:
Create some serials then go to http://localhost:8081/cgi-bin/koha/serials/serials-search.pl
and confirm that the filters now appear at the top of the table (which
is consistent with the other tables) and that they work correctly.

Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Comment 4 David Nind 2025-05-06 16:10:30 UTC
Created attachment 181989 [details] [review]
Bug 39814: Restore filtering to the serials search table

Similar to bug 39775, but for the serials search.

Test plan:
Create some serials then go to http://localhost:8081/cgi-bin/koha/serials/serials-search.pl
and confirm that the filters now appear at the top of the table (which
is consistent with the other tables) and that they work correctly.

Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Signed-off-by: David Nind <david@davidnind.com>
Comment 5 David Nind 2025-05-06 16:14:11 UTC
Note that the library and location column filters only work with what is displayed, and that the codes for the values (such as CPL) don't work.
Comment 6 Baptiste Wojtkowski (bwoj) 2025-05-07 12:07:57 UTC
Created attachment 182019 [details] [review]
Bug 39814: Restore filtering to the serials search table

Similar to bug 39775, but for the serials search.

Test plan:
Create some serials then go to http://localhost:8081/cgi-bin/koha/serials/serials-search.pl
and confirm that the filters now appear at the top of the table (which
is consistent with the other tables) and that they work correctly.

Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com>
Comment 7 Katrin Fischer 2025-05-08 06:01:25 UTC
Pushed for 25.05!

Well done everyone, thank you!
Comment 8 Fridolin Somers 2025-10-03 14:01:21 UTC
How to apply on 24.11.x since it uses dataTable() not kohaTable() ?
Comment 9 Baptiste Wojtkowski (bwoj) 2025-10-13 14:51:25 UTC
@Jonathan Druart I'm trying to backport this for 24.11, I've seen the required is in Bug 38255 -- koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt but it looks like something is still missing after adding this chunk. Maybe it depends on a change in datatables I missed ?
Comment 10 Jonathan Druart 2025-10-16 09:54:17 UTC
Created attachment 187983 [details] [review]
Bug 39814: [24.11] Restore filtering to the serials search table
Comment 11 Jonathan Druart 2025-10-16 09:55:37 UTC
Here is a patch for 24.11, but we won't be able to backport all the changes we pushed to 25.05.

That's exactly why all the DT work must have been pushed into the same branch...
Comment 12 Baptiste Wojtkowski (bwoj) 2025-10-17 14:28:08 UTC
Backport tested and pushed to 24.11.x for 24.11.10
Comment 13 Baptiste Wojtkowski (bwoj) 2025-10-17 14:29:06 UTC
Bug appeared with 24.11 DT update, setting to needs documenting
Comment 14 David Nind 2025-10-26 23:12:26 UTC
Bug fix/regression, no changes to the manual required.