Bugzilla – Attachment 182391 Details for
Bug 39883
NEW_SUGGESTION email notices end up in the patrons notice tab (members/notices.pl) when they should not
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39883: Do not pass the borrowernumber for NEW_SUGGESTION notices
Bug-39883-Do-not-pass-the-borrowernumber-for-NEWSU.patch (text/plain), 1.89 KB, created by
Lin Wei
on 2025-05-13 16:22:48 UTC
(
hide
)
Description:
Bug 39883: Do not pass the borrowernumber for NEW_SUGGESTION notices
Filename:
MIME Type:
Creator:
Lin Wei
Created:
2025-05-13 16:22:48 UTC
Size:
1.89 KB
patch
obsolete
>From 81a37cf9128479c2bf9801321d2d9d8277ca75e6 Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Mon, 12 May 2025 21:53:45 +0000 >Subject: [PATCH] Bug 39883: Do not pass the borrowernumber for NEW_SUGGESTION > notices > >1. Turn on EmailPurchaseSuggestions and add an email address to EmailAddressForSuggestions. >2. Create a new suggestion and set the " >Created by:" field to a patron with an email address >3. Check the message queue ( select * from message_queue where letter_code = "NEW_SUGGESTION" ) >4. There is a NEW_SUGGESTION queued, the to_address should be the email you entered in EmailAddressForSuggestions. >5. The borrowernumber is the borrower who made the suggestion. >6. APPLY PATCH, restart_all >7. Repeat steps 2 - 4. >8. This time a NEW_SUGGESTION should be queued, but the borrowernumber will be undef >9. Check in the patron's notice tab, there should be nothing queued. > >Signed-off-by: Lin Wei Li <lin-wei.li@inLibro.com> >--- > Koha/Suggestion.pm | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > >diff --git a/Koha/Suggestion.pm b/Koha/Suggestion.pm >index 8a098189b2..47cc5f5566 100644 >--- a/Koha/Suggestion.pm >+++ b/Koha/Suggestion.pm >@@ -110,10 +110,10 @@ sub store { > > C4::Letters::EnqueueLetter( > { >- letter => $letter, >- borrowernumber => $result->suggestedby, >- suggestionid => $result->id, >- to_address => $toaddress, >+ letter => $letter, >+ borrowernumber => undef, #NEW_SUGGESION notices should not end up in the borrowers notice tab >+ suggestionid => $result->id, >+ to_address => $toaddress, > message_transport_type => 'email', > } > ) or warn "can't enqueue letter $letter"; >-- >2.43.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39883
:
182315
| 182391