Bugzilla – Attachment 182556 Details for
Bug 39904
EDIFACT error messages are malformed
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39904: (QA follow-up) Fix a few other cases
Bug-39904-QA-follow-up-Fix-a-few-other-cases.patch (text/plain), 2.29 KB, created by
Emily Lamancusa (emlam)
on 2025-05-16 20:16:10 UTC
(
hide
)
Description:
Bug 39904: (QA follow-up) Fix a few other cases
Filename:
MIME Type:
Creator:
Emily Lamancusa (emlam)
Created:
2025-05-16 20:16:10 UTC
Size:
2.29 KB
patch
obsolete
>From 1cc06ccad10770d2cccc5aeabeb9ae9949a914b1 Mon Sep 17 00:00:00 2001 >From: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> >Date: Fri, 16 May 2025 16:14:22 -0400 >Subject: [PATCH] Bug 39904: (QA follow-up) Fix a few other cases > >Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> >--- > Koha/Edifact/Transport.pm | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > >diff --git a/Koha/Edifact/Transport.pm b/Koha/Edifact/Transport.pm >index 72979924ba..ec59ae4110 100644 >--- a/Koha/Edifact/Transport.pm >+++ b/Koha/Edifact/Transport.pm >@@ -233,7 +233,7 @@ sub ftp_download { > "Cannot connect to " . $self->{account}->host . ": $EVAL_ERROR" > ); > $ftp->login( $self->{account}->username, Koha::Encryption->new->decrypt_hex( $self->{account}->password ) ) >- or return $self->_abort_download( $ftp, "Cannot login: $ftp->message()" ); >+ or return $self->_abort_download( $ftp, "Cannot login: " . $ftp->message() ); > $ftp->cwd( $self->{account}->download_directory ) > or return $self->_abort_download( > $ftp, >@@ -249,7 +249,7 @@ sub ftp_download { > if ( !$ftp->get( $filename, "$self->{working_dir}/$filename" ) ) { > $self->_abort_download( > $ftp, >- "Error retrieving $filename: $ftp->message" >+ "Error retrieving $filename: " . $ftp->message > ); > last; > } >@@ -281,7 +281,7 @@ sub ftp_upload { > "Cannot connect to " . $self->{account}->host . ": $EVAL_ERROR" > ); > $ftp->login( $self->{account}->username, Koha::Encryption->new->decrypt_hex( $self->{account}->password ) ) >- or return $self->_abort_download( $ftp, "Cannot login: $ftp->message()" ); >+ or return $self->_abort_download( $ftp, "Cannot login: " . $ftp->message() ); > $ftp->cwd( $self->{account}->upload_directory ) > or return $self->_abort_download( > $ftp, >@@ -361,7 +361,7 @@ sub file_upload { > $m->status('sent'); > $m->update; > } else { >- carp "Could not transfer $m->filename : $ERRNO"; >+ carp "Could not transfer " . $m->filename . " : $ERRNO"; > next; > } > } >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39904
:
182458
|
182463
|
182555
| 182556