Perl can interpolate hashrefs but not method calls. This results in messages like "Cannot connect to Koha::Schema::Result::VendorEdiAccount=HASH(0xaaab059252f0)->host: Name or service not known: My Test at ./misc/cronjobs/edi_cron.pl line 58." when running the edi_cron.pl cronjob.
Created attachment 182458 [details] [review] Bug 39904: EDIFACT error messages are malformed Perl can interpolate hashrefs but not method calls. This results in messages like "Cannot connect to Koha::Schema::Result::VendorEdiAccount=HASH(0xaaab059252f0)->host: Name or service not known: My Test at ./misc/cronjobs/edi_cron.pl line 58." when running the edi_cron.pl cronjob. Test Plan: 1) Enable EDIFACT 2) Create a fake EDI account with a bad FTP server in it 3) Run edi_cron.pl 4) Note the errors like: Cannot connect to Koha::Schema::Result::VendorEdiAccount=HASH(0xaaab059252f0)->host: Name or service not known: My Test at ./misc/cronjobs/edi_cron.pl line 58. 5) Apply this patch 6) Run edi_cron.pl 7) Note the errors are now like: Cannot connect to test.example.com: Name or service not known: My Test at ./misc/cronjobs/edi_cron.pl line 58.
Created attachment 182463 [details] [review] Bug 39904: EDIFACT error messages are malformed Perl can interpolate hashrefs but not method calls. This results in messages like "Cannot connect to Koha::Schema::Result::VendorEdiAccount=HASH(0xaaab059252f0)->host: Name or service not known: My Test at ./misc/cronjobs/edi_cron.pl line 58." when running the edi_cron.pl cronjob. Test Plan: 1) Enable EDIFACT 2) Create a fake EDI account with a bad FTP server in it 3) Run edi_cron.pl 4) Note the errors like: Cannot connect to Koha::Schema::Result::VendorEdiAccount=HASH(0xaaab059252f0)->host: Name or service not known: My Test at ./misc/cronjobs/edi_cron.pl line 58. 5) Apply this patch 6) Run edi_cron.pl 7) Note the errors are now like: Cannot connect to test.example.com: Name or service not known: My Test at ./misc/cronjobs/edi_cron.pl line 58. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 182555 [details] [review] Bug 39904: EDIFACT error messages are malformed Perl can interpolate hashrefs but not method calls. This results in messages like "Cannot connect to Koha::Schema::Result::VendorEdiAccount=HASH(0xaaab059252f0)->host: Name or service not known: My Test at ./misc/cronjobs/edi_cron.pl line 58." when running the edi_cron.pl cronjob. Test Plan: 1) Enable EDIFACT 2) Create a fake EDI account with a bad FTP server in it 3) Run edi_cron.pl 4) Note the errors like: Cannot connect to Koha::Schema::Result::VendorEdiAccount=HASH(0xaaab059252f0)->host: Name or service not known: My Test at ./misc/cronjobs/edi_cron.pl line 58. 5) Apply this patch 6) Run edi_cron.pl 7) Note the errors are now like: Cannot connect to test.example.com: Name or service not known: My Test at ./misc/cronjobs/edi_cron.pl line 58. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Created attachment 182556 [details] [review] Bug 39904: (QA follow-up) Fix a few other cases Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
It feels like a regression test might make sense here?
Pushed for 25.05! Well done everyone, thank you!