Bugzilla – Attachment 182700 Details for
Bug 39960
Improve messages in the OPAC ask for a discharge page (opac-discharge.tt)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39960: Improve messages in opac-discharge.tt
Bug-39960-Improve-messages-in-opac-dischargett.patch (text/plain), 2.87 KB, created by
Tomás Cohen Arazi (tcohen)
on 2025-05-21 19:08:44 UTC
(
hide
)
Description:
Bug 39960: Improve messages in opac-discharge.tt
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2025-05-21 19:08:44 UTC
Size:
2.87 KB
patch
obsolete
>From 2420a8f152abe4403f987716f0136508c5b5f76c Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Wed, 21 May 2025 16:00:10 -0300 >Subject: [PATCH] Bug 39960: Improve messages in opac-discharge.tt > >This patch makes the messages more streamlined. > >To test: >1. Enable `useDischarge` >2. Have a patron with two checkouts >3. Log into the OPAC and try to request a discharge >=> FAIL: You get a message that says '2 item(s)' and has redundant >words. >4. Check one of the items in >5. Repeat 3 >=> FAIL: Same, but says '1 item(s)'. >6. Check it in >7. Add a manual fee >8. Repeat 3 >=> FAIL: Another redundant text about charges. >9. Apply this patch and repeat 2-8 >=> SUCCESS: Things read better >10. Sign off :-D >--- > .../opac-tmpl/bootstrap/en/modules/opac-discharge.tt | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-discharge.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-discharge.tt >index 1c1bba80a0e..8c27c16d045 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-discharge.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-discharge.tt >@@ -57,17 +57,19 @@ > </form> > [% ELSE %] > [% IF failure %] >- <p> There was an error during the discharge process </p> >+ <p>There was an error during the discharge process</p> > [% END %] > <div class="alert alert-info" > >You cannot be discharged because: > <ul> >- [% IF discharge_problems.checkouts %] >- <li> You have [% discharge_problems.checkouts | html %] item(s) checked out. Please return your checked out items before reapplying. </li> >+ [% IF discharge_problems.checkouts > 1 %] >+ <li>You have [% discharge_problems.checkouts | html %] items checked out. Please return them before reapplying.</li> >+ [% ELSIF discharge_problems.checkouts == 1 %] >+ <li>You currently have an item checked out. Please return it before reapplying.</li> > [% END %] > > [% IF discharge_problems.debt %] >- <li> You have unpaid charges of [% discharge_problems.debt | $Price %]. Please pay your charges before reapplying. </li> >+ <li>You have unpaid charges of [% discharge_problems.debt | $Price %]. Please pay them before reapplying.</li> > [% END %] > </ul> > </div> >-- >2.49.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39960
:
182700
|
182707