Bug 39960 - Improve messages in the OPAC ask for a discharge page (opac-discharge.tt)
Summary: Improve messages in the OPAC ask for a discharge page (opac-discharge.tt)
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Tomás Cohen Arazi (tcohen)
QA Contact: Testopia
URL:
Keywords:
Depends on: 14250
Blocks:
  Show dependency treegraph
 
Reported: 2025-05-21 18:59 UTC by Tomás Cohen Arazi (tcohen)
Modified: 2025-05-21 20:29 UTC (History)
3 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
This enhancement improves the messages in the OPAC on the ask for a discharge page (Your account > Ask for discharge, when the useDischarge system preference is enabled). Improvements: - Improved wording for the number of items checked out: instead of "..2 item(s).." and "..1 item(s)..." the text changes based on the actual number of checkouts - "...2 items..." and "...an item...". - More succinct text: for example, instead of "Please pay your charges before reapplying.", "Please pay them before reapplying."
Version(s) released in:
Circulation function:


Attachments
Bug 39960: Improve messages in opac-discharge.tt (2.87 KB, patch)
2025-05-21 19:08 UTC, Tomás Cohen Arazi (tcohen)
Details | Diff | Splinter Review
Bug 39960: Improve messages in opac-discharge.tt (2.91 KB, patch)
2025-05-21 20:15 UTC, David Nind
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Tomás Cohen Arazi (tcohen) 2025-05-21 18:59:25 UTC
There's a use of 'item(s)' that can be avoided, and the messages contain a redundant 'checked out items' that could just be 'them'.
Comment 1 Tomás Cohen Arazi (tcohen) 2025-05-21 19:08:44 UTC
Created attachment 182700 [details] [review]
Bug 39960: Improve messages in opac-discharge.tt

This patch makes the messages more streamlined.

To test:
1. Enable `useDischarge`
2. Have a patron with two checkouts
3. Log into the OPAC and try to request a discharge
=> FAIL: You get a message that says '2 item(s)' and has redundant
words.
4. Check one of the items in
5. Repeat 3
=> FAIL: Same, but says '1 item(s)'.
6. Check it in
7. Add a manual fee
8. Repeat 3
=> FAIL: Another redundant text about charges.
9. Apply this patch and repeat 2-8
=> SUCCESS: Things read better
10. Sign off :-D
Comment 2 David Nind 2025-05-21 20:15:28 UTC
Created attachment 182707 [details] [review]
Bug 39960: Improve messages in opac-discharge.tt

This patch makes the messages more streamlined.

To test:
1. Enable `useDischarge`
2. Have a patron with two checkouts
3. Log into the OPAC and try to request a discharge
=> FAIL: You get a message that says '2 item(s)' and has redundant
words.
4. Check one of the items in
5. Repeat 3
=> FAIL: Same, but says '1 item(s)'.
6. Check it in
7. Add a manual fee
8. Repeat 3
=> FAIL: Another redundant text about charges.
9. Apply this patch and repeat 2-8
=> SUCCESS: Things read better
10. Sign off :-D

Signed-off-by: David Nind <david@davidnind.com>