Bugzilla – Attachment 182840 Details for
Bug 39991
Record comparison in vendor file - results no longer side by side
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39991: Fix MARC record display on showdiffmarc.pl
Bug-39991-Fix-MARC-record-display-on-showdiffmarcp.patch (text/plain), 3.69 KB, created by
Emily Lamancusa (emlam)
on 2025-05-29 15:31:02 UTC
(
hide
)
Description:
Bug 39991: Fix MARC record display on showdiffmarc.pl
Filename:
MIME Type:
Creator:
Emily Lamancusa (emlam)
Created:
2025-05-29 15:31:02 UTC
Size:
3.69 KB
patch
obsolete
>From baeff69d324f9edda6086664c5675e8f7090898d Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Tue, 27 May 2025 15:40:48 +0000 >Subject: [PATCH] Bug 39991: Fix MARC record display on showdiffmarc.pl > >To test: > >1. Download a record you already have in Koha >2. Cataloging > Stage MARC records for import >3. Record matching rule: KohaBiblio (99$c) >4. Stage for import > View batch >5. In the table results there should be a link to 'View' in the 'Diff' column. >6. Notice the Record comparison is not side by side. >7. APPLY PATCH >8. Try steps 1 - 6 again, this time the record comparison should be side by side. > >Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> >--- > .../prog/en/modules/tools/showdiffmarc.tt | 42 ++++++++++--------- > 1 file changed, 22 insertions(+), 20 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/showdiffmarc.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/showdiffmarc.tt >index c9521745c2..55aef0bcbd 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/showdiffmarc.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/showdiffmarc.tt >@@ -59,26 +59,28 @@ > > <div class="page-section col-sm-12"> > <h2>[% RECORDTITLE | html %]</h2> >- <div id="col1" class="col-sm-6"> >- <h3>Original</h3> >- [% IF ( ERROR_FORMATTED1 ) %] >- <div class="alert alert-warning"> >- <p>The record ID <em>[% RECORDID | html %]</em> doesn't match any existing record.</p> >- </div> >- [% ELSE %] >- <pre>[% MARC_FORMATTED1 | html %]</pre> >- [% END %] >- </div> >- <div id="col2" class="col-sm-6"> >- <h3>Imported</h3> >- [% IF ( ERROR_FORMATTED2 ) %] >- <div class="alert alert-warning"> >- <p>The import ID number <em>[% IMPORTID | html %]</em> doesn't match any existing record.</p> >- </div> >- [% ELSE %] >- <h3>[% IMPORTTITLE | html %]</h3> >- <pre>[% MARC_FORMATTED2 | html %] </pre> >- [% END %] >+ <div class="row"> >+ <div id="col1" class="col-sm-6"> >+ <h3>Original</h3> >+ [% IF ( ERROR_FORMATTED1 ) %] >+ <div class="alert alert-warning"> >+ <p>The record ID <em>[% RECORDID | html %]</em> doesn't match any existing record.</p> >+ </div> >+ [% ELSE %] >+ <pre>[% MARC_FORMATTED1 | html %]</pre> >+ [% END %] >+ </div> >+ <div id="col2" class="col-sm-6"> >+ <h3>Imported</h3> >+ [% IF ( ERROR_FORMATTED2 ) %] >+ <div class="alert alert-warning"> >+ <p>The import ID number <em>[% IMPORTID | html %]</em> doesn't match any existing record.</p> >+ </div> >+ [% ELSE %] >+ <h3>[% IMPORTTITLE | html %]</h3> >+ <pre>[% MARC_FORMATTED2 | html %] </pre> >+ [% END %] >+ </div> > </div> > </div> > <fieldset class="action"> >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39991
:
182802
|
182809
| 182840