Bug 39991 - Record comparison in vendor file - results no longer side by side
Summary: Record comparison in vendor file - results no longer side by side
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Lucas Gass (lukeg)
QA Contact: Emily Lamancusa (emlam)
URL:
Keywords: rel_25_05_candidate
Depends on: 39172
Blocks:
  Show dependency treegraph
 
Reported: 2025-05-25 04:17 UTC by Brian Pichman
Modified: 2025-07-16 13:16 UTC (History)
7 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes the 'Diff' view for staged records where they match existing records - the comparison is shown side by side instead of imported record being shown below the original record (Cataloging > Manage staged records > [select a file] > View [from the Diff column for a record]).
Version(s) released in:
25.11.00,25.05.01,24.11.06
Circulation function:


Attachments
Bug 39991: Fix MARC record display on showdiffmarc.pl (3.62 KB, patch)
2025-05-27 15:42 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 39991: Fix MARC record display on showdiffmarc.pl (3.62 KB, patch)
2025-05-28 06:49 UTC, Magnus Enger
Details | Diff | Splinter Review
Bug 39991: Fix MARC record display on showdiffmarc.pl (3.69 KB, patch)
2025-05-29 15:31 UTC, Emily Lamancusa (emlam)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Pichman 2025-05-25 04:17:11 UTC
In the past the current record in Koha and the vendor record would be displayed side by side for comparison. Since the latest upgrade, they are now stacked, with the existing Koha record on top, and the vendor record below it. This means for every record we need to check, we have to scroll down to be sure the grid has been applied correctly. 

Steps to Reproduce The Problem:
Receive a .mrc file from a library
Stage and upload it through the cataloging module.

In order to make sure the grid has been applied on the vendor side, view the record after staging the file.  The results are now stacked.
Comment 1 Brian Pichman 2025-05-25 04:18:18 UTC
There was this bug: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39172 that might be related
Comment 2 Katrin Fischer 2025-05-26 08:56:03 UTC
Hi Brian, this might already have been fixed, but I can't find the bug report right now. Are you on latest 24.05 or can confirm this is not present in 24.11 maybe?

PS: I have updated the bug title to follow Koha's capitalization rules. As they appear in release notes that is to aim for a more standardized look.
Comment 3 Brian Pichman 2025-05-26 09:25:53 UTC
Apologies on the capitalzations! 

Yes, it's happening in 24.05, but I'll check if it's on 24.11. I'll also triple check to see if I can find an existing bug that's been patched! Thanks for the help!
Comment 4 Katrin Fischer 2025-05-26 09:35:49 UTC
No worries, I just thought I'd mention it since it's your first bug and to explain what I was doing :)

I gave it a second go with different search terms, found it!

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39172

It looks like this hasn't been backported to 24.05 so far.
Comment 5 Lucas Gass (lukeg) 2025-05-27 15:40:00 UTC
I recreate this in current main:

1. Download a record you already have in Koha
2. Cataloging > Stage MARC records for import
3. Record matching rule: KohaBiblio (99$c)
4. Stage for import > View batch 
5. In the table results there should be a link to 'View' in the 'Diff' column.
6. Notice the Record comparison is not side by side.
Comment 6 Lucas Gass (lukeg) 2025-05-27 15:42:31 UTC Comment hidden (obsolete)
Comment 7 Magnus Enger 2025-05-28 06:49:32 UTC
Created attachment 182809 [details] [review]
Bug 39991: Fix MARC record display on showdiffmarc.pl

To test:

1. Download a record you already have in Koha
2. Cataloging > Stage MARC records for import
3. Record matching rule: KohaBiblio (99$c)
4. Stage for import > View batch
5. In the table results there should be a link to 'View' in the 'Diff' column.
6. Notice the Record comparison is not side by side.
7. APPLY PATCH
8. Try steps 1 - 6 again, this time the record comparison should be side by side.
Comment 8 Emily Lamancusa (emlam) 2025-05-29 15:31:02 UTC
Created attachment 182840 [details] [review]
Bug 39991: Fix MARC record display on showdiffmarc.pl

To test:

1. Download a record you already have in Koha
2. Cataloging > Stage MARC records for import
3. Record matching rule: KohaBiblio (99$c)
4. Stage for import > View batch
5. In the table results there should be a link to 'View' in the 'Diff' column.
6. Notice the Record comparison is not side by side.
7. APPLY PATCH
8. Try steps 1 - 6 again, this time the record comparison should be side by side.

Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Comment 9 Lucas Gass (lukeg) 2025-06-02 21:27:57 UTC
Nice work everyone!

Pushed to main for 25.11
Comment 10 Lisette Scheer 2025-06-09 20:50:00 UTC
Could this be backported to 25.05?
Comment 11 Fridolin Somers 2025-06-19 07:40:56 UTC
I see in 25.05.x
Comment 12 Fridolin Somers 2025-06-19 07:41:27 UTC
Pushed to 24.11.x for 24.11.06
Comment 13 Paul Derscheid 2025-06-19 09:02:05 UTC
Nice work everyone!

Pushed to 25.05.x for 25.05.03
Comment 14 Jesse Maseto 2025-07-16 13:16:27 UTC
Merge conflicts with 24.05.x

Please resolve if needed in this version.