Bugzilla – Attachment 183081 Details for
Bug 40080
Course reserves details search appears offscreen
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40080: QA Follow-up - Code tidy-up based on QA tool feedback
Bug-40080-QA-Follow-up---Code-tidy-up-based-on-QA-.patch (text/plain), 8.87 KB, created by
Laura Escamilla
on 2025-06-06 20:12:22 UTC
(
hide
)
Description:
Bug 40080: QA Follow-up - Code tidy-up based on QA tool feedback
Filename:
MIME Type:
Creator:
Laura Escamilla
Created:
2025-06-06 20:12:22 UTC
Size:
8.87 KB
patch
obsolete
>From 7fcd4687baea4fea58253f882af308c7106b62d8 Mon Sep 17 00:00:00 2001 >From: Laura_Escamilla <laura.escamilla@bywatersolutions.com> >Date: Fri, 6 Jun 2025 20:10:09 +0000 >Subject: [PATCH] Bug 40080: QA Follow-up - Code tidy-up based on QA tool > feedback > >--- > .../en/modules/opac-course-details.tt | 112 +++++++++--------- > 1 file changed, 56 insertions(+), 56 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-course-details.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-course-details.tt >index 9af6cc41da..61a2eec1fa 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-course-details.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-course-details.tt >@@ -60,64 +60,64 @@ > </div> > > [% IF ( course_reserves ) %] >- <div class="rows"> >- <table id="course-items-table" class="table table-bordered table-striped table-condensed"> >- <caption class="sr-only">Courses</caption> >- <thead> >- <tr> >- <th class="anti-the">Title</th> >- <th>Author</th> >- <th>Item type</th> >- <th>Location</th> >- <th>Collection</th> >- <th>Call number</th> >- <th>Copy number</th> >- <th>Status</th> >- <th>Date due</th> >- <th>Notes</th> >- <th>Link</th> >- <th></th> >- </tr> >- </thead> >- >- <tbody> >- [% FOREACH cr IN course_reserves %] >+ <div class="rows"> >+ <table id="course-items-table" class="table table-bordered table-striped table-condensed"> >+ <caption class="sr-only">Courses</caption> >+ <thead> > <tr> >- <td><a href="opac-detail.pl?biblionumber=[% cr.biblio.biblionumber | uri %]">[% INCLUDE 'biblio-title-head.inc' biblio=cr.biblio %]</a></td> >- <td>[% cr.biblio.author | html %]</td> >- <td>[% ItemTypes.GetDescription( cr.item.itype ) | html %]</td> >- <td >- >[% Branches.GetName( cr.item.holdingbranch ) | html %] <br /> >- <em>[% AuthorisedValues.GetDescriptionByKohaField( kohafield => 'items.location', authorised_value => cr.item.location, opac => 1 ) | html %]</em></td >- > >- <td>[% AuthorisedValues.GetDescriptionByKohaField( kohafield => 'items.ccode', authorised_value => cr.item.ccode, opac => 1 ) | html %]</td> >- <td>[% cr.item.itemcallnumber | html %]</td> >- <td>[% cr.item.copynumber | html %]</td> >- <td> >- [% IF cr.item %] >- [% INCLUDE 'item-status.inc' item=cr.item issue=cr.issue show_recall_link=Koha.Preference('UseRecalls') %] >- [% END %] >- </td> >- <td data-order="[% cr.issue.date_due | html %]">[% cr.issue.date_due | $KohaDates as_due_date => 1 %]</td> >- <td >- >[% IF ( cr.public_note ) %] >- [% cr.public_note | scrub_html type => 'note' | $raw %] >- [% ELSIF ( cr.item.itemnotes ) %] >- [% cr.item.itemnotes | $raw %] >- [% END %] >- </td> >- <td >- >[% IF (cr.item.uri) %] >- <a href="[% cr.item.uri | url %]">Item URI</a> >- [% ELSIF (cr.biblioitem.url) %] >- <a href="[% cr.biblioitem.url | url %]">Record URL</a> >- [% END %] >- </td> >- <td></td> >+ <th class="anti-the">Title</th> >+ <th>Author</th> >+ <th>Item type</th> >+ <th>Location</th> >+ <th>Collection</th> >+ <th>Call number</th> >+ <th>Copy number</th> >+ <th>Status</th> >+ <th>Date due</th> >+ <th>Notes</th> >+ <th>Link</th> >+ <th></th> > </tr> >- [% END %] >- </tbody> >- </table> >+ </thead> >+ >+ <tbody> >+ [% FOREACH cr IN course_reserves %] >+ <tr> >+ <td><a href="opac-detail.pl?biblionumber=[% cr.biblio.biblionumber | uri %]">[% INCLUDE 'biblio-title-head.inc' biblio=cr.biblio %]</a></td> >+ <td>[% cr.biblio.author | html %]</td> >+ <td>[% ItemTypes.GetDescription( cr.item.itype ) | html %]</td> >+ <td >+ >[% Branches.GetName( cr.item.holdingbranch ) | html %] <br /> >+ <em>[% AuthorisedValues.GetDescriptionByKohaField( kohafield => 'items.location', authorised_value => cr.item.location, opac => 1 ) | html %]</em></td >+ > >+ <td>[% AuthorisedValues.GetDescriptionByKohaField( kohafield => 'items.ccode', authorised_value => cr.item.ccode, opac => 1 ) | html %]</td> >+ <td>[% cr.item.itemcallnumber | html %]</td> >+ <td>[% cr.item.copynumber | html %]</td> >+ <td> >+ [% IF cr.item %] >+ [% INCLUDE 'item-status.inc' item=cr.item issue=cr.issue show_recall_link=Koha.Preference('UseRecalls') %] >+ [% END %] >+ </td> >+ <td data-order="[% cr.issue.date_due | html %]">[% cr.issue.date_due | $KohaDates as_due_date => 1 %]</td> >+ <td >+ >[% IF ( cr.public_note ) %] >+ [% cr.public_note | scrub_html type => 'note' | $raw %] >+ [% ELSIF ( cr.item.itemnotes ) %] >+ [% cr.item.itemnotes | $raw %] >+ [% END %] >+ </td> >+ <td >+ >[% IF (cr.item.uri) %] >+ <a href="[% cr.item.uri | url %]">Item URI</a> >+ [% ELSIF (cr.biblioitem.url) %] >+ <a href="[% cr.biblioitem.url | url %]">Record URL</a> >+ [% END %] >+ </td> >+ <td></td> >+ </tr> >+ [% END %] >+ </tbody> >+ </table> > </div> > [% ELSE %] > <br style="clear:both;" /> >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40080
:
182982
|
182986
|
183015
| 183081