Bug 40080 - Course reserves details search appears offscreen
Summary: Course reserves details search appears offscreen
Status: Pushed to stable
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low normal
Assignee: Martin Renvoize (ashimema)
QA Contact: Laura Escamilla
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-06-05 09:43 UTC by Martin Renvoize (ashimema)
Modified: 2025-06-22 21:47 UTC (History)
3 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes the alignment of the OPAC course reserves search box - it is now on the left above the table, instead of offscreen on the right-hand side.
Version(s) released in:
25.11.00,25.05.01
Circulation function:


Attachments
Screenshot of issue (173.24 KB, image/png)
2025-06-05 09:44 UTC, Martin Renvoize (ashimema)
Details
Bug 40080 - Fix search position on course reserves page (2.41 KB, patch)
2025-06-05 10:13 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 40080: Fix search position on course reserves page (2.46 KB, patch)
2025-06-05 22:20 UTC, David Nind
Details | Diff | Splinter Review
Bug 40080: QA Follow-up - Code tidy-up based on QA tool feedback (8.87 KB, patch)
2025-06-06 20:12 UTC, Laura Escamilla
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize (ashimema) 2025-06-05 09:43:11 UTC
When looking at the opac course reserves details page and reserves are present, the search box for filtering reserves is aligned far to the right of the page, often off page entirely.
Comment 1 Martin Renvoize (ashimema) 2025-06-05 09:44:26 UTC
Created attachment 182982 [details]
Screenshot of issue
Comment 2 Martin Renvoize (ashimema) 2025-06-05 10:13:39 UTC
Created attachment 182986 [details] [review]
Bug 40080 - Fix search position on course reserves page

This patch corrects the position of the table search box on the course
reserves details pages by warpping the presented table in a 'rows' class
div.

We also update the search box dom configuration in the datatable itself
to match that of other opac tables.

Test plan
1) Add some course reserves to a course
2) View that course on the OPAC
3) Note that the search box for the table is aligned to the top of the
   main section of the page and over to the far right almost off screen.
4) Apply this patch
5) Confirm that the display of the search box is now nested just above
   the table in the same location as the course reserves list page
Comment 3 David Nind 2025-06-05 22:20:42 UTC
Created attachment 183015 [details] [review]
Bug 40080: Fix search position on course reserves page

This patch corrects the position of the table search box on the course
reserves details pages by warpping the presented table in a 'rows' class
div.

We also update the search box dom configuration in the datatable itself
to match that of other opac tables.

Test plan
1) Add some course reserves to a course
2) View that course on the OPAC
3) Note that the search box for the table is aligned to the top of the
   main section of the page and over to the far right almost off screen.
4) Apply this patch
5) Confirm that the display of the search box is now nested just above
   the table in the same location as the course reserves list page

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 David Nind 2025-06-05 22:23:42 UTC
I fixed the bug title for the commit message - Bug 40080: XXXX.
Comment 5 Laura Escamilla 2025-06-06 20:12:22 UTC
Created attachment 183081 [details] [review]
Bug 40080: QA Follow-up - Code tidy-up based on QA tool feedback
Comment 6 Lucas Gass (lukeg) 2025-06-11 20:08:18 UTC
Nice work everyone!

Pushed to main for 25.11
Comment 7 Paul Derscheid 2025-06-22 21:47:32 UTC
Nice work everyone!

Pushed to 25.05.x for 25.05.03