Bugzilla – Attachment 183514 Details for
Bug 40222
Bootstrap popover components not updated for BS5
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40222: Bootstrap popover components not updated for BS5
Bug-40222-Bootstrap-popover-components-not-updated.patch (text/plain), 3.93 KB, created by
David Flater
on 2025-06-25 16:04:11 UTC
(
hide
)
Description:
Bug 40222: Bootstrap popover components not updated for BS5
Filename:
MIME Type:
Creator:
David Flater
Created:
2025-06-25 16:04:11 UTC
Size:
3.93 KB
patch
obsolete
>From a86e27391dbbf21f3594c12a1cb96f1bc398a8c1 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Mon, 23 Jun 2025 19:09:19 +0000 >Subject: [PATCH] Bug 40222: Bootstrap popover components not updated for BS5 > >This patch corrects a couple of templates which include a Bootstrap >popover component, updating the data attributes which were missed during >the BS5 upgrade. > >The patch also makes a minor change to CSS in order for the popover >heading to not have unwanted margins. > >To test, apply the patch and rebuild the staff interface CSS. > >- Perform a catalog search in the staff interface. >- Add one or more items to the cart. >- Open the cart and hover your cursor over the "Items" heading. A > popover should be triggered with a message about item sorting. >- Go to Administration -> Circulation and Fine rules. >- Edit a rule to add content to the "Note" field. >- Save the rule and then hover your cursor over the "View note" text. > The note you added should appear in a popover. > >Sponsored-by: Athens County Public Libraries >Signed-off-by: David Flater <flaterdavid@gmail.com> >--- > koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss | 4 ++++ > koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt | 2 +- > koha-tmpl/intranet-tmpl/prog/en/modules/basket/basket.tt | 4 ++-- > 3 files changed, 7 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss >index 5798abfd15..c8e5488238 100644 >--- a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss >+++ b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss >@@ -802,6 +802,10 @@ h2 { > > h3 { > color: #696969; >+ >+ &.popover-header { >+ margin: 0; >+ } > } > > h4 { >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt >index e128aa50b2..4930108177 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt >@@ -259,7 +259,7 @@ > </td> > <td> > [% IF note.defined && note != '' %] >- <a id="viewnote" data-bs-toggle="popover" title="Note" data-content="[% note | html %]" data-bs-placement="top" data-trigger="hover">View note</a> >+ <a id="viewnote" data-bs-toggle="popover" title="Note" data-bs-content="[% note | html %]" data-bs-placement="top" data-bs-trigger="hover">View note</a> > [% ELSE %] > <span> </span> > [% END %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/basket/basket.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/basket/basket.tt >index d763dea352..4a8856efa4 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/basket/basket.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/basket/basket.tt >@@ -274,11 +274,11 @@ > <a > id="items-popover" > href="#" >- data-trigger="hover" >+ data-bs-trigger="hover" > data-bs-toggle="popover" > data-bs-placement="top" > title="Item sorting" >- data-content="Items are sorted by the highest or lowest callnumber in a group of items respectively." >+ data-bs-content="Items are sorted by the highest or lowest callnumber in a group of items respectively." > >Items</a > > > </th> >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40222
:
183424
| 183514