Attachment 18359 Details for Bug 10311 – [Signed off] Bug 10311 - Holds queue ignores item-level holds where only one items exists

[patch] [Signed off] Bug 10311 - Holds queue ignores item-level holds where only one items exists

Signed-off-Bug-10311---Holds-queue-ignores-item-le.patch (text/plain), 1.40 KB, created by Melia Meggs on 2013-05-23 22:44:53 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Melia Meggs

Created: 2013-05-23 22:44:53 UTC

Size: 1.40 KB

patch

obsolete

>From 8554b27a90bca01e0a09a89681cba1e9055ba928 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Wed, 22 May 2013 09:52:40 -0400
>Subject: [PATCH] [Signed off] Bug 10311 - Holds queue ignores item-level holds where only one items exists
>
>If a record has only one item, and that item has one item-level hold on
>it, that hold will not show in the holds queue.
>
>Test Plan:
>1) Create 1 record with 1 item at BranchA
>2) Create an item-level hold for that item, for pickup at BranchA by a
>   patron of BranchA
>3) Run build_holds_queue.pl
>4) View the holds queue for BranchA
>5) Note the hold is not in there
>6) Apply this patch
>7) Re-run build_holds_queue.pl
>8) View the holds queue again
>9) Not that the hold is now there
>
>Signed-off-by: George Williams <georgew@latahlibrary.org>
>---
> C4/HoldsQueue.pm |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/C4/HoldsQueue.pm b/C4/HoldsQueue.pm
>index dc43113..2052f09 100755
>--- a/C4/HoldsQueue.pm
>+++ b/C4/HoldsQueue.pm
>@@ -406,7 +406,7 @@ sub MapItemsToHoldRequests {
>         push @{ $items_by_branch{ $item->{holdingbranch} } }, $item
>           unless exists $allocated_items{ $item->{itemnumber} };
>     }
>-    return unless keys %items_by_branch;
>+    return \%item_map unless keys %items_by_branch;
> 
>     # now handle the title-level requests
>     $num_items_remaining = scalar(@$available_items) - scalar(keys %allocated_items);
>-- 
>1.7.2.5

Actions: View | Diff | Splinter Review

Attachments on bug 10311: 18315 | 18359 | 18778