Bugzilla – Attachment 183626 Details for
Bug 20601
Untranslatable strings in circulation statistics
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20601: Untranslatable strings in circulation statistics
Bug-20601-Untranslatable-strings-in-circulation-st.patch (text/plain), 8.44 KB, created by
Owen Leonard
on 2025-06-27 18:32:53 UTC
(
hide
)
Description:
Bug 20601: Untranslatable strings in circulation statistics
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2025-06-27 18:32:53 UTC
Size:
8.44 KB
patch
obsolete
>From 03b526dcc821ffad3aaa5e3e368cff49adc46e6f Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Fri, 27 Jun 2025 18:22:42 +0000 >Subject: [PATCH] Bug 20601: Untranslatable strings in circulation statistics > >This patch makes some updates to the circulation statistics wizard in >order to make more information translatable. > >The patch also adds some template plugins to the output of filter >options in order to be able to show descriptions instead of codes, and >corrects the markup for the 'Patron library' dropdown which wasn't >working. > >To test apply the patch and go to Reports -> Statistics wizards -> >Circulation. > >- Test setting some or all options in the "Filter column" and running > the report. > - Confirm that the "Patron library" dropdown works. >- At the top of the results there should be a list of the filter options > you selected and their values. >- All the filter labels should be correct, and the filter values should > should be in their full/description form rather than in code form > (e.g. library, item type, collection code, sorting field, etc.) > >Sponsored-by: Athens County Public Libraries >--- > .../prog/en/modules/reports/issues_stats.tt | 72 +++++++++++++------ > 1 file changed, 51 insertions(+), 21 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_stats.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_stats.tt >index 4ef937e635c..53036c74e5b 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_stats.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_stats.tt >@@ -1,6 +1,9 @@ > [% USE raw %] > [% USE Koha %] > [% USE Branches %] >+[% USE Categories %] >+[% USE ItemTypes %] >+[% USE AuthorisedValues %] > [% PROCESS 'i18n.inc' %] > [% SET footerjs = 1 %] > [% INCLUDE 'doc-head-open.inc' %] >@@ -67,37 +70,66 @@ > [% END %] > [% SWITCH loopfilte.crit %] > [% CASE 0 %] >- <span>Period from [% loopfilte.filter | html %]</span> >+ <strong>Period from:</strong> [% loopfilte.filter | html %] > [% CASE 1 %] >- <span>Period to [% loopfilte.filter | html %]</span> >+ <strong>Period to:</strong> [% loopfilte.filter | html %] > [% CASE 2 %] >- <span>Patron category = [% loopfilte.filter | html %]</span> >+ <strong>Patron category:</strong> [% Categories.GetName( loopfilte.filter ) | html %] > [% CASE 3 %] >- <span>Item type = [% loopfilte.filter | html %]</span> >+ <strong>Item type:</strong> [% ItemTypes.GetDescription( loopfilte.filter ) | html %] > [% CASE 4 %] >- <span>Issuing library = [% loopfilte.filter | html %]</span> >+ <strong>Issuing library:</strong> [% Branches.GetName( loopfilte.filter ) | html %] > [% CASE 5 %] >- <span>Collection = [% loopfilte.filter | html %]</span> >+ <strong>Collection:</strong> [% AuthorisedValues.GetByCode( 'CCODE', loopfilte.filter ) | html %] > [% CASE 6 %] >- <span>Location = [% loopfilte.filter | html %]</span> >+ <strong>Location:</strong> [% AuthorisedValues.GetByCode( 'LOC', loopfilte.filter ) | html %] > [% CASE 7 %] >- <span>Item call number >= [% loopfilte.filter | html %]</span> >+ <strong>Item call number > [% loopfilte.filter | html %] </strong> > [% CASE 8 %] >- <span>Item call number < [% loopfilte.filter | html %]</span> >+ <strong>Item call number < [% loopfilte.filter | html %] </strong> > [% CASE 9 %] >- <span>Patron sort1 = [% loopfilte.filter | html %]</span> >+ <strong>Patron sort1:</strong> [% AuthorisedValues.GetByCode('Bsort1', loopfilte.filter ) | html %] > [% CASE 10 %] >- <span>Patron sort2 = [% loopfilte.filter | html %]</span> >+ <strong>Patron sort2:</strong> [% AuthorisedValues.GetByCode('Bsort2', loopfilte.filter ) | html %] > [% CASE 11 %] >- <span>Home library = [% loopfilte.filter | html %]</span> >+ <strong>Home library:</strong> [% Branches.GetName( loopfilte.filter ) | html %] > [% CASE 12 %] >- <span>Holding library = [% loopfilte.filter | html %]</span> >+ <strong>Holding library:</strong> [% Branches.GetName( loopfilte.filter ) | html %] > [% CASE 13 %] >- <span>Patron library = [% loopfilte.filter | html %]</span> >+ <strong>Patron library:</strong> [% Branches.GetName( loopfilte.filter ) | html %] > [% CASE 14 %] >- <span>Issuing library = [% loopfilte.filter | html %]</span> >+ <strong>Issuing library:</strong> [% Branches.GetName( loopfilte.filter ) | html %] >+ [% CASE "Event" %] >+ <strong>Event:</strong> >+ [% SWITCH ( loopfilte.filter ) %] >+ [% CASE "issue" %] >+ <span>Checkout</span> >+ [% CASE "return" %] >+ <span>Check-in</span> >+ [% CASE "renew" %] >+ <span>Renewal</span> >+ [% CASE %] >+ [% loopfilte.filter | html %] >+ [% END %] >+ [% CASE "Select Day" %] >+ <strong>Select day:</strong> [% loopfilte.filter | html %] >+ [% CASE "Select Month" %] >+ <strong>Select month:</strong> [% loopfilte.filter | html %] >+ [% CASE "Display by" %] >+ <strong>Group by:</strong> >+ [% SWITCH ( loopfilte.filter ) %] >+ [% CASE "1" %] >+ <span>Day of week</span> >+ [% CASE "2" %] >+ <span>Month</span> >+ [% CASE "3" %] >+ <span>Year</span> >+ [% CASE "4" %] >+ <span>Hour</span> >+ [% END %] > [% CASE %] >- <span>[% loopfilte.crit | html %] = [% loopfilte.filter | html %]</span> >+ [% loopfilte.crit | html %]: >+ [% loopfilte.filter | html %] > [% END %] > </li> > [% END %] >@@ -336,11 +368,9 @@ > <td><input type="radio" name="Line" value="borrowers.branchcode" /></td> > <td><input type="radio" name="Column" value="borrowers.branchcode" /></td> > <td> >- <select name="Filter" id="patronbranch"> >- <option value=""> </option> >- [% FOREACH branch IN branchloop %] >- <option value="[% branch.value | html %]"> [% branch.branchname | html %] </option> >- [% END %] >+ <select name="Filter" id="patron_library"> >+ <option value=""> </option> >+ [% PROCESS options_for_libraries libraries => Branches.all() %] > </select> > </td> > </tr> >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20601
:
183626
|
183630