Bug 20601 - Untranslatable strings in circulation statistics
Summary: Untranslatable strings in circulation statistics
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: I18N/L10N (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-04-18 09:49 UTC by paxed
Modified: 2025-06-27 19:52 UTC (History)
2 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes and enhances the circulation statistics report wizard: - Fixes some strings so that they are now translatable - Fixes the patron library dropdown list so that it now works - Improves the "Filtered on" information shown before the report results: . the filtered on options selected in the report are now shown in bold . descriptions are now shown instead of codes (for example, the library name instead of the library code)
Version(s) released in:
Circulation function:


Attachments
Bug 20601: Untranslatable strings in circulation statistics (8.44 KB, patch)
2025-06-27 18:32 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 20601: Untranslatable strings in circulation statistics (8.49 KB, patch)
2025-06-27 19:42 UTC, David Nind
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description paxed 2018-04-18 09:49:43 UTC
Untranslatable strings:

reports/issues_stats.pl:

    push @loopfilter, { crit => "Event",        filter => $type };
    push @loopfilter, { crit => "Display by",   filter => $dsp } if ($dsp);
    push @loopfilter, { crit => "Select Day",   filter => $daysel } if ($daysel);
    push @loopfilter, { crit => "Select Month", filter => $monthsel } if ($monthsel);
Comment 1 Owen Leonard 2025-06-27 18:32:53 UTC
Created attachment 183626 [details] [review]
Bug 20601: Untranslatable strings in circulation statistics

This patch makes some updates to the circulation statistics wizard in
order to make more information translatable.

The patch also adds some template plugins to the output of filter
options in order to be able to show descriptions instead of codes, and
corrects the markup for the 'Patron library' dropdown which wasn't
working.

To test apply the patch and go to Reports -> Statistics wizards ->
Circulation.

- Test setting some or all options in the "Filter column" and running
  the report.
  - Confirm that the "Patron library" dropdown works.
- At the top of the results there should be a list of the filter options
  you selected and their values.
- All the filter labels should be correct, and the filter values should
  should be in their full/description form rather than in code form
  (e.g. library, item type, collection code, sorting field, etc.)

Sponsored-by: Athens County Public Libraries
Comment 2 David Nind 2025-06-27 19:42:07 UTC
Created attachment 183630 [details] [review]
Bug 20601: Untranslatable strings in circulation statistics

This patch makes some updates to the circulation statistics wizard in
order to make more information translatable.

The patch also adds some template plugins to the output of filter
options in order to be able to show descriptions instead of codes, and
corrects the markup for the 'Patron library' dropdown which wasn't
working.

To test apply the patch and go to Reports -> Statistics wizards ->
Circulation.

- Test setting some or all options in the "Filter column" and running
  the report.
  - Confirm that the "Patron library" dropdown works.
- At the top of the results there should be a list of the filter options
  you selected and their values.
- All the filter labels should be correct, and the filter values should
  should be in their full/description form rather than in code form
  (e.g. library, item type, collection code, sorting field, etc.)

Sponsored-by: Athens County Public Libraries
Signed-off-by: David Nind <david@davidnind.com>