Bugzilla – Attachment 184142 Details for
Bug 40409
t/db_dependent/Overdues.t generates warnings
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40409: Make Overdues.t fail
Bug-40409-Make-Overduest-fail.patch (text/plain), 1.13 KB, created by
Jonathan Druart
on 2025-07-16 10:35:02 UTC
(
hide
)
Description:
Bug 40409: Make Overdues.t fail
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2025-07-16 10:35:02 UTC
Size:
1.13 KB
patch
obsolete
>From 8a038a0491e79f373c6537bb8abef239a222bc20 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 16 Jul 2025 12:32:52 +0200 >Subject: [PATCH] Bug 40409: Make Overdues.t fail > >The test is wrong, the item is not correctly checked in, it should fail. >--- > t/db_dependent/Overdues.t | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > >diff --git a/t/db_dependent/Overdues.t b/t/db_dependent/Overdues.t >index 979f378a25f..a65bacbe10b 100755 >--- a/t/db_dependent/Overdues.t >+++ b/t/db_dependent/Overdues.t >@@ -549,10 +549,8 @@ subtest 'UpdateFine tests' => sub { > { order_by => { '-asc' => 'accountlines_id' } } > ); > is( $fines->count, 4, "New amount should be 0 so no fine added" ); >- ok( >- C4::Circulation::AddReturn( $item_1->barcode, $item_1->homebranch, 1 ), >- "Returning the item and forgiving fines succeeds" >- ); >+ my @r = C4::Circulation::AddReturn( $item_1->barcode, $item_1->homebranch, 1 ); >+ is( $r[1]->{WasReturned}, 1, "Returning the item and forgiving fines succeeds" ); > > t::lib::Mocks::mock_preference( 'MaxFine', 0 ); > >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40409
: 184142 |
184143