Bug 40409 - t/db_dependent/Overdues.t generates warnings
Summary: t/db_dependent/Overdues.t generates warnings
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low minor
Assignee: Jonathan Druart
QA Contact: Martin Renvoize (ashimema)
URL:
Keywords:
Depends on: 25127
Blocks: 40444
  Show dependency treegraph
 
Reported: 2025-07-16 10:32 UTC by Jonathan Druart
Modified: 2025-08-01 13:15 UTC (History)
2 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.11.00,25.05.02,24.11.08
Circulation function:


Attachments
Bug 40409: Make Overdues.t fail (1.13 KB, patch)
2025-07-16 10:35 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 40409: Remove warnings from t/db_dependent/Overdues.t (1.34 KB, patch)
2025-07-16 10:35 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 40409: Make Overdues.t fail (1.17 KB, patch)
2025-07-18 08:26 UTC, David Nind
Details | Diff | Splinter Review
Bug 40409: Remove warnings from t/db_dependent/Overdues.t (1.39 KB, patch)
2025-07-18 08:26 UTC, David Nind
Details | Diff | Splinter Review
Bug 40409: Make Overdues.t fail (1.24 KB, patch)
2025-07-18 12:16 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 40409: Remove warnings from t/db_dependent/Overdues.t (1.46 KB, patch)
2025-07-18 12:16 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2025-07-16 10:32:07 UTC
t/db_dependent/Overdues.t .. 1/18 The checkin for the following issue failed, Please go to the about page and check all messages on the 'System information' to see if there are configuration / data issues ({UNKNOW
N}: Can't use an undefined value as a HASH reference at /kohadevbox/koha/C4/Circulation.pm line 2744. at /kohadevbox/koha/C4/Circulation.pm line 2787                                                                
)$VAR1 = {                                                                                                
          'borrowernumber' => 1669,                                                                       
          'auto_renew' => 0,                                                                              
          'returndate' => '2025-07-16 10:22:21',                                                          
          'unseen_renewals' => 1,                                                                         
          'timestamp' => '2025-07-16 10:22:21',                                                           
          'note' => 'dgdIcu',                                                                             
          'auto_renew_error' => 'NOnHFifbC42AwnAJ4V',                                                     
          'lastreneweddate' => '2025-07-16 10:22:21',                                                                                                                                                                
          'checkin_library' => 'IDWOMcg',                                                                                                                                                                            
          'onsite_checkout' => 0,                                                                         
          'renewals_count' => 0,                                                                          
          'itemnumber' => 1497,                                                                                                                                                                                      
          'issuer_id' => 1670,                                                                            
          'branchcode' => 'JbmnNE',                                                                       
          'notedate' => '2025-07-16 10:22:21',                                                                                                                                                                       
          'issue_id' => 153,                                                                              
          'date_due' => '2025-07-16 10:22:21',                                                            
          'noteseen' => 1,                                                                                                                                                                                           
          'issuedate' => '2025-07-16 10:22:21'                                                                                                                                                                       
        };                                                                                                
 at t/db_dependent/Overdues.t line 552.
Comment 1 Jonathan Druart 2025-07-16 10:35:02 UTC
Created attachment 184142 [details] [review]
Bug 40409: Make Overdues.t fail

The test is wrong, the item is not correctly checked in, it should fail.
Comment 2 Jonathan Druart 2025-07-16 10:35:04 UTC
Created attachment 184143 [details] [review]
Bug 40409: Remove warnings from t/db_dependent/Overdues.t

The tests was wrong, we should make sure the item has been checked in.

We were missing the mock userenv:
Can't use an undefined value as a HASH reference at /kohadevbox/koha/C4/Circulation.pm line 2744. at /kohadevbox/koha/C4/Circulation.pm line 2787
Comment 3 David Nind 2025-07-18 08:26:41 UTC
Created attachment 184300 [details] [review]
Bug 40409: Make Overdues.t fail

The test is wrong, the item is not correctly checked in, it should fail.

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 David Nind 2025-07-18 08:26:45 UTC
Created attachment 184301 [details] [review]
Bug 40409: Remove warnings from t/db_dependent/Overdues.t

The tests was wrong, we should make sure the item has been checked in.

We were missing the mock userenv:
Can't use an undefined value as a HASH reference at /kohadevbox/koha/C4/Circulation.pm line 2744. at /kohadevbox/koha/C4/Circulation.pm line 2787

Signed-off-by: David Nind <david@davidnind.com>
Comment 5 Martin Renvoize (ashimema) 2025-07-18 12:16:14 UTC
Created attachment 184366 [details] [review]
Bug 40409: Make Overdues.t fail

The test is wrong, the item is not correctly checked in, it should fail.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Comment 6 Martin Renvoize (ashimema) 2025-07-18 12:16:16 UTC
Created attachment 184367 [details] [review]
Bug 40409: Remove warnings from t/db_dependent/Overdues.t

The tests was wrong, we should make sure the item has been checked in.

We were missing the mock userenv:
Can't use an undefined value as a HASH reference at /kohadevbox/koha/C4/Circulation.pm line 2744. at /kohadevbox/koha/C4/Circulation.pm line 2787

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Comment 7 Lucas Gass (lukeg) 2025-07-18 17:12:50 UTC
Nice work everyone!

Pushed to main for 25.11
Comment 8 Paul Derscheid 2025-07-24 08:21:36 UTC
Nice work everyone!

Pushed to 25.05.x
Comment 9 Fridolin Somers 2025-08-01 13:15:30 UTC
Pushed to 24.11.x for 24.11.08