Bugzilla – Attachment 184354 Details for
Bug 40401
Implement Koha::Patron->is_anonymous (was t/db_dependent/Auth.t generates warnings)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40401: (follow-up) Fix grammar and rollback in tests
Bug-40401-follow-up-Fix-grammar-and-rollback-in-te.patch (text/plain), 1.39 KB, created by
Martin Renvoize (ashimema)
on 2025-07-18 12:01:46 UTC
(
hide
)
Description:
Bug 40401: (follow-up) Fix grammar and rollback in tests
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2025-07-18 12:01:46 UTC
Size:
1.39 KB
patch
obsolete
>From db115e6da4882c7ba09e3fd6f0669d5ee96c0d3f Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@openfifth.co.uk> >Date: Fri, 18 Jul 2025 13:00:13 +0100 >Subject: [PATCH] Bug 40401: (follow-up) Fix grammar and rollback in tests > >- Fixed grammar: "Returns true if the patron is the anonymous patron" >- Fixed test cleanup: use txn_rollback instead of txn_begin >- Fixed test subroutine closure syntax > >Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> >--- > Koha/Patron.pm | 2 +- > t/db_dependent/Koha/Patron.t | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > >diff --git a/Koha/Patron.pm b/Koha/Patron.pm >index e5713dfe710..f711e8dc123 100644 >--- a/Koha/Patron.pm >+++ b/Koha/Patron.pm >@@ -3405,7 +3405,7 @@ sub is_patron_inside_charge_limits { > > my $is_anonymous_patron= $patron->is_anonymous(); > >-Returns true if the patron the anonymous patron (AnonymousPatron) >+Returns true if the patron is the anonymous patron (AnonymousPatron) > > =cut > >diff --git a/t/db_dependent/Koha/Patron.t b/t/db_dependent/Koha/Patron.t >index 87e0f3c172a..7cba994728a 100755 >--- a/t/db_dependent/Koha/Patron.t >+++ b/t/db_dependent/Koha/Patron.t >@@ -3115,6 +3115,6 @@ subtest 'is_anonymous' => sub { > > is( $patron->is_anonymous, 0, q{is_anonymous returns 0 if pref is not equal to patron's id} ); > >- $schema->storage->txn_begin; >+ $schema->storage->txn_rollback; > >- } >+}; >-- >2.50.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40401
:
184123
|
184294
|
184353
| 184354