t/db_dependent/Auth.t .. 1/23 Use of uninitialized value $anonymous_patron in string eq at /kohadevbox/koha/C4/Auth.pm line 1497. Use of uninitialized value $anonymous_patron in string eq at /kohadevbox/koha/C4/Auth.pm line 1497. Use of uninitialized value $anonymous_patron in string eq at /kohadevbox/koha/C4/Auth.pm line 1497.
Created attachment 184123 [details] [review] Bug 40401: Implement Koha::Patron->is_anonymous The first motivation of this patch is to remove the following warnings from t/db_dependent/Auth.t: Use of uninitialized value $anonymous_patron in string eq at /kohadevbox/koha/C4/Auth.pm line 1497 Actually a correct fix seems to add a new `is_anonymous` method to Koha::Patron in order to remove the warnings from everywhere else. Test plan: Confirm that you cannot log in using the anonymous patron and that the 2 tests are passing prove t/db_dependent/Auth.t t/db_dependent/Koha/Patron.t
Created attachment 184294 [details] [review] Bug 40401: Implement Koha::Patron->is_anonymous The first motivation of this patch is to remove the following warnings from t/db_dependent/Auth.t: Use of uninitialized value $anonymous_patron in string eq at /kohadevbox/koha/C4/Auth.pm line 1497 Actually a correct fix seems to add a new `is_anonymous` method to Koha::Patron in order to remove the warnings from everywhere else. Test plan: Confirm that you cannot log in using the anonymous patron and that the 2 tests are passing prove t/db_dependent/Auth.t t/db_dependent/Koha/Patron.t Signed-off-by: David Nind <david@davidnind.com>
Created attachment 184353 [details] [review] Bug 40401: Implement Koha::Patron->is_anonymous The first motivation of this patch is to remove the following warnings from t/db_dependent/Auth.t: Use of uninitialized value $anonymous_patron in string eq at /kohadevbox/koha/C4/Auth.pm line 1497 Actually a correct fix seems to add a new `is_anonymous` method to Koha::Patron in order to remove the warnings from everywhere else. Test plan: Confirm that you cannot log in using the anonymous patron and that the 2 tests are passing prove t/db_dependent/Auth.t t/db_dependent/Koha/Patron.t Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Created attachment 184354 [details] [review] Bug 40401: (follow-up) Fix grammar and rollback in tests - Fixed grammar: "Returns true if the patron is the anonymous patron" - Fixed test cleanup: use txn_rollback instead of txn_begin - Fixed test subroutine closure syntax Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Nice work everyone! Pushed to main for 25.11
Nice work everyone! Pushed to 25.05.x
Enhancement not pushed to 24.11.x
Test suite changes, no changes to the manual required.