Bugzilla – Attachment 184651 Details for
Bug 39809
.required class was made too non-specific in Bootstrap upgrade
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39809: .required class was made too non-specific in Bootstrap upgrade
Bug-39809-required-class-was-made-too-non-specific.patch (text/plain), 1.89 KB, created by
Lucas Gass (lukeg)
on 2025-07-25 16:41:01 UTC
(
hide
)
Description:
Bug 39809: .required class was made too non-specific in Bootstrap upgrade
Filename:
MIME Type:
Creator:
Lucas Gass (lukeg)
Created:
2025-07-25 16:41:01 UTC
Size:
1.89 KB
patch
obsolete
>From da4874a2e155a1fc9d87c15a3b7c88610cf1a4a2 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Thu, 1 May 2025 21:05:55 +0000 >Subject: [PATCH] Bug 39809: .required class was made too non-specific in > Bootstrap upgrade > >This patch corrects some CSS which was broken during the upgrade to >Bootstrap 5. The .required class should not add any style differences to >form fields. > >To test, apply the patch and rebuild the staff interface CSS. > >- Go to Administration -> Patron categories. >- Edit an existing category. >- Confirm that the contents of input fields are not styled red and > italic. > >Signed-off-by: David Nind <david@davidnind.com> >Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> >Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> >--- > .../intranet-tmpl/prog/css/src/staff-global.scss | 14 +++++++++----- > 1 file changed, 9 insertions(+), 5 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss >index da16481bddb..608bd7263dd 100644 >--- a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss >+++ b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss >@@ -581,6 +581,12 @@ div { > } > } > >+ &.required { >+ color: $warning-text-color; >+ font-style: italic; >+ margin-left: .5em; >+ } >+ > // Tools > automatic_item_modification_by_age > &.rules { > display: block; >@@ -962,6 +968,7 @@ label, > > &.required { > color: $warning-text-color; >+ margin-left: .5em; > } > } > >@@ -3491,11 +3498,6 @@ a.browse-button { > } > } > >-.required { >- color: $warning-text-color; >- font-style: italic; >-} >- > span { > &.browse-button { > color: #999; >@@ -3517,6 +3519,8 @@ span { > } > > &.required { >+ color: $warning-text-color; >+ font-style: italic; > margin-left: .5em; > } > >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39809
:
181832
|
181833
|
181840
|
181857
|
181868
|
181966
|
182044
| 184651 |
184652