In main, when I go to the patron category form, the required fields' inputs are in red and italic. To recreate: A.1. Go to Administration > Patron categories A.2. Click New category --> Notice the labels for Category code, Description and Category type are in italic (they used to be just red and bold, but not italic) A.3. Type in a code and a description --> Notice that the input is now in red and italic (it used to be black and regular/not italic) B.1. Go to Administration > Patron categories B.2. Click on an existing category --> Notice the description inside the input field is in red and italic (it used to be black and regular/not italic)
Created attachment 181832 [details] Screen capture of the top of the description input of an existing category
Created attachment 181833 [details] Screen capture of the code and description input of a new category
I mistakenly made the ".required" class too non-specific in the Bootstrap upgrade. <input> tags should not pick up the styles applied to <label>, <span>, and <div>.
Created attachment 181840 [details] [review] Bug 39809: .required class was made too non-specific in Bootstrap upgrade This patch corrects some CSS which was broken during the upgrade to Bootstrap 5. The .required class should not add any style differences to form fields. To test, apply the patch and rebuild the staff interface CSS. - Go to Administration -> Patron categories. - Edit an existing category. - Confirm that the contents of input fields are not styled red and italic.
Created attachment 181857 [details] [review] Bug 39809: .required class was made too non-specific in Bootstrap upgrade This patch corrects some CSS which was broken during the upgrade to Bootstrap 5. The .required class should not add any style differences to form fields. To test, apply the patch and rebuild the staff interface CSS. - Go to Administration -> Patron categories. - Edit an existing category. - Confirm that the contents of input fields are not styled red and italic. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 181868 [details] [review] Bug 39809: .required class was made too non-specific in Bootstrap upgrade This patch corrects some CSS which was broken during the upgrade to Bootstrap 5. The .required class should not add any style differences to form fields. To test, apply the patch and rebuild the staff interface CSS. - Go to Administration -> Patron categories. - Edit an existing category. - Confirm that the contents of input fields are not styled red and italic. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Thank you Owen, and David for testing. I added my sign-off too, even if it doesn't add much, but just as a thanks! :)
Created attachment 181966 [details] [review] Bug 39809: (follow-up) Remove left margin from label.required The left margin is only necessary for span.required
Created attachment 182044 [details] [review] Bug 39809: (follow-up) Remove left margin from label.required The left margin is only necessary for span.required Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>