Bugzilla – Attachment 185134 Details for
Bug 40590
OPACAuthorIdentifiersAndInformation shows empty list elements for unknown 024$2
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40590: Prevent OPACAuthorIdentifiersAndInformation from showing empty list elements for unknown 024$2
Bug-40590-Prevent-OPACAuthorIdentifiersAndInformat.patch (text/plain), 4.15 KB, created by
Owen Leonard
on 2025-08-05 16:22:32 UTC
(
hide
)
Description:
Bug 40590: Prevent OPACAuthorIdentifiersAndInformation from showing empty list elements for unknown 024$2
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2025-08-05 16:22:32 UTC
Size:
4.15 KB
patch
obsolete
>From e21efc5f29ad9cc088ccd520e92f4372d0d4caae Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Tue, 5 Aug 2025 16:00:24 +0000 >Subject: [PATCH] Bug 40590: Prevent OPACAuthorIdentifiersAndInformation from > showing empty list elements for unknown 024$2 > >This patch modifies the template which is used to display additional >author information if OPACAuthorIdentifiersAndInformation is displayed. >The change prevents an empty list item from appearing. > >To test, apply the patch and go to system preferences in the staff >interface. > >- Search for OPACAuthorIdentifiersAndInformation and make sure that > "Identifiers (024$2$a)" is checked. >- Have a record with at least 2 persons (100, 700) linked to an > authority record > - One of those authority records should not have an 024 tag > - The other authority record should have two 024 tags: > - 024 $a someidyoumakeup $2orcid > - 024 $a someidyoumakeup $2somethingelse >- Check the detail page in OPAC -> "Author information" tab >- Check the authority detail page in OPAC, under "Author information" > in the right-hand column. > >Before the patch, '$2somethingelse' is not "supported" and will create >the empty list element. After the patch there should be no empty list >item. > >Sponsored-by: Athens County Public Libraries >--- > .../en/includes/authority-information.inc | 34 +++++++++++++------ > 1 file changed, 23 insertions(+), 11 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/authority-information.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/authority-information.inc >index 4354e3b71a8..dcff3e16749 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/authority-information.inc >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/authority-information.inc >@@ -1,31 +1,43 @@ > [% FOREACH info IN information %] > [% SWITCH info_type %] > [% CASE 'identifiers' %] >- <li class="identifier_[% info.source.lower | html %]"> >- [% SWITCH info.source.lower %] >- [% CASE 'orcid' %] >+ [% SWITCH info.source.lower %] >+ [% CASE 'orcid' %] >+ <li class="identifier_[% info.source.lower | html %]"> > <span>ORCID: </span> > <a href="https://orcid.org/[% info.number | url %]">[% info.number | html %]</a> >- [% CASE 'scopus' %] >+ </li> >+ [% CASE 'scopus' %] >+ <li class="identifier_[% info.source.lower | html %]"> > <span>ScopusID: </span> > <a href="https://www.scopus.com/authid/detail.uri?authorId=[% info.number | url %]">[% info.number | html %]</a> >- [% CASE 'loop' %] >+ </li> >+ [% CASE 'loop' %] >+ <li class="identifier_[% info.source.lower | html %]"> > <span>Loop ID: </span> > <a href="https://loop.frontiersin.org/people/[% info.number | url %]">[% info.number | html %]</a> >- [% CASE 'rid' %] >+ </li> >+ [% CASE 'rid' %] >+ <li class="identifier_[% info.source.lower | html %]"> > <span>Publons ID: </span> > <a href="https://publons.com/researcher/[% info.number | url %]">[% info.number | html %]</a> >- [% CASE 'viaf' %] >+ </li> >+ [% CASE 'viaf' %] >+ <li class="identifier_[% info.source.lower | html %]"> > <span>VIAF ID: </span> > <a href="https://viaf.org/viaf/[% info.number | url %]">[% info.number | html %]</a> >- [% CASE 'isni' %] >+ </li> >+ [% CASE 'isni' %] >+ <li class="identifier_[% info.source.lower | html %]"> > <span>ISNI ID: </span> > <a href="https://isni.org/isni/[% info.number | url %]">[% info.number | html %]</a> >- [% CASE 'wikidata' %] >+ </li> >+ [% CASE 'wikidata' %] >+ <li class="identifier_[% info.source.lower | html %]"> > <span>WIKIDATA ID: </span> > <a href="http://www.wikidata.org/entity/[% info.number | url %]">[% info.number | html %]</a> >- [% END %] >- </li> >+ </li> >+ [% END %] > [% CASE 'activity' %] > [% IF info.field_of_activity %] > <li> >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40590
:
185134
|
185286