Bug 40590 - OPACAuthorIdentifiersAndInformation shows empty list elements for unknown 024$2
Summary: OPACAuthorIdentifiersAndInformation shows empty list elements for unknown 024$2
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-08-04 16:43 UTC by Katrin Fischer
Modified: 2025-08-08 16:56 UTC (History)
0 users

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 40590: Prevent OPACAuthorIdentifiersAndInformation from showing empty list elements for unknown 024$2 (4.15 KB, patch)
2025-08-05 16:22 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 40590: Prevent OPACAuthorIdentifiersAndInformation from showing empty list elements for unknown 024$2 (4.20 KB, patch)
2025-08-08 16:56 UTC, Roman Dolny
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2025-08-04 16:43:04 UTC
I believe this might be a regression from the first implementation.

When there are 024$2 in the authority record that we cannot resolve into a link yet, it shows an empty list element in the OPAC (with the list "button"). This is quite irritating especially if there are multiple.

In our case the authority records are not created locally, but imported from the national authority database, so 024$2 cannot be fully controlled. 

I hope the display should be relative easy to fix in the templates.
Comment 1 Katrin Fischer 2025-08-05 15:46:12 UTC
To test:
- Have a record with at least 2 persons (100, 700) linked to an authority record
- Have one authority record without any 024
- Have 2 024 in the other authority: 

024 $a someidyoumakeup $2orcid
024 $a someidyoumakeup $2somethingelse 

- Check the detail page in OPAC > author links tab
- Check the authority detail page in OPAC, right top side

The $2somethingelse is not "supported" and should create the empty list element.
Comment 2 Owen Leonard 2025-08-05 16:22:32 UTC
Created attachment 185134 [details] [review]
Bug 40590: Prevent OPACAuthorIdentifiersAndInformation from showing empty list elements for unknown 024$2

This patch modifies the template which is used to display additional
author information if OPACAuthorIdentifiersAndInformation is displayed.
The change prevents an empty list item from appearing.

To test, apply the patch and go to system preferences in the staff
interface.

- Search for OPACAuthorIdentifiersAndInformation and make sure that
  "Identifiers (024$2$a)" is checked.
- Have a record with at least 2 persons (100, 700) linked to an
  authority record
  - One of those authority records should not have an 024 tag
  - The other authority record should have two 024 tags:
    - 024 $a someidyoumakeup $2orcid
    - 024 $a someidyoumakeup $2somethingelse
- Check the detail page in OPAC -> "Author information" tab
- Check the authority detail page in OPAC, under "Author information"
  in the right-hand column.

Before the patch, '$2somethingelse' is not "supported" and will create
the empty list element. After the patch there should be no empty list
item.

Sponsored-by: Athens County Public Libraries
Comment 3 Katrin Fischer 2025-08-06 11:10:07 UTC
Thanks a lot, Owen!
Comment 4 Roman Dolny 2025-08-08 16:56:22 UTC
Created attachment 185286 [details] [review]
Bug 40590: Prevent OPACAuthorIdentifiersAndInformation from showing empty list elements for unknown 024$2

This patch modifies the template which is used to display additional
author information if OPACAuthorIdentifiersAndInformation is displayed.
The change prevents an empty list item from appearing.

To test, apply the patch and go to system preferences in the staff
interface.

- Search for OPACAuthorIdentifiersAndInformation and make sure that
  "Identifiers (024$2$a)" is checked.
- Have a record with at least 2 persons (100, 700) linked to an
  authority record
  - One of those authority records should not have an 024 tag
  - The other authority record should have two 024 tags:
    - 024 $a someidyoumakeup $2orcid
    - 024 $a someidyoumakeup $2somethingelse
- Check the detail page in OPAC -> "Author information" tab
- Check the authority detail page in OPAC, under "Author information"
  in the right-hand column.

Before the patch, '$2somethingelse' is not "supported" and will create
the empty list element. After the patch there should be no empty list
item.

Sponsored-by: Athens County Public Libraries
Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>