Bugzilla – Attachment 185231 Details for
Bug 40613
Allow ungrouping holds
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40613: Add 'ungroup holds' button
Bug-40613-Add-ungroup-holds-button.patch (text/plain), 3.59 KB, created by
Pedro Amorim
on 2025-08-07 16:07:03 UTC
(
hide
)
Description:
Bug 40613: Add 'ungroup holds' button
Filename:
MIME Type:
Creator:
Pedro Amorim
Created:
2025-08-07 16:07:03 UTC
Size:
3.59 KB
patch
obsolete
>From 1990472b78a18550e6802dc466de249064b93a52 Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@openfifth.co.uk> >Date: Thu, 7 Aug 2025 15:36:10 +0000 >Subject: [PATCH] Bug 40613: Add 'ungroup holds' button > >Test plan, k-t-d, patches applied: >1) Search for 'test': >http://localhost:8081/cgi-bin/koha/catalogue/search.pl?q=test >2) Click the 'Select all' link on the left of the search toolbar >3) Click the 'Place hold' button on the same toolbar >4) On the patron input, add 'koha' >5) You need to pick the 'Pickup location' specifically for each hold. Click 'Place holds' >6) Now visit the patron details page: >http://localhost:8081/cgi-bin/koha/members/moremember.pl?borrowernumber=51 >7) Click the 'Holds' tab. >8) Click the top most checkbox to select all holds. Click the 'group selected' button. Notice the holds are grouped and the 'group hold' column shows the hold group number accordingly. >9) Test that selecting the hold group number opens the hold group modal and a new 'ungroup holds' button exist. >10) Click that button, ensure it deletes the holde group. Test with more holds, more groups, etc. >--- > .../prog/en/modules/reserve/hold-group.tt | 2 +- > koha-tmpl/intranet-tmpl/prog/js/hold-group.js | 27 +++++++++++++++++++ > 2 files changed, 28 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/hold-group.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/hold-group.tt >index d0739a9b7ae..ecb4f7f5bb9 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/hold-group.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/hold-group.tt >@@ -4,7 +4,7 @@ > </head> > <body id="hold-group"> > <h1>Holds group ([% hold_group.id | html %])</h1> >-<div id="main"> >+<div id="main" data-hold-group-id="[% hold_group.id | uri %]"> > [% holds = hold_group.holds %] > [% IF holds.count %] > <table> >diff --git a/koha-tmpl/intranet-tmpl/prog/js/hold-group.js b/koha-tmpl/intranet-tmpl/prog/js/hold-group.js >index 60320ae22ab..9ce7d1200c5 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/hold-group.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/hold-group.js >@@ -5,6 +5,7 @@ $(document).ready(function () { > $("#hold-group-modal").modal("show"); > if (holds_table_patron_page()) { > append_select_group_holds_button(); >+ append_ungroup_holds_button(); > } > return false; > }); >@@ -26,6 +27,20 @@ $(document).ready(function () { > }); > }); > >+ $("body").on("click", "button#ungroup-hold-group", function () { >+ let hold_group_id = $("#hold-group-modal #main").data("hold-group-id"); >+ $.ajax({ >+ method: "DELETE", >+ url: >+ "/api/v1/patrons/" + >+ borrowernumber + >+ "/hold_groups/" + >+ hold_group_id, >+ }).done(function () { >+ $("#holds-table").DataTable().ajax.reload(); >+ }); >+ }); >+ > function append_select_group_holds_button() { > var button = document.createElement("button"); > button.type = "button"; >@@ -37,4 +52,16 @@ $(document).ready(function () { > $("#hold-group-modal .modal-footer").prepend(button); > } > } >+ >+ function append_ungroup_holds_button() { >+ var button = document.createElement("button"); >+ button.type = "button"; >+ button.className = "btn btn-danger"; >+ button.id = "ungroup-hold-group"; >+ button.dataset.bsDismiss = "modal"; >+ button.innerHTML = _("Ungroup holds"); >+ if (!$("#ungroup-hold-group").length) { >+ $("#hold-group-modal .modal-footer").prepend(button); >+ } >+ } > }); >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40613
:
185230
|
185231
|
185298
|
185299