Created attachment 185230 [details] [review] Bug 40613: Add DELETE hold groups REST API endpoint prove t/db_dependent/api/v1/patrons_hold_groups.t
Created attachment 185231 [details] [review] Bug 40613: Add 'ungroup holds' button Test plan, k-t-d, patches applied: 1) Search for 'test': http://localhost:8081/cgi-bin/koha/catalogue/search.pl?q=test 2) Click the 'Select all' link on the left of the search toolbar 3) Click the 'Place hold' button on the same toolbar 4) On the patron input, add 'koha' 5) You need to pick the 'Pickup location' specifically for each hold. Click 'Place holds' 6) Now visit the patron details page: http://localhost:8081/cgi-bin/koha/members/moremember.pl?borrowernumber=51 7) Click the 'Holds' tab. 8) Click the top most checkbox to select all holds. Click the 'group selected' button. Notice the holds are grouped and the 'group hold' column shows the hold group number accordingly. 9) Test that selecting the hold group number opens the hold group modal and a new 'ungroup holds' button exist. 10) Click that button, ensure it deletes the holde group. Test with more holds, more groups, etc.
Created attachment 185298 [details] [review] Bug 40613: Add DELETE hold groups REST API endpoint prove t/db_dependent/api/v1/patrons_hold_groups.t Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi>
Created attachment 185299 [details] [review] Bug 40613: Add 'ungroup holds' button Test plan, k-t-d, patches applied: 1) Search for 'test': http://localhost:8081/cgi-bin/koha/catalogue/search.pl?q=test 2) Click the 'Select all' link on the left of the search toolbar 3) Click the 'Place hold' button on the same toolbar 4) On the patron input, add 'koha' 5) You need to pick the 'Pickup location' specifically for each hold. Click 'Place holds' 6) Now visit the patron details page: http://localhost:8081/cgi-bin/koha/members/moremember.pl?borrowernumber=51 7) Click the 'Holds' tab. 8) Click the top most checkbox to select all holds. Click the 'group selected' button. Notice the holds are grouped and the 'group hold' column shows the hold group number accordingly. 9) Test that selecting the hold group number opens the hold group modal and a new 'ungroup holds' button exist. 10) Click that button, ensure it deletes the holde group. Test with more holds, more groups, etc. Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi>
Tagging Andrew Fuerste-Henry for QA and adding rel_25_11 candidate here as all other feature 'hold groups' bugs have been pushed, it would make sense that this tiny last one also makes the cut.
Created attachment 189008 [details] [review] Bug 40613: Add DELETE hold groups REST API endpoint prove t/db_dependent/api/v1/patrons_hold_groups.t Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi>
Created attachment 189009 [details] [review] Bug 40613: Add 'ungroup holds' button Test plan, k-t-d, patches applied: 1) Search for 'test': http://localhost:8081/cgi-bin/koha/catalogue/search.pl?q=test 2) Click the 'Select all' link on the left of the search toolbar 3) Click the 'Place hold' button on the same toolbar 4) On the patron input, add 'koha' 5) You need to pick the 'Pickup location' specifically for each hold. Click 'Place holds' 6) Now visit the patron details page: http://localhost:8081/cgi-bin/koha/members/moremember.pl?borrowernumber=51 7) Click the 'Holds' tab. 8) Click the top most checkbox to select all holds. Click the 'group selected' button. Notice the holds are grouped and the 'group hold' column shows the hold group number accordingly. 9) Test that selecting the hold group number opens the hold group modal and a new 'ungroup holds' button exist. 10) Click that button, ensure it deletes the holde group. Test with more holds, more groups, etc. Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi>
Rebased + squashed forbidden pattern fix
Created attachment 189014 [details] [review] Bug 40613: Add DELETE hold groups REST API endpoint prove t/db_dependent/api/v1/patrons_hold_groups.t Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com>
Created attachment 189015 [details] [review] Bug 40613: Add 'ungroup holds' button Test plan, k-t-d, patches applied: 1) Search for 'test': http://localhost:8081/cgi-bin/koha/catalogue/search.pl?q=test 2) Click the 'Select all' link on the left of the search toolbar 3) Click the 'Place hold' button on the same toolbar 4) On the patron input, add 'koha' 5) You need to pick the 'Pickup location' specifically for each hold. Click 'Place holds' 6) Now visit the patron details page: http://localhost:8081/cgi-bin/koha/members/moremember.pl?borrowernumber=51 7) Click the 'Holds' tab. 8) Click the top most checkbox to select all holds. Click the 'group selected' button. Notice the holds are grouped and the 'group hold' column shows the hold group number accordingly. 9) Test that selecting the hold group number opens the hold group modal and a new 'ungroup holds' button exist. 10) Click that button, ensure it deletes the holde group. Test with more holds, more groups, etc. Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com>
With this patchset applied: prove xt/api.t xt/api.t .. 1/8 # Failed test 'Validation exit code is 0' # at xt/api.t line 103. # got: '256' # expected: '0' # Validation failed. /paths/patrons/{patron_id}/hold_groups/{hold_group_id}/delete is missing path parameter(s) for {hold_group_id}
Created attachment 189076 [details] [review] Bug 40613: (QA follow-up): Add hold_group_id param This now passes: prove xt/api.t
Nice work everyone! Pushed to main for 25.11