Bugzilla – Attachment 185336 Details for
Bug 35211
Make it possible to split holdings tab using library groups in intranet
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35211: Fix tab building
Bug-35211-Fix-tab-building.patch (text/plain), 2.44 KB, created by
Eric Garcia
on 2025-08-12 15:50:22 UTC
(
hide
)
Description:
Bug 35211: Fix tab building
Filename:
MIME Type:
Creator:
Eric Garcia
Created:
2025-08-12 15:50:22 UTC
Size:
2.44 KB
patch
obsolete
>From 708df57a3b4dc0c1764d46b3ed69d9169c4562dd Mon Sep 17 00:00:00 2001 >From: Eric Garcia <cubingguy714@gmail.com> >Date: Tue, 12 Aug 2025 15:48:14 +0000 >Subject: [PATCH] Bug 35211: Fix tab building > >Fixed naming when building tabs > >Test Plan: >1. Apply patch, restart_all, updatedatabase >2. Koha Administration -> System preferences -> SeparateHoldingsByGroup >3. Change to "Separate holdings by library group in subsequent tabs..." and Save >4. Koha Administration -> Library Groups >5. Create multiple library groups and check the 'Use for staff search groups' box. >6. Add your logged in library to each group and other libraries to each group. >7. Do catalog searches where the location of the item is a library in a library group >8. Notice tabs in the Holdings table for each library group if it contains a library that has the item >--- > koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >index 2a406aec58..a0d11945ef 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >@@ -335,9 +335,9 @@ > > [% IF Koha.Preference('SeparateHoldingsByGroup') && lib_groups %] > [% FOREACH group IN lib_groups %] >- [% IF ( holdings_count.${group.id} > 0 ) %] >+ [% IF ( holdings_count_hash.${group.id} > 0 ) %] > [% WRAPPER tab_item tabname="group_holdings_" _ group.id %] >- <span>[% group.title | html %] holdings ([% holdings_count.${group.id} | html %])</span> >+ <span>[% group.title | html %] holdings ([% holdings_count_hash.${group.id} | html %])</span> > [% END %] > [% END %] > [% END %] >@@ -492,7 +492,7 @@ > [% END %] > [% IF Koha.Preference('SeparateHoldingsByGroup') && lib_groups %] > [% FOREACH group IN lib_groups %] >- [% IF ( holdings_count.${group.id} > 0 ) %] >+ [% IF ( holdings_count_hash.${group.id} > 0 ) %] > [% SET group_tab = "group_holdings_" _ group.id %] > [% WRAPPER tab_panel tabname=group_tab %] > [% PROCESS items_table tab=group_tab %] >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35211
:
183075
|
183099
|
183143
|
183144
|
183420
|
183615
|
183642
|
183643
|
183901
|
183945
|
183949
|
183950
|
183966
|
183967
|
183968
|
184016
| 185336