Bug 35211 - Make it possible to split holdings tab using library groups
Summary: Make it possible to split holdings tab using library groups
Status: Failed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Eric Garcia
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-11-01 09:38 UTC by Kati Sillgren
Modified: 2025-06-30 15:15 UTC (History)
6 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 35211: Add group_holdings tab to Holdings table (5.44 KB, patch)
2025-06-06 16:50 UTC, Eric Garcia
Details | Diff | Splinter Review
Bug 35211: Add group_holdings tab to Holdings table (9.59 KB, patch)
2025-06-09 18:40 UTC, Eric Garcia
Details | Diff | Splinter Review
Bug 35211: Add group_holdings tab to Holdings table (9.74 KB, patch)
2025-06-10 16:36 UTC, Eric Garcia
Details | Diff | Splinter Review
Bug 35211: Add group_holdings tab to Holdings table (10.53 KB, patch)
2025-06-10 17:16 UTC, Eric Garcia
Details | Diff | Splinter Review
Bug 35211: Add group_holdings tab to Holdings table (10.52 KB, patch)
2025-06-23 15:25 UTC, Eric Garcia
Details | Diff | Splinter Review
Bug 35211: Separate group holdings (4.84 KB, patch)
2025-06-27 15:26 UTC, Eric Garcia
Details | Diff | Splinter Review
Bug 35211: Add group_holdings tab to Holdings table (12.39 KB, patch)
2025-06-30 15:15 UTC, Eric Garcia
Details | Diff | Splinter Review
Bug 35211: Separate group holdings (4.84 KB, patch)
2025-06-30 15:15 UTC, Eric Garcia
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kati Sillgren 2023-11-01 09:38:46 UTC
Make it possible to add new tab to record’s detail page/holdings table by using library groups.

Library groups are made here: admin/library_groups.pl
Comment 1 Kati Sillgren 2023-11-07 06:21:08 UTC
Tab is shown automatically according to the library where Koha-user is logged in, and library is included to the library group (search group).
Comment 2 Jessie Zairo 2024-09-12 15:00:18 UTC
+1 this would be helpful for large systems, consortiums, and library networks to breakdown multi-branch systems and see whats available.
Comment 3 Eric Garcia 2025-06-06 16:50:32 UTC
Created attachment 183075 [details] [review]
Bug 35211: Add group_holdings tab to Holdings table

Current status: ASSIGNED
Comment 4 Eric Garcia 2025-06-09 18:40:02 UTC
Created attachment 183099 [details] [review]
Bug 35211: Add group_holdings tab to Holdings table
Comment 5 Eric Garcia 2025-06-10 16:36:56 UTC
Created attachment 183143 [details] [review]
Bug 35211: Add group_holdings tab to Holdings table

Add new system preference 'SeparateHoldingsByGroup'
Adds new tab to Group Holdings to Holdings table.
Separates holdings by library group.
Comment 6 Eric Garcia 2025-06-10 17:16:21 UTC
Created attachment 183144 [details] [review]
Bug 35211: Add group_holdings tab to Holdings table

Add new system preference 'SeparateHoldingsByGroup'
Adds new tab to Group Holdings to Holdings table.
Separates holdings by library group.

Test Plan:
  1. Apply patch, restart_all
  2. Koha Administration -> System preferences ->  SeparateHoldingsByGroup
  3. Separate items display into two tabs and Separate holdings by library group.
  4. Save preference changes
  5. Koha Administration -> Library groups
  6. Create a library group and add check the 'Use for staff search groups' box.
  7. Add libraries to the new group including your logged in branch.
  8. Do a catalog search.
  9. Click on an item that libraries in your group own.
  10. Notice a new tab called Group Holdings that contains only the libraries in your group

  11. Return to Koha Administration -> System preferences SeparateHoldingsByGroup
  12. Don't separate holdings by library group
  13. Return to the item you search for and notice the tab has been removed.
Comment 7 Lucas Gass (lukeg) 2025-06-10 22:15:05 UTC
I found a few problems here: 

1. There is a problem with the atomicupdate:
	ERROR: {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near ''variable','value','options','explanation','type')
	            VALUES ('Separ...' at line 1 at /kohadevbox/koha/C4/Installer.pm line 825

2. The "Group holdings" do not seem to include the logged in branch's holdings 

3. If there are more than one groups everything gets grouped together under the single tab "Group holdings". In my opinion there should be a separate tab for every group that the logged in library is a part of.
Comment 8 Eric Garcia 2025-06-23 15:25:31 UTC
Created attachment 183420 [details] [review]
Bug 35211: Add group_holdings tab to Holdings table

Add new system preference 'SeparateHoldingsByGroup'
Adds new tab to Group Holdings to Holdings table.
Separates holdings by library group.

Test Plan:
  1. Apply patch, restart_all
  2. Koha Administration -> System preferences ->  SeparateHoldingsByGroup
  3. Separate items display into two tabs and Separate holdings by library group.
  4. Save preference changes
  5. Koha Administration -> Library groups
  6. Create a library group and add check the 'Use for staff search groups' box.
  7. Add libraries to the new group including your logged in branch.
  8. Do a catalog search.
  9. Click on an item that libraries in your group own.
  10. Notice a new tab called Group Holdings that contains only the libraries in your group

  11. Return to Koha Administration -> System preferences SeparateHoldingsByGroup
  12. Don't separate holdings by library group
  13. Return to the item you search for and notice the tab has been removed.
Comment 9 Eric Garcia 2025-06-27 15:26:02 UTC
Created attachment 183615 [details] [review]
Bug 35211: Separate group holdings
Comment 10 Eric Garcia 2025-06-30 15:15:13 UTC
Created attachment 183642 [details] [review]
Bug 35211: Add group_holdings tab to Holdings table

Add new system preference 'SeparateHoldingsByGroup'
Adds new tab to Group Holdings to Holdings table.
Separates holdings by library group.

Test Plan:
  1. Apply patch, restart_all
  2. Koha Administration -> System preferences ->  SeparateHoldingsByGroup
  3. Separate items display into two tabs and Separate holdings by library group.
  4. Save preference changes
  5. Koha Administration -> Library groups
  6. Create a library group and add check the 'Use for staff search groups' box.
  7. Add libraries to the new group including your logged in branch.
  8. Do a catalog search.
  9. Click on an item that libraries in your group own.
  10. Notice a new tab called Group Holdings that contains only the libraries in your group

  11. Return to Koha Administration -> System preferences SeparateHoldingsByGroup
  12. Don't separate holdings by library group
  13. Return to the item you search for and notice the tab has been removed.
Comment 11 Eric Garcia 2025-06-30 15:15:16 UTC
Created attachment 183643 [details] [review]
Bug 35211: Separate group holdings