Bugzilla – Attachment 185604 Details for
Bug 40679
Existing holds toolbar goes wonky if you select 'del' from priority dropdown
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40679: Fix display of cancellation reason dropdown
Bug-40679-Fix-display-of-cancellation-reason-dropd.patch (text/plain), 2.79 KB, created by
Lucas Gass (lukeg)
on 2025-08-20 17:38:14 UTC
(
hide
)
Description:
Bug 40679: Fix display of cancellation reason dropdown
Filename:
MIME Type:
Creator:
Lucas Gass (lukeg)
Created:
2025-08-20 17:38:14 UTC
Size:
2.79 KB
patch
obsolete
>From 41581ef81ff37554e35fa38c093ac1e46faa5c26 Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Wed, 20 Aug 2025 17:36:54 +0000 >Subject: [PATCH] Bug 40679: Fix display of cancellation reason dropdown > >To test: >1. Have some holds >2. Go to reserve/request.pl?biblionumber=x for your biblionumber >3. Change at least one hold priority to 'del' >4. Notice the toolbar above the table with Update Hold, Cancel selected, Cancellation reason now looks wonky. >5. APPLY PATCH >6. Try again, the display of the toolbar should be better. >--- > .../prog/en/modules/reserve/request.tt | 14 +++++++++----- > 1 file changed, 9 insertions(+), 5 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >index f0e3e2c18c1..d103cec07dd 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >@@ -105,6 +105,10 @@ > :disabled { > opacity: 0.5; > } >+ #cancellation-reason-div { >+ display: flex; >+ align-items: center; >+ } > </style> > [% END %] > </head> >@@ -1223,7 +1227,7 @@ > <div class="btn-group"> > <button class="btn cancel_selected_holds" data-bulk="true"></button> > </div> >- <fieldset id="cancellation-reason-fieldset" class="action" style="display:none"> >+ <div id="cancellation-reason-div" style="display:none"> > [% SET hold_cancellation = AuthorisedValues.GetAuthValueDropbox('HOLD_CANCELLATION') %] > [% IF hold_cancellation.count %] > <label for="cancellation-reason">Cancellation reason: </label> >@@ -1234,7 +1238,7 @@ > [% END %] > </select> > [% END %] >- </fieldset> >+ </div> > </div> > <div class="page-section"> > [% FOREACH biblioloo IN biblioloop %] >@@ -1471,12 +1475,12 @@ > $.fn.select2.defaults.set("dropdownAutoWidth", true ); > > $(document).ready(function() { >- $('#cancellation-reason-fieldset').hide(); >+ $('#cancellation-reason-div').hide(); > $('.rank-request').on('change', function() { > if ( $(".rank-request option:selected[value='del']").length ) { >- $('#cancellation-reason-fieldset').show(); >+ $('#cancellation-reason-div').show(); > } else { >- $('#cancellation-reason-fieldset').hide(); >+ $('#cancellation-reason-div').hide(); > } > }); > >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40679
:
185598
| 185604