Bug 40679 - Existing holds toolbar goes wonky if you select 'del' from priority dropdown
Summary: Existing holds toolbar goes wonky if you select 'del' from priority dropdown
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Lucas Gass (lukeg)
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-08-20 16:41 UTC by Lucas Gass (lukeg)
Modified: 2025-10-16 10:24 UTC (History)
5 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Fixes a problem in the UI that would make the toolbar look wrong when 'del' is selected in the priority dropdown on reserve/request.tt
Version(s) released in:
25.11.00,25.05.04,24.11.10
Circulation function:


Attachments
Example of wonky toolbar (12.03 KB, image/png)
2025-08-20 16:41 UTC, Lucas Gass (lukeg)
Details
Bug 40679: Fix display of cancellation reason dropdown (2.79 KB, patch)
2025-08-20 17:38 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 40679: Fix display of cancellation reason dropdown (2.84 KB, patch)
2025-08-25 14:37 UTC, Eric Garcia
Details | Diff | Splinter Review
Bug 40679: Fix display of cancellation reason dropdown (2.84 KB, patch)
2025-08-29 20:52 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 40679: Fix display of cancellation reason dropdown (3.09 KB, patch)
2025-09-22 20:39 UTC, Brendan Lawlor
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass (lukeg) 2025-08-20 16:41:54 UTC
Created attachment 185598 [details]
Example of wonky toolbar

To recreate:

1. Have some holds
2. Go to reserve/request.pl?biblionumber=x for your biblionumber 
3. Change at least one hold priority to 'del'
4. Notice the toolbar above the table with Update Hold, Cancel selected, Cancellation reason now looks wonky.
Comment 1 Lucas Gass (lukeg) 2025-08-20 17:24:15 UTC
Ah, its because the 'Cancellation reason:' appears if you select 'del' and causes the odd display.
Comment 2 Lucas Gass (lukeg) 2025-08-20 17:38:14 UTC
Created attachment 185604 [details] [review]
Bug 40679: Fix display of cancellation reason dropdown

To test:
1. Have some holds
2. Go to reserve/request.pl?biblionumber=x for your biblionumber
3. Change at least one hold priority to 'del'
4. Notice the toolbar above the table with Update Hold, Cancel selected, Cancellation reason now looks wonky.
5. APPLY PATCH
6. Try again, the display of the toolbar should be better.
Comment 3 Eric Garcia 2025-08-25 14:37:31 UTC
Created attachment 185744 [details] [review]
Bug 40679: Fix display of cancellation reason dropdown

To test:
1. Have some holds
2. Go to reserve/request.pl?biblionumber=x for your biblionumber
3. Change at least one hold priority to 'del'
4. Notice the toolbar above the table with Update Hold, Cancel selected, Cancellation reason now looks wonky.
5. APPLY PATCH
6. Try again, the display of the toolbar should be better.

Signed-off-by: Eric Garcia <cubingguy714@gmail.com>
Comment 4 Lucas Gass (lukeg) 2025-08-29 20:52:50 UTC
Created attachment 185971 [details] [review]
Bug 40679: Fix display of cancellation reason dropdown

To test:
1. Have some holds
2. Go to reserve/request.pl?biblionumber=x for your biblionumber
3. Change at least one hold priority to 'del'
4. Notice the toolbar above the table with Update Hold, Cancel selected, Cancellation reason now looks wonky.
5. APPLY PATCH
6. Try again, the display of the toolbar should be better.

Signed-off-by: Eric Garcia <cubingguy714@gmail.com>
Comment 5 Brendan Lawlor 2025-09-22 20:39:05 UTC
Created attachment 186754 [details] [review]
Bug 40679: Fix display of cancellation reason dropdown

To test:
1. Have some holds
2. Go to reserve/request.pl?biblionumber=x for your biblionumber
3. Change at least one hold priority to 'del'
4. Notice the toolbar above the table with Update Hold, Cancel selected, Cancellation reason now looks wonky.
5. APPLY PATCH
6. Try again, the display of the toolbar should be better.

Signed-off-by: Eric Garcia <cubingguy714@gmail.com>
Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org>
Comment 6 Brendan Lawlor 2025-09-22 20:42:35 UTC
This makes sense and works to fix the display issue. Passing QA.

I had to rebase this patch dues to a small conflict with recently pushed bug 31698
Comment 7 Lucas Gass (lukeg) 2025-09-23 22:25:07 UTC
Nice work everyone!

Pushed to main for 25.11
Comment 8 Paul Derscheid 2025-09-25 16:30:27 UTC
Nice work everyone!

Pushed to 25.05.x
Comment 9 Fridolin Somers 2025-10-16 10:24:46 UTC
Pushed to 24.11.x for 24.11.10