Bug 40679 - Existing holds toolbar goes wonky if you select 'del' from priority dropdown
Summary: Existing holds toolbar goes wonky if you select 'del' from priority dropdown
Status: Needs Signoff
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Lucas Gass (lukeg)
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-08-20 16:41 UTC by Lucas Gass (lukeg)
Modified: 2025-08-20 17:38 UTC (History)
2 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Example of wonky toolbar (12.03 KB, image/png)
2025-08-20 16:41 UTC, Lucas Gass (lukeg)
Details
Bug 40679: Fix display of cancellation reason dropdown (2.79 KB, patch)
2025-08-20 17:38 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass (lukeg) 2025-08-20 16:41:54 UTC
Created attachment 185598 [details]
Example of wonky toolbar

To recreate:

1. Have some holds
2. Go to reserve/request.pl?biblionumber=x for your biblionumber 
3. Change at least one hold priority to 'del'
4. Notice the toolbar above the table with Update Hold, Cancel selected, Cancellation reason now looks wonky.
Comment 1 Lucas Gass (lukeg) 2025-08-20 17:24:15 UTC
Ah, its because the 'Cancellation reason:' appears if you select 'del' and causes the odd display.
Comment 2 Lucas Gass (lukeg) 2025-08-20 17:38:14 UTC
Created attachment 185604 [details] [review]
Bug 40679: Fix display of cancellation reason dropdown

To test:
1. Have some holds
2. Go to reserve/request.pl?biblionumber=x for your biblionumber
3. Change at least one hold priority to 'del'
4. Notice the toolbar above the table with Update Hold, Cancel selected, Cancellation reason now looks wonky.
5. APPLY PATCH
6. Try again, the display of the toolbar should be better.