Created attachment 185598 [details] Example of wonky toolbar To recreate: 1. Have some holds 2. Go to reserve/request.pl?biblionumber=x for your biblionumber 3. Change at least one hold priority to 'del' 4. Notice the toolbar above the table with Update Hold, Cancel selected, Cancellation reason now looks wonky.
Ah, its because the 'Cancellation reason:' appears if you select 'del' and causes the odd display.
Created attachment 185604 [details] [review] Bug 40679: Fix display of cancellation reason dropdown To test: 1. Have some holds 2. Go to reserve/request.pl?biblionumber=x for your biblionumber 3. Change at least one hold priority to 'del' 4. Notice the toolbar above the table with Update Hold, Cancel selected, Cancellation reason now looks wonky. 5. APPLY PATCH 6. Try again, the display of the toolbar should be better.
Created attachment 185744 [details] [review] Bug 40679: Fix display of cancellation reason dropdown To test: 1. Have some holds 2. Go to reserve/request.pl?biblionumber=x for your biblionumber 3. Change at least one hold priority to 'del' 4. Notice the toolbar above the table with Update Hold, Cancel selected, Cancellation reason now looks wonky. 5. APPLY PATCH 6. Try again, the display of the toolbar should be better. Signed-off-by: Eric Garcia <cubingguy714@gmail.com>
Created attachment 185971 [details] [review] Bug 40679: Fix display of cancellation reason dropdown To test: 1. Have some holds 2. Go to reserve/request.pl?biblionumber=x for your biblionumber 3. Change at least one hold priority to 'del' 4. Notice the toolbar above the table with Update Hold, Cancel selected, Cancellation reason now looks wonky. 5. APPLY PATCH 6. Try again, the display of the toolbar should be better. Signed-off-by: Eric Garcia <cubingguy714@gmail.com>
Created attachment 186754 [details] [review] Bug 40679: Fix display of cancellation reason dropdown To test: 1. Have some holds 2. Go to reserve/request.pl?biblionumber=x for your biblionumber 3. Change at least one hold priority to 'del' 4. Notice the toolbar above the table with Update Hold, Cancel selected, Cancellation reason now looks wonky. 5. APPLY PATCH 6. Try again, the display of the toolbar should be better. Signed-off-by: Eric Garcia <cubingguy714@gmail.com> Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org>
This makes sense and works to fix the display issue. Passing QA. I had to rebase this patch dues to a small conflict with recently pushed bug 31698
Nice work everyone! Pushed to main for 25.11
Nice work everyone! Pushed to 25.05.x
Pushed to 24.11.x for 24.11.10