Bugzilla – Attachment 187487 Details for
Bug 30148
Pipe separated contents are hard to customize (staff interface)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 30148: (follow-up) Apply CSS-based separators to additional repeatable fields
f5f1a72.patch (text/plain), 6.80 KB, created by
Tomás Cohen Arazi (tcohen)
on 2025-10-06 18:19:07 UTC
(
hide
)
Description:
Bug 30148: (follow-up) Apply CSS-based separators to additional repeatable fields
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2025-10-06 18:19:07 UTC
Size:
6.80 KB
patch
obsolete
>From f5f1a72dcc48f3de2b1ceb6bb848c4a0c84719da Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Tom=C3=A1s=20Cohen=20Arazi?= <tomascohen@theke.io> >Date: Mon, 6 Oct 2025 15:11:16 -0300 >Subject: [PATCH] Bug 30148: (follow-up) Apply CSS-based separators to > additional repeatable fields > >Extends the CSS-based separator approach to additional repeatable fields >that were using hardcoded pipe separators: > >- Content type (336) >- Media type (337) >- Carrier type (338) >- Awards (586) >- Production credits (508) > >This provides consistent behavior and customization options across >all major repeatable fields in the staff interface, matching the >approach used for classification fields. >--- > .../en/xslt/MARC21slim2intranetDetail.xsl | 77 +++++++++++-------- > 1 file changed, 46 insertions(+), 31 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl b/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl >index 5f30f98d982..681ebedb3f9 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl >+++ b/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl >@@ -414,37 +414,46 @@ > <span class="results_summary" id="content_type"> > <xsl:if test="marc:datafield[@tag=336]"> > <span class="label">Content type: </span> >- <xsl:for-each select="marc:datafield[@tag=336]"> >- <xsl:call-template name="subfieldSelect"> >- <xsl:with-param name="codes">a</xsl:with-param> >- <xsl:with-param name="delimeter">, </xsl:with-param> >- </xsl:call-template> >- <xsl:if test="position() != last()"><span class="separator"><xsl:text> | </xsl:text></span></xsl:if> >- </xsl:for-each> >+ <ul class="resource_list"> >+ <xsl:for-each select="marc:datafield[@tag=336]"> >+ <li> >+ <xsl:call-template name="subfieldSelect"> >+ <xsl:with-param name="codes">a</xsl:with-param> >+ <xsl:with-param name="delimeter">, </xsl:with-param> >+ </xsl:call-template> >+ </li> >+ </xsl:for-each> >+ </ul> > </xsl:if> > <xsl:text> </xsl:text> > <!-- Media Type --> > <xsl:if test="marc:datafield[@tag=337]"> > <span class="label">Media type: </span> >- <xsl:for-each select="marc:datafield[@tag=337]"> >- <xsl:call-template name="subfieldSelect"> >- <xsl:with-param name="codes">a</xsl:with-param> >- <xsl:with-param name="delimeter">, </xsl:with-param> >- </xsl:call-template> >- <xsl:if test="position() != last()"><span class="separator"><xsl:text> | </xsl:text></span></xsl:if> >- </xsl:for-each> >+ <ul class="resource_list"> >+ <xsl:for-each select="marc:datafield[@tag=337]"> >+ <li> >+ <xsl:call-template name="subfieldSelect"> >+ <xsl:with-param name="codes">a</xsl:with-param> >+ <xsl:with-param name="delimeter">, </xsl:with-param> >+ </xsl:call-template> >+ </li> >+ </xsl:for-each> >+ </ul> > </xsl:if> > <xsl:text> </xsl:text> > <!-- Media Type --> > <xsl:if test="marc:datafield[@tag=338]"> > <span class="label">Carrier type: </span> >- <xsl:for-each select="marc:datafield[@tag=338]"> >- <xsl:call-template name="subfieldSelect"> >- <xsl:with-param name="codes">a</xsl:with-param> >- <xsl:with-param name="delimeter">, </xsl:with-param> >- </xsl:call-template> >- <xsl:if test="position() != last()"><span class="separator"><xsl:text> | </xsl:text></span></xsl:if> >- </xsl:for-each> >+ <ul class="resource_list"> >+ <xsl:for-each select="marc:datafield[@tag=338]"> >+ <li> >+ <xsl:call-template name="subfieldSelect"> >+ <xsl:with-param name="codes">a</xsl:with-param> >+ <xsl:with-param name="delimeter">, </xsl:with-param> >+ </xsl:call-template> >+ </li> >+ </xsl:for-each> >+ </ul> > </xsl:if> > </span> > </xsl:if> >@@ -1037,10 +1046,13 @@ > <xsl:if test="marc:datafield[@tag=586]/@ind1=' '"> > <span class="label">Awards: </span> > </xsl:if> >- <xsl:for-each select="marc:datafield[@tag=586]"> >- <xsl:value-of select="marc:subfield[@code='a']"/> >- <xsl:if test="position()!=last()"><span class="separator"><xsl:text> | </xsl:text></span></xsl:if> >- </xsl:for-each> >+ <ul class="resource_list"> >+ <xsl:for-each select="marc:datafield[@tag=586]"> >+ <li> >+ <xsl:value-of select="marc:subfield[@code='a']"/> >+ </li> >+ </xsl:for-each> >+ </ul> > </span> > </xsl:if> > >@@ -1048,12 +1060,15 @@ > <xsl:if test="marc:datafield[@tag=508]"> > <span class="results_summary prod_credits"> > <span class="label">Production credits: </span> >- <xsl:for-each select="marc:datafield[@tag=508]"> >- <xsl:call-template name="subfieldSelectSpan"> >- <xsl:with-param name="codes">a</xsl:with-param> >- </xsl:call-template> >- <xsl:if test="position()!=last()"><span class="separator"><xsl:text> | </xsl:text></span></xsl:if> >- </xsl:for-each> >+ <ul class="resource_list"> >+ <xsl:for-each select="marc:datafield[@tag=508]"> >+ <li> >+ <xsl:call-template name="subfieldSelectSpan"> >+ <xsl:with-param name="codes">a</xsl:with-param> >+ </xsl:call-template> >+ </li> >+ </xsl:for-each> >+ </ul> > </span> > </xsl:if> > >-- >2.51.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30148
:
187486
|
187487
|
187488
|
187490
|
187491
|
187492
|
187497
|
187498
|
187499