Bug 30148 - Pipe separated contents are hard to customize (staff interface)
Summary: Pipe separated contents are hard to customize (staff interface)
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Tomás Cohen Arazi (tcohen)
QA Contact: Testopia
URL:
Keywords:
Depends on: 40959 27613
Blocks:
  Show dependency treegraph
 
Reported: 2022-02-21 21:30 UTC by Katrin Fischer
Modified: 2025-10-06 20:15 UTC (History)
4 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 30148: (follow-up) Apply CSS-based separators to online resources (856) (2.17 KB, patch)
2025-10-06 18:19 UTC, Tomás Cohen Arazi (tcohen)
Details | Diff | Splinter Review
Bug 30148: (follow-up) Apply CSS-based separators to additional repeatable fields (6.80 KB, patch)
2025-10-06 18:19 UTC, Tomás Cohen Arazi (tcohen)
Details | Diff | Splinter Review
Bug 30148: Apply CSS-based separators to all classification fields (7.82 KB, patch)
2025-10-06 18:19 UTC, Tomás Cohen Arazi (tcohen)
Details | Diff | Splinter Review
Bug 30148: Apply CSS-based separators to all classification fields (7.82 KB, patch)
2025-10-06 18:20 UTC, Tomás Cohen Arazi (tcohen)
Details | Diff | Splinter Review
Bug 30148: (follow-up) Apply CSS-based separators to additional repeatable fields (6.80 KB, patch)
2025-10-06 18:20 UTC, Tomás Cohen Arazi (tcohen)
Details | Diff | Splinter Review
Bug 30148: (follow-up) Apply CSS-based separators to online resources (856) (2.17 KB, patch)
2025-10-06 18:20 UTC, Tomás Cohen Arazi (tcohen)
Details | Diff | Splinter Review
Bug 30148: Apply CSS-based separators to all classification fields (7.87 KB, patch)
2025-10-06 20:15 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 30148: (follow-up) Apply CSS-based separators to additional repeatable fields (6.86 KB, patch)
2025-10-06 20:15 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 30148: (follow-up) Apply CSS-based separators to online resources (856) (2.23 KB, patch)
2025-10-06 20:15 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2022-02-21 21:30:39 UTC
Changes to the XSLT files like on bug 27613, but for the staff interface.
Comment 1 Tomás Cohen Arazi (tcohen) 2025-10-06 18:19:05 UTC Comment hidden (obsolete)
Comment 2 Tomás Cohen Arazi (tcohen) 2025-10-06 18:19:07 UTC Comment hidden (obsolete)
Comment 3 Tomás Cohen Arazi (tcohen) 2025-10-06 18:19:09 UTC Comment hidden (obsolete)
Comment 4 Tomás Cohen Arazi (tcohen) 2025-10-06 18:19:11 UTC Comment hidden (obsolete)
Comment 5 Tomás Cohen Arazi (tcohen) 2025-10-06 18:20:05 UTC
Created attachment 187490 [details] [review]
Bug 30148: Apply CSS-based separators to all classification fields

This patch changes the classification display from hardcoded pipe
separators to CSS pseudo-elements, following the same approach as
Bug 27613 for the OPAC.

Changes:
- Wrap each field occurrence in <li> elements within <ul>
- Remove hardcoded delimeter parameter from subfieldSelect
- Add CSS rules to display pipe separators via ::after pseudo-elements
- LOC classification (050)
- Publisher number (028)
- DDC classification (082)
- NLM classification (060)
- Other classification (084)

This allows libraries to customize the separator display via CSS.

It also provides consistent behavior and customization options across
all repeatable classification fields in the staff interface.

To test:
1. Create a record with multiple 050 fields:
   050  4 $aE337.5 $b.O54 2025
   050  4 $aE415.7 $b.A44 2025
2. View the record in staff interface
=> SUCCESS: Classification looks ok:

```
E337.5 .O54 2025 | E415.7 .A44 2025
```

3. Apply this patch
4. Run:
   $ ktd --shell
  k$ yarn build
5. Refresh the page
=> SUCCESS: It still looks correct!
6. Sign off :-D

Extends the CSS-based separator approach to all classification fields
that were using hardcoded pipe separators:
Comment 6 Tomás Cohen Arazi (tcohen) 2025-10-06 18:20:08 UTC
Created attachment 187491 [details] [review]
Bug 30148: (follow-up) Apply CSS-based separators to additional repeatable fields

Extends the CSS-based separator approach to additional repeatable fields
that were using hardcoded pipe separators:

- Content type (336)
- Media type (337)
- Carrier type (338)
- Awards (586)
- Production credits (508)

This provides consistent behavior and customization options across
all major repeatable fields in the staff interface, matching the
approach used for classification fields.
Comment 7 Tomás Cohen Arazi (tcohen) 2025-10-06 18:20:11 UTC
Created attachment 187492 [details] [review]
Bug 30148: (follow-up) Apply CSS-based separators to online resources (856)

Extends the CSS-based separator approach to field 856 (Electronic Location
and Access) which was still using hardcoded pipe separators.

This completes the conversion of all major repeatable fields in the staff
interface to use consistent CSS-based separators, matching the OPAC
implementation from Bug 27613.
Comment 8 Lucas Gass (lukeg) 2025-10-06 20:15:20 UTC
Created attachment 187497 [details] [review]
Bug 30148: Apply CSS-based separators to all classification fields

This patch changes the classification display from hardcoded pipe
separators to CSS pseudo-elements, following the same approach as
Bug 27613 for the OPAC.

Changes:
- Wrap each field occurrence in <li> elements within <ul>
- Remove hardcoded delimeter parameter from subfieldSelect
- Add CSS rules to display pipe separators via ::after pseudo-elements
- LOC classification (050)
- Publisher number (028)
- DDC classification (082)
- NLM classification (060)
- Other classification (084)

This allows libraries to customize the separator display via CSS.

It also provides consistent behavior and customization options across
all repeatable classification fields in the staff interface.

To test:
1. Create a record with multiple 050 fields:
   050  4 $aE337.5 $b.O54 2025
   050  4 $aE415.7 $b.A44 2025
2. View the record in staff interface
=> SUCCESS: Classification looks ok:

```
E337.5 .O54 2025 | E415.7 .A44 2025
```

3. Apply this patch
4. Run:
   $ ktd --shell
  k$ yarn build
5. Refresh the page
=> SUCCESS: It still looks correct!
6. Sign off :-D

Extends the CSS-based separator approach to all classification fields
that were using hardcoded pipe separators:

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 9 Lucas Gass (lukeg) 2025-10-06 20:15:23 UTC
Created attachment 187498 [details] [review]
Bug 30148: (follow-up) Apply CSS-based separators to additional repeatable fields

Extends the CSS-based separator approach to additional repeatable fields
that were using hardcoded pipe separators:

- Content type (336)
- Media type (337)
- Carrier type (338)
- Awards (586)
- Production credits (508)

This provides consistent behavior and customization options across
all major repeatable fields in the staff interface, matching the
approach used for classification fields.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 10 Lucas Gass (lukeg) 2025-10-06 20:15:26 UTC
Created attachment 187499 [details] [review]
Bug 30148: (follow-up) Apply CSS-based separators to online resources (856)

Extends the CSS-based separator approach to field 856 (Electronic Location
and Access) which was still using hardcoded pipe separators.

This completes the conversion of all major repeatable fields in the staff
interface to use consistent CSS-based separators, matching the OPAC
implementation from Bug 27613.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>