Bugzilla – Attachment 187506 Details for
Bug 38739
Templates not ending with include intranet-bottom.inc in staff interface
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38739: Fix mana-report-search-result.inc
Bug-38739-Fix-mana-report-search-resultinc.patch (text/plain), 11.22 KB, created by
Jonathan Druart
on 2025-10-07 09:32:05 UTC
(
hide
)
Description:
Bug 38739: Fix mana-report-search-result.inc
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2025-10-07 09:32:05 UTC
Size:
11.22 KB
patch
obsolete
>From e55c96c8542779f68f0d9015d9aae92ef8689fa1 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 7 Oct 2025 11:08:14 +0200 >Subject: [PATCH] Bug 38739: Fix mana-report-search-result.inc > >--- > .../mana/mana-report-search-result.inc | 176 ++++++++---------- > 1 file changed, 81 insertions(+), 95 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/mana/mana-report-search-result.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/mana/mana-report-search-result.inc >index 8edca6cc48a..21598281b06 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/mana/mana-report-search-result.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/mana/mana-report-search-result.inc >@@ -27,104 +27,90 @@ > › Mana Knowledge Base report search results > </div> > >-<div class="main container-fluid"> >- <div class="row"> >- <div class="col-md-10 order-md-2 order-sm-1"> >- <main> >- <h2>Mana Knowledge Base report search results</h2> >+[% WRAPPER 'main-container.inc' aside='guided-reports-view' %] >+ <h2>Mana Knowledge Base report search results</h2> > >- <div id="mana_results"> >- [% IF statuscode == "200" AND reports %] >- <table id="mana_results_datatable"> >- <thead> >- <tr> >- <th>Report name</th> >- <th class="anti-the">Notes</th> >- <th>Type</th> >- <th title="Number of libraries using this pattern"># of users</th> >- <th title="Last time a library used this pattern">Last import</th> >- <th> Comments </th> >- [% UNLESS search_only %] >- <th class="no-sort no-export">Actions</th> >+ <div id="mana_results"> >+ [% IF statuscode == "200" AND reports %] >+ <table id="mana_results_datatable"> >+ <thead> >+ <tr> >+ <th>Report name</th> >+ <th class="anti-the">Notes</th> >+ <th>Type</th> >+ <th title="Number of libraries using this pattern"># of users</th> >+ <th title="Last time a library used this pattern">Last import</th> >+ <th> Comments </th> >+ [% UNLESS search_only %] >+ <th class="no-sort no-export">Actions</th> >+ [% END %] >+ </tr> >+ </thead> >+ <tbody> >+ [% FOREACH report IN reports %] >+ [% UNLESS report.cannotdisplay %] >+ [% IF report.nbofcomment > highWarned %] >+ [% SET tr_class = 'high-warned-row' %] >+ [% ELSIF report.nbofcomment > warned %] >+ [% SET tr_class = 'warned-row' %] >+ [% ELSIF report.nbofcomment > lowWarned %] >+ [% SET tr_class = 'highlighted-row' %] >+ [% ELSE %] >+ [% SET tr_class = '' %] >+ [% END %] >+ <tr id="[% report.id | html %]" class="[% tr_class | html %]"> >+ <td> >+ <input type="hidden" class="rowid" value="[% report.id | $raw %]" /> >+ [% IF ( report.report_name ) %] >+ [% report.report_name | html %] > [% END %] >- </tr> >- </thead> >- <tbody> >- [% FOREACH report IN reports %] >- [% UNLESS report.cannotdisplay %] >- [% IF report.nbofcomment > highWarned %] >- [% SET tr_class = 'high-warned-row' %] >- [% ELSIF report.nbofcomment > warned %] >- [% SET tr_class = 'warned-row' %] >- [% ELSIF report.nbofcomment > lowWarned %] >- [% SET tr_class = 'highlighted-row' %] >- [% ELSE %] >- [% SET tr_class = '' %] >- [% END %] >- <tr id="[% report.id | html %]" class="[% tr_class | html %]"> >- <td> >- <input type="hidden" class="rowid" value="[% report.id | $raw %]" /> >- [% IF ( report.report_name ) %] >- [% report.report_name | html %] >- [% END %] >- </td> >- <td title="[% report.savedsql | html %]"> >- [% IF report.notes.length > 200 %] >- <div> >- [% report.notes.substr(0,200) | html %]... <a href="#" class="btn btn-link btn-sm showbutton"><i class="fa-solid fa-square-plus"></i> Show more</a> >- </div> >- <div style="display:none"> >- [% report.notes | html %] >- <a href="#" class="btn btn-link btn-sm hidebutton"><i class="fa-solid fa-square-minus"></i> Show less</a> >- </div> >- [% ELSE %] >- [% report.notes | html %] >- [% END %] >- </td> >- <td> [% report.type | html %] </td> >- <td> >- [% IF ( report.nbofusers ) %] >- [% report.nbofusers | html %] >- [% END %] >- </td> >- <td data-order="[% report.lastimport | html %]"> [% report.lastimport | $KohaDates %] </td> >- <td> >- [% FOREACH comment IN report.comments %] >- [% comment.message | html %] >- ([% comment.nb | html %])<br /> >- [% END %] >- </td> >- >- [% UNLESS search_only %] >- <td> >- <button type="button" class="btn btn-default btn-xs mana-use" id="mana-use-[% report.id | html %]" data-report_id="[% report.id | html %]"><i class="fa fa-download"></i> Import</button> >- </td> >- [% END %] >- </tr> >+ </td> >+ <td title="[% report.savedsql | html %]"> >+ [% IF report.notes.length > 200 %] >+ <div> >+ [% report.notes.substr(0,200) | html %]... <a href="#" class="btn btn-link btn-sm showbutton"><i class="fa-solid fa-square-plus"></i> Show more</a> >+ </div> >+ <div style="display:none"> >+ [% report.notes | html %] >+ <a href="#" class="btn btn-link btn-sm hidebutton"><i class="fa-solid fa-square-minus"></i> Show less</a> >+ </div> >+ [% ELSE %] >+ [% report.notes | html %] > [% END %] >+ </td> >+ <td> [% report.type | html %] </td> >+ <td> >+ [% IF ( report.nbofusers ) %] >+ [% report.nbofusers | html %] >+ [% END %] >+ </td> >+ <td data-order="[% report.lastimport | html %]"> [% report.lastimport | $KohaDates %] </td> >+ <td> >+ [% FOREACH comment IN report.comments %] >+ [% comment.message | html %] >+ ([% comment.nb | html %])<br /> >+ [% END %] >+ </td> >+ >+ [% UNLESS search_only %] >+ <td> >+ <button type="button" class="btn btn-default btn-xs mana-use" id="mana-use-[% report.id | html %]" data-report_id="[% report.id | html %]"><i class="fa fa-download"></i> Import</button> >+ </td> > [% END %] >- </tbody> >- </table> >- [% ELSE %] >- <h4> >- [% IF ( msg ) %] >- [% msg | html %] <span>(Status code: [% statuscode | html %])</span> >- [% ELSE %] >- <span>No results found</span> >- [% END %] >- </h4> >+ </tr> >+ [% END %] > [% END %] >- </div> >- </main> >- </div> >- <!-- /.col-md-10.order-md-2 --> >- >- <div class="col-md-2 order-sm-2 order-md-1"> >- <aside> [% INCLUDE 'guided-reports-view.inc' %] </aside> >- </div> >- <!-- /.col-md-2.order-md-1 --> >+ </tbody> >+ </table> >+ [% ELSE %] >+ <h4> >+ [% IF ( msg ) %] >+ [% msg | html %] <span>(Status code: [% statuscode | html %])</span> >+ [% ELSE %] >+ <span>No results found</span> >+ [% END %] >+ </h4> >+ [% END %] > </div> >- <!-- /.row --> >- >- [% INCLUDE 'intranet-bottom.inc' %] >-</div> >+[% END %] >+[% INCLUDE 'intranet-bottom.inc' %] >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38739
: 187506 |
187507
|
187508
|
187509
|
187510