Some templates in staff interface do not end with include intranet-bottom.inc. > tail -n1 koha-tmpl/intranet-tmpl/prog/en/modules/*/*.tt | grep -B2 '</html>' ==> koha-tmpl/intranet-tmpl/prog/en/modules/acqui/showorder.tt <== </html> -- ==> koha-tmpl/intranet-tmpl/prog/en/modules/basket/basket.tt <== </html> ==> koha-tmpl/intranet-tmpl/prog/en/modules/basket/downloadcart.tt <== </html> ==> koha-tmpl/intranet-tmpl/prog/en/modules/basket/sendbasketform.tt <== </html> ==> koha-tmpl/intranet-tmpl/prog/en/modules/batch/print-notices.tt <== </html> -- ==> koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/showelastic.tt <== </html> ==> koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/showmarc.tt <== </html> -- ==> koha-tmpl/intranet-tmpl/prog/en/modules/reports/convert_report.tt <== </html> -- ==> koha-tmpl/intranet-tmpl/prog/en/modules/tools/preview_letter.tt <== </html> -- ==> koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/downloadshelf.tt <== </html> ==> koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/sendshelfform.tt <== </html> So for example it does not call hook "intranet_js". Should all templates end with this include ?
Popup windows and pages like showmarc.tt which are loaded via AJAX do not need the full contents of intranet-bottom. We would either need to add some logic to intranet-bottom.inc or add a different, trimmed-down version.
*** Bug 38740 has been marked as a duplicate of this bug. ***
koha-tmpl/intranet-tmpl/prog/en/modules/basket/basket.tt calls : [% INCLUDE 'intranet-bottom.inc' popup_window=1 %] That will add ending tags body and html this must be at the end
other suspects : koha-tmpl/intranet-tmpl/prog/en/includes/mana/mana-report-search-result.inc koha-tmpl/intranet-tmpl/prog/en/modules/admin/file_transports.tt koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/cn_browser.tt koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_210c_bis.tt koha-tmpl/intranet-tmpl/prog/en/modules/reserve/hold-group.tt koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-renew.tt koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_modify_holds.tt > Should all templates end with this include ? Nope, some blocks may exist after it. Also there is the example curbside_pickups.tt with : [% UNLESS policy.enabled %] <div class="alert alert-warning"> Curbside pickups are not enabled for your library. </div> [% INCLUDE 'intranet-bottom.inc' %] [% STOP %] [% END %]
Check with : git grep -A1 "INCLUDE 'intranet-bottom.inc'" | grep -v INCLUDE | grep '</'
(In reply to Fridolin Somers from comment #3) > koha-tmpl/intranet-tmpl/prog/en/modules/basket/basket.tt > calls : > [% INCLUDE 'intranet-bottom.inc' popup_window=1 %] > That will add ending tags body and html > this must be at the end Caused by bug 37033.
Created attachment 187506 [details] [review] Bug 38739: Fix mana-report-search-result.inc
Created attachment 187507 [details] [review] Bug 38739: Fix admin/file_transports.pl
Created attachment 187508 [details] [review] Bug 38739: Fix tools/batch_modify_holds.tt
Created attachment 187509 [details] [review] Bug 38739: Fix some other wrong templates
Created attachment 187510 [details] [review] Bug 38739: Fix basket/basket.tt