Bugzilla – Attachment 187830 Details for
Bug 41001
Dismissing the "Run now" modal breaks functionality
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41001: Remove messages when dialog closes, even if not through the close button
Bug-41001-Remove-messages-when-dialog-closes-even-.patch (text/plain), 2.02 KB, created by
Jan Kissig
on 2025-10-13 10:51:41 UTC
(
hide
)
Description:
Bug 41001: Remove messages when dialog closes, even if not through the close button
Filename:
MIME Type:
Creator:
Jan Kissig
Created:
2025-10-13 10:51:41 UTC
Size:
2.02 KB
patch
obsolete
>From 638dd210c4f97d0bf0faa3470002636f857055cd Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@openfifth.co.uk> >Date: Tue, 30 Sep 2025 14:21:15 +0000 >Subject: [PATCH] Bug 41001: Remove messages when dialog closes, even if not > through the close button > >This ensures that when the dialog is closed, even when clicked outside of it, the messages are correctly removed, same as if the 'close' button had been clicked. > >Test plan: >- create a data ERM provider /cgi-bin/koha/erm/eusage/usage_data_providers/add >- dummy data should be sufficient >- then go to data providers list /cgi-bin/koha/erm/eusage/usage_data_provider >- open web development tools console (F12 firefox) >- click on "Run now" >- dismiss dialog by clicking outside the modal! >- click again on "Run now" >- check the logs for errors >- any other clicks to create a modal won't work now ("run now", "delete") > >Apply patch. run yarn js:watch or yarn js:build. Repeat. > >Signed-off-by: Jan Kissig <bibliothek@th-wildau.de> >--- > koha-tmpl/intranet-tmpl/prog/js/vue/components/Dialog.vue | 6 ++++++ > 1 file changed, 6 insertions(+) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/Dialog.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/Dialog.vue >index 4e48f53d311..162c93a7da7 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/Dialog.vue >+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/Dialog.vue >@@ -172,6 +172,9 @@ export default { > return; > } > nextTick(() => { >+ $("#warning.modal").on("hidden.bs.modal", function () { >+ removeMessages(); >+ }); > $("#warning.modal").modal("show"); > }); > }); >@@ -182,6 +185,9 @@ export default { > return; > } > nextTick(() => { >+ $("#confirmation.modal").on("hidden.bs.modal", function () { >+ removeConfirmationMessages(); >+ }); > $("#confirmation.modal").modal("show"); > }); > }); >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41001
:
187814
| 187830 |
187839