To recreate: - create a data ERM provider /cgi-bin/koha/erm/eusage/usage_data_providers/add - dummy data should be sufficient - then go to data providers list /cgi-bin/koha/erm/eusage/usage_data_provider - open web development tools console (F12 firefox) - click on "Run now" - dismiss dialog by clicking outside the modal! - click again on "Run now" - check the logs for errors - any other clicks to create a modal won't work now ("run now", "delete")
I believe I have patch in bug 37762 that may fix this issue. I'll test and check and submit here if so.
Created attachment 187814 [details] [review] Bug 41001: Remove messages when dialog closes, even if not through the close button This ensures that when the dialog is closed, even when clicked outside of it, the messages are correctly removed, same as if the 'close' button had been clicked. Test plan: - create a data ERM provider /cgi-bin/koha/erm/eusage/usage_data_providers/add - dummy data should be sufficient - then go to data providers list /cgi-bin/koha/erm/eusage/usage_data_provider - open web development tools console (F12 firefox) - click on "Run now" - dismiss dialog by clicking outside the modal! - click again on "Run now" - check the logs for errors - any other clicks to create a modal won't work now ("run now", "delete") Apply patch. run yarn js:watch or yarn js:build. Repeat.
Created attachment 187830 [details] [review] Bug 41001: Remove messages when dialog closes, even if not through the close button This ensures that when the dialog is closed, even when clicked outside of it, the messages are correctly removed, same as if the 'close' button had been clicked. Test plan: - create a data ERM provider /cgi-bin/koha/erm/eusage/usage_data_providers/add - dummy data should be sufficient - then go to data providers list /cgi-bin/koha/erm/eusage/usage_data_provider - open web development tools console (F12 firefox) - click on "Run now" - dismiss dialog by clicking outside the modal! - click again on "Run now" - check the logs for errors - any other clicks to create a modal won't work now ("run now", "delete") Apply patch. run yarn js:watch or yarn js:build. Repeat. Signed-off-by: Jan Kissig <bibliothek@th-wildau.de>
Can we have a Cypress test please?
Created attachment 187839 [details] [review] Bug 41001: Add cypress test
Thanks. However I think we need a test at the framework/baseResource level in t/cypress/component/baseResource.ts.
(In reply to Jonathan Druart from comment #6) > Thanks. However I think we need a test at the framework/baseResource level > in t/cypress/component/baseResource.ts. Is this a Failed QA ?
(In reply to Marcel de Rooy from comment #7) > (In reply to Jonathan Druart from comment #6) > > Thanks. However I think we need a test at the framework/baseResource level > > in t/cypress/component/baseResource.ts. > > Is this a Failed QA ? At least to get an answer, yes.
(In reply to Jonathan Druart from comment #6) > Thanks. However I think we need a test at the framework/baseResource level > in t/cypress/component/baseResource.ts. Can you please clarify what you mean by this? t/cypress/component/baseResource.ts tests composables/base-resource.js methods. This is not the case here, the cypress test I provided proves that this bug exists before the fix patch and no longer exists after the fix patch.
Changes to generic components must have tests in their own test file. Otherwise we might lose them later. Here you modify the behaviour of the Dialog component that is used in several other places, then we should have tests in a Dialog_spec.ts file.
Created attachment 188317 [details] [review] Bug 41001: (QA follow-up): Add 'Confirmation messages with inputs' specific tests cypress run --spec t/cypress/integration/ERM/Dialog_spec.ts
Joubu can you please confirm if my latest patch satisfies the QA requirements here? Given that it is a bug fix and release is right around the corner. Thank you.
Created attachment 189325 [details] [review] Bug 41001: Remove messages when dialog closes, even if not through the close button This ensures that when the dialog is closed, even when clicked outside of it, the messages are correctly removed, same as if the 'close' button had been clicked. Test plan: - create a data ERM provider /cgi-bin/koha/erm/eusage/usage_data_providers/add - dummy data should be sufficient - then go to data providers list /cgi-bin/koha/erm/eusage/usage_data_provider - open web development tools console (F12 firefox) - click on "Run now" - dismiss dialog by clicking outside the modal! - click again on "Run now" - check the logs for errors - any other clicks to create a modal won't work now ("run now", "delete") Apply patch. run yarn js:watch or yarn js:build. Repeat. Signed-off-by: Jan Kissig <bibliothek@th-wildau.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 189326 [details] [review] Bug 41001: Add cypress test Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 189327 [details] [review] Bug 41001: (QA follow-up): Add 'Confirmation messages with inputs' specific tests cypress run --spec t/cypress/integration/ERM/Dialog_spec.ts Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Nice work everyone! Pushed to main for 25.11