Bug 41001 - Dismissing the "Run now" modal breaks functionality
Summary: Dismissing the "Run now" modal breaks functionality
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: ERM (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Pedro Amorim
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 37762
  Show dependency treegraph
 
Reported: 2025-10-13 08:59 UTC by Jan Kissig
Modified: 2025-10-13 14:09 UTC (History)
5 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 41001: Remove messages when dialog closes, even if not through the close button (1.97 KB, patch)
2025-10-13 09:06 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 41001: Remove messages when dialog closes, even if not through the close button (2.02 KB, patch)
2025-10-13 10:51 UTC, Jan Kissig
Details | Diff | Splinter Review
Bug 41001: Add cypress test (976 bytes, patch)
2025-10-13 13:31 UTC, Pedro Amorim
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Kissig 2025-10-13 08:59:51 UTC
To recreate:
- create a data ERM provider /cgi-bin/koha/erm/eusage/usage_data_providers/add
- dummy data should be sufficient
- then go to data providers list /cgi-bin/koha/erm/eusage/usage_data_provider
- open web development tools console (F12 firefox)
- click on "Run now"
- dismiss dialog by clicking outside the modal!
- click again on "Run now"
- check the logs for errors
- any other clicks to create a modal won't work now ("run now", "delete")
Comment 1 Pedro Amorim 2025-10-13 09:03:43 UTC
I believe I have patch in bug 37762 that may fix this issue. I'll test and check and submit here if so.
Comment 2 Pedro Amorim 2025-10-13 09:06:48 UTC
Created attachment 187814 [details] [review]
Bug 41001: Remove messages when dialog closes, even if not through the close button

This ensures that when the dialog is closed, even when clicked outside of it, the messages are correctly removed, same as if the 'close' button had been clicked.

Test plan:
- create a data ERM provider /cgi-bin/koha/erm/eusage/usage_data_providers/add
- dummy data should be sufficient
- then go to data providers list /cgi-bin/koha/erm/eusage/usage_data_provider
- open web development tools console (F12 firefox)
- click on "Run now"
- dismiss dialog by clicking outside the modal!
- click again on "Run now"
- check the logs for errors
- any other clicks to create a modal won't work now ("run now", "delete")

Apply patch. run yarn js:watch or yarn js:build. Repeat.
Comment 3 Jan Kissig 2025-10-13 10:51:41 UTC
Created attachment 187830 [details] [review]
Bug 41001: Remove messages when dialog closes, even if not through the close button

This ensures that when the dialog is closed, even when clicked outside of it, the messages are correctly removed, same as if the 'close' button had been clicked.

Test plan:
- create a data ERM provider /cgi-bin/koha/erm/eusage/usage_data_providers/add
- dummy data should be sufficient
- then go to data providers list /cgi-bin/koha/erm/eusage/usage_data_provider
- open web development tools console (F12 firefox)
- click on "Run now"
- dismiss dialog by clicking outside the modal!
- click again on "Run now"
- check the logs for errors
- any other clicks to create a modal won't work now ("run now", "delete")

Apply patch. run yarn js:watch or yarn js:build. Repeat.

Signed-off-by: Jan Kissig <bibliothek@th-wildau.de>
Comment 4 Jonathan Druart 2025-10-13 11:38:07 UTC
Can we have a Cypress test please?
Comment 5 Pedro Amorim 2025-10-13 13:31:36 UTC
Created attachment 187839 [details] [review]
Bug 41001: Add cypress test
Comment 6 Jonathan Druart 2025-10-13 14:09:40 UTC
Thanks. However I think we need a test at the framework/baseResource level in t/cypress/component/baseResource.ts.