To recreate: - create a data ERM provider /cgi-bin/koha/erm/eusage/usage_data_providers/add - dummy data should be sufficient - then go to data providers list /cgi-bin/koha/erm/eusage/usage_data_provider - open web development tools console (F12 firefox) - click on "Run now" - dismiss dialog by clicking outside the modal! - click again on "Run now" - check the logs for errors - any other clicks to create a modal won't work now ("run now", "delete")
I believe I have patch in bug 37762 that may fix this issue. I'll test and check and submit here if so.
Created attachment 187814 [details] [review] Bug 41001: Remove messages when dialog closes, even if not through the close button This ensures that when the dialog is closed, even when clicked outside of it, the messages are correctly removed, same as if the 'close' button had been clicked. Test plan: - create a data ERM provider /cgi-bin/koha/erm/eusage/usage_data_providers/add - dummy data should be sufficient - then go to data providers list /cgi-bin/koha/erm/eusage/usage_data_provider - open web development tools console (F12 firefox) - click on "Run now" - dismiss dialog by clicking outside the modal! - click again on "Run now" - check the logs for errors - any other clicks to create a modal won't work now ("run now", "delete") Apply patch. run yarn js:watch or yarn js:build. Repeat.
Created attachment 187830 [details] [review] Bug 41001: Remove messages when dialog closes, even if not through the close button This ensures that when the dialog is closed, even when clicked outside of it, the messages are correctly removed, same as if the 'close' button had been clicked. Test plan: - create a data ERM provider /cgi-bin/koha/erm/eusage/usage_data_providers/add - dummy data should be sufficient - then go to data providers list /cgi-bin/koha/erm/eusage/usage_data_provider - open web development tools console (F12 firefox) - click on "Run now" - dismiss dialog by clicking outside the modal! - click again on "Run now" - check the logs for errors - any other clicks to create a modal won't work now ("run now", "delete") Apply patch. run yarn js:watch or yarn js:build. Repeat. Signed-off-by: Jan Kissig <bibliothek@th-wildau.de>
Can we have a Cypress test please?
Created attachment 187839 [details] [review] Bug 41001: Add cypress test
Thanks. However I think we need a test at the framework/baseResource level in t/cypress/component/baseResource.ts.