Bugzilla – Attachment 187886 Details for
Bug 30633
Move OPACHoldingsDefaultSortField to table settings configuration
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 30633: Prepare the ground
Bug-30633-Prepare-the-ground.patch (text/plain), 11.56 KB, created by
Biblibre Sandboxes
on 2025-10-14 14:24:31 UTC
(
hide
)
Description:
Bug 30633: Prepare the ground
Filename:
MIME Type:
Creator:
Biblibre Sandboxes
Created:
2025-10-14 14:24:31 UTC
Size:
11.56 KB
patch
obsolete
>From 53ea6d564f0718f3f79aa586143eb669288d4bb6 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 14 Oct 2025 10:33:04 +0200 >Subject: [PATCH] Bug 30633: Prepare the ground > >Make the OPAC holdings table ready to use visibility based on >column's names. > >Signed-off-by: Michaela <michaela.sieber@kit.edu> >--- > .../bootstrap/en/modules/opac-detail.tt | 115 ++++++++++-------- > 1 file changed, 63 insertions(+), 52 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >index 259ccfefb3..3e2e5ec465 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >@@ -1295,57 +1295,24 @@ > <caption class="sr-only">Holdings</caption> > <thead> > <tr> >- [% IF Koha.Preference('OPACLocalCoverImages') && ( tab == 'holdings' && itemloop_has_images || tab == 'otherholdings' && otheritemloop_has_images ) %] >- <th id="item_cover" data-colname="item_cover">Cover image</th> >- [% END %] >- [% IF ( item_level_itypes ) %] >- <th id="item_itemtype" data-colname="item_itemtype" class="itype">Item type</th> >- [% END %] >- [% IF ( OpacLocationBranchToDisplay == 'holding' || OpacLocationBranchToDisplay == 'both' ) %] >- <th id="item_current_location" data-colname="item_current_location" class="item_location">Current library</th> >- [% END %] >- [% IF ( OpacLocationBranchToDisplay == 'home' || OpacLocationBranchToDisplay == 'both' ) %] >- <th id="item_home_location" data-colname="item_home_location" class="item_location">Home library</th> >- [% END %] >- [% IF ( itemdata_ccode ) %] >- <th id="item_ccode" data-colname="item_ccode" class="collection">Collection</th> >- [% END %] >- [% IF ( Koha.Preference('OpacLocationOnDetail') == 'column' && itemdata_location ) %] >- <th id="item_shelving_location" data-colname="item_shelving_location" class="shelving_location">Shelving location</th> >- [% END %] >- [% IF ( itemdata_itemcallnumber ) %] >- <th id="item_callnumber" data-colname="item_callnumber" class="call_no">Call number</th> >- [% END %] >- [% IF ( itemdata_materials ) %] >- <th id="item_materials" data-colname="item_materials" class="materials">Materials specified</th> >- [% END %] >- [% IF ( itemdata_enumchron ) %] >- <th id="item_enumchron" data-colname="item_enumchron" class="vol_info">Vol info</th> >- [% END %] >- [% IF ( itemdata_uri ) %] >- <th id="item_url" data-colname="item_url" class="url">URL</th> >- [% END %] >- [% IF ( itemdata_copynumber ) %] >- <th id="item_copy" data-colname="item_copy" class="copynumber">Copy number</th> >- [% END %] >+ <th id="item_cover" data-colname="item_cover">Cover image</th> >+ <th id="item_itemtype" data-colname="item_itemtype" class="itype">Item type</th> >+ <th id="item_current_location" data-colname="item_current_location" class="item_location">Current library</th> >+ <th id="item_home_location" data-colname="item_home_location" class="item_location">Home library</th> >+ <th id="item_ccode" data-colname="item_ccode" class="collection">Collection</th> >+ <th id="item_shelving_location" data-colname="item_shelving_location" class="shelving_location">Shelving location</th> >+ <th id="item_callnumber" data-colname="item_callnumber" class="call_no">Call number</th> >+ <th id="item_materials" data-colname="item_materials" class="materials">Materials specified</th> >+ <th id="item_enumchron" data-colname="item_enumchron" class="vol_info">Vol info</th> >+ <th id="item_url" data-colname="item_url" class="url">URL</th> >+ <th id="item_copy" data-colname="item_copy" class="copynumber">Copy number</th> > <th id="item_status" data-colname="item_status" class="status">Status</th> >- [% IF ( itemdata_itemnotes ) %] >- <th id="item_notes" data-colname="item_notes" class="notes">Notes</th> >- [% END %] >- [% IF ( item_checkouts ) %] >- <th id="item_datedue" data-colname="item_datedue" class="date_due">Date due</th> >- [% END %] >- [% IF ( itemdata_barcode ) %] >- <th id="item_barcode" data-colname="item_barcode" class="barcode">Barcode</th> >- [% END %] >- [% IF item_level_holds > 0 %] >- <th id="item_holds" data-colname="item_holds">Item holds</th> >- [% ELSIF show_priority %] >- <th id="item_priority" data-colname="item_priority">Item hold queue priority</th> >- [% END %] >- [% IF ( ShowCourseReservesHeader ) %] >- <th id="item_coursereserves" data-colname="item_coursereserves">Course reserves</th> >- [% END %] >+ <th id="item_notes" data-colname="item_notes" class="notes">Notes</th> >+ <th id="item_datedue" data-colname="item_datedue" class="date_due">Date due</th> >+ <th id="item_barcode" data-colname="item_barcode" class="barcode">Barcode</th> >+ <th id="item_holds" data-colname="item_holds">Item holds</th> >+ <th id="item_priority" data-colname="item_priority">Item hold queue priority</th> >+ <th id="item_coursereserves" data-colname="item_coursereserves">Course reserves</th> > <th class="dtr-control-col"></th> > </tr> > </thead> >@@ -1366,6 +1333,8 @@ > </div> > </div> > </td> >+ [% ELSE %] >+ <td></td> > [% END %] > > [% IF ( item_level_itypes ) %] >@@ -1377,6 +1346,8 @@ > [% END %] > <span class="itypetext">[% ITEM_RESULT.description | html %]</span> > </td> >+ [% ELSE %] >+ <td></td> > [% END %] > [% IF ( OpacLocationBranchToDisplay == 'holding' || OpacLocationBranchToDisplay == 'both' ) %] > [%# Show opac_info or branchurl from holding library %] >@@ -1400,6 +1371,8 @@ > <span class="shelvingloc">[% ITEM_RESULT.location_description | html %]</span> > [% END %] > </td> >+ [% ELSE %] >+ <td></td> > [% END %] > > [% IF ( OpacLocationBranchToDisplay == 'home' || OpacLocationBranchToDisplay == 'both' ) %] >@@ -1424,14 +1397,20 @@ > <span class="shelvingloc">[% ITEM_RESULT.location_description | html %]</span> > [% END %] > </td> >+ [% ELSE %] >+ <td></td> > [% END %] > > [% IF ( itemdata_ccode ) %] > <td class="collection">[% ITEM_RESULT.ccode | html %]</td> >+ [% ELSE %] >+ <td></td> > [% END %] > > [% IF ( Koha.Preference('OpacLocationOnDetail') == 'column' && itemdata_location ) %] > <td class="shelving_location"><span class="shelvingloc">[% ITEM_RESULT.location_description | html %]</span></td> >+ [% ELSE %] >+ <td></td> > [% END %] > > [% IF ( itemdata_itemcallnumber ) %] >@@ -1456,10 +1435,14 @@ > [% END %] > [% END %] > </td> >+ [% ELSE %] >+ <td></td> > [% END %] > > [% IF ( itemdata_materials ) %] > <td class="materials">[% ITEM_RESULT.materials | html %]</td> >+ [% ELSE %] >+ <td></td> > [% END %] > > [% IF ( itemdata_enumchron ) %] >@@ -1480,7 +1463,10 @@ > <span class="pubdate">([% serial.publisheddate | $KohaDates %])</span> > [% END %] > </td> >+ [% ELSE %] >+ <td></td> > [% END %] >+ > [% IF ( itemdata_uri ) %] > <td class="url"> > [% IF ITEM_RESULT.uri %] >@@ -1522,16 +1508,34 @@ > [% END %] > [% END %] > </td> >+ [% ELSE %] >+ <td></td> > [% END # /IF itemdata_uri %] >- [% IF ( itemdata_copynumber ) %]<td class="copynumber">[% ITEM_RESULT.copynumber | html %]</td>[% END %] >+ >+ [% IF ( itemdata_copynumber ) %] >+ <td class="copynumber">[% ITEM_RESULT.copynumber | html %]</td> >+ [% ELSE %] >+ <td></td> >+ [% END %] >+ > <td class="status">[% INCLUDE 'item-status.inc' item = ITEM_RESULT.object include_schema_org = 1 %]</td> >- [% IF ( itemdata_itemnotes ) %]<td class="notes" property="description">[% ITEM_RESULT.itemnotes | $raw %]</td>[% END %] >+ >+ [% IF ( itemdata_itemnotes ) %] >+ <td class="notes" property="description">[% ITEM_RESULT.itemnotes | $raw %]</td> >+ [% ELSE %] >+ <td></td> >+ [% END %] >+ > [% IF item_checkouts %] > <td class="date_due" data-order="[% ITEM_RESULT.checkout.date_due | html %]">[% ITEM_RESULT.checkout.date_due | $KohaDates as_due_date => 1 %]</td> >+ [% ELSE %] >+ <td></td> > [% END %] > > [% IF ( itemdata_barcode ) %] > <td class="barcode" property="serialNumber">[% ITEM_RESULT.barcode | html %]</td> >+ [% ELSE %] >+ <td></td> > [% END %] > > [% IF item_level_holds > 0 %] >@@ -1545,8 +1549,13 @@ > [% END %] > [% END %] > </td> >+ <td></td> > [% ELSIF show_priority %] >+ <td></td> > <td class="holds_priority">[% priority | html %]</td> >+ [% ELSE %] >+ <td></td> >+ <td></td> > [% END %] > > [% IF ShowCourseReservesHeader %] >@@ -1566,6 +1575,8 @@ > [% END %] > [% END %] > </td> >+ [% ELSE %] >+ <td></td> > [% END # /IF ShowCourseReservesHeader %] > <td></td> > </tr> >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30633
:
187856
|
187857
|
187858
|
187859
| 187886 |
187887
|
187888
|
187889