Now that the sorting of a table can be defined in administration > table settings, we should move OPACHoldingsDefaultSortField there and remove the pref.
Does 23.05 include the ability to sort the holdingst table? There is no sort capability on that table in 22.11 so the system preference is still needed.
I believe making this happen would solve bug 35319 - Default sorting of the holdings table with OPACHoldingsDefaultSortField is broken?
Feature introduced by bug 16552, accidentally removed by bug 16759.
I can work on this if we get one tester and one QAer in advance for quick inclusion.
*** Bug 35319 has been marked as a duplicate of this bug. ***
We don't have server access but assuming this is testable in a sandbox, I'll try for the first signoff.
Created attachment 187856 [details] [review] Bug 30633: Prepare the ground Make the OPAC holdings table ready to use visibility based on column's names.
Created attachment 187857 [details] [review] Bug 30633: Hide columns when needed We can use the force_visibility flag to hide column when they are empty or should not be displayed because of syspref.
Created attachment 187858 [details] [review] Bug 30633: Add default_sort_order to table settings So we can pick a column from the table settings http://localhost:8081/cgi-bin/koha/admin/columns_settings.pl#biblio-detail%7Choldingst
Created attachment 187859 [details] [review] Bug 30633: Remove OPACHoldingsDefaultSortField It's no longer needed
I am suggesting to remove OPACHoldingsDefaultSortField and have the default sort order option available for this table in the table settings. With OpacLocationBranchToDisplay (introduced by bug 35006) it might improve the situation and answer the different needs.
Created attachment 187886 [details] [review] Bug 30633: Prepare the ground Make the OPAC holdings table ready to use visibility based on column's names. Signed-off-by: Michaela <michaela.sieber@kit.edu>
Created attachment 187887 [details] [review] Bug 30633: Hide columns when needed We can use the force_visibility flag to hide column when they are empty or should not be displayed because of syspref. Signed-off-by: Michaela <michaela.sieber@kit.edu>
Created attachment 187888 [details] [review] Bug 30633: Add default_sort_order to table settings So we can pick a column from the table settings http://localhost:8081/cgi-bin/koha/admin/columns_settings.pl#biblio-detail%7Choldingst Signed-off-by: Michaela <michaela.sieber@kit.edu>
Created attachment 187889 [details] [review] Bug 30633: Remove OPACHoldingsDefaultSortField It's no longer needed Signed-off-by: Michaela <michaela.sieber@kit.edu>
Tested in Sandbox and additionally with ktd. Testplan: - search for a biblio with multiple items, e.g. biblionumber=211 - change the items so that they have different home libraries, current libraries, itemtypes, collections, and so on ... - try different variations of sysprefs OPACHoldingsDefaultSortField and check that the sort order in the opac is always by item type - apply patch - Go to system preferences and verify that OPACHoldingsDefaultSortField does not exist any more - Go to table settings and check the new drop down for default sort order - try different variations of the default sort order settings and verify that the holdings table in the opac is sorted correctly