Bugzilla – Attachment 187983 Details for
Bug 39814
Filters on subscription search are broken
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39814: [24.11] Restore filtering to the serials search table
Bug-39814-2411-Restore-filtering-to-the-serials-se.patch (text/plain), 4.65 KB, created by
Jonathan Druart
on 2025-10-16 09:54:17 UTC
(
hide
)
Description:
Bug 39814: [24.11] Restore filtering to the serials search table
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2025-10-16 09:54:17 UTC
Size:
4.65 KB
patch
obsolete
>From ae8079805d1bfd5cac0637a49b4ec3ae0847ad76 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 16 Oct 2025 11:53:21 +0200 >Subject: [PATCH] Bug 39814: [24.11] Restore filtering to the serials search > table > >--- > .../prog/en/modules/serials/serials-search.tt | 53 +++++-------------- > 1 file changed, 13 insertions(+), 40 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt >index 97b0f4a64b9..98d5a19ab77 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt >@@ -68,7 +68,9 @@ > </span> > </div> > [% END %] >- <table> >+ [% SET table_id = closed ? "closed_subscriptions" : "opened_subscriptions" %] >+ >+ <table id="[% table_id | html %]"> > <thead> > <tr> > <th class="NoSort noExport"></th> >@@ -185,31 +187,10 @@ > [% END # IF closed %] > </div> <!-- /.btn-group --> > </td> >- > </tr> > [% END # /UNLESS subscription.cannotdisplay %] > [% END # /FOREACH subscription %] > </tbody> >- <tfoot> >- <tr> >- <td></td> >- <td><input type="text" class="dt-filter" data-column_num="1" placeholder="Search ISSN" /></td> >- <td><input type="text" class="dt-filter" data-column_num="2" placeholder="Search title" /></td> >- <td><input type="text" class="dt-filter" data-column_num="3" placeholder="Search notes" /></td> >- <td><input type="text" class="dt-filter" data-column_num="4" placeholder="Search library" /></td> >- <td><input type="text" class="dt-filter" data-column_num="5" placeholder="Search location" /></td> >- <td><input type="text" class="dt-filter" data-column_num="6" placeholder="Search callnumber" /></td> >- [% SET column_num = 6 %] >- [% UNLESS closed %] >- <td><input type="text" class="dt-filter" data-column_num="7" placeholder="Search expiration date" /></td> >- [% SET column_num = column_num + 1 %] >- [% END %] >- [% FOR field IN additional_fields_for_subscription %] >- <td><input type="text" class="dt-filter" data-column_num="[% loop.count + column_num | html %]" placeholder="Search [% field.name | html %]" /></td> >- [% END %] >- <td></td> >- </tr> >- </tfoot> > </table> > </div> > [% END # /BLOCK subscriptions_table %] >@@ -311,6 +292,7 @@ > [% MACRO jsinclude BLOCK %] > [% INCLUDE 'calendar.inc' %] > [% INCLUDE 'datatables.inc' %] >+ [% INCLUDE 'columns_settings.inc' %] > <script> > var subscriptionid = "[% subscriptionid | html %]"; > </script> >@@ -343,24 +325,15 @@ > } > > $(document).ready(function() { >- var osrlt = $("#opened_panel table").dataTable($.extend(true, {}, dataTablesDefaults, { >- "pagingType": "full", >- "order": [[ 2, "asc" ]], >- "columnDefs": [ >- { "orderable": false, "searchable": false, "targets": [ 'NoSort' ] }, >- { "type": "anti-the", "targets": [ 'anti-the'] } >- ] >- })); >- >- var csrlt = $("#closed_panel table").dataTable($.extend(true, {}, dataTablesDefaults, { >- // FIXME sort function of additional_fields! >- "order": [[ 2, "asc" ]], >- "pagingType": "full", >- "columnDefs": [ >- { "orderable": false, "targets": [ 'NoSort' ] }, >- { "type": "anti-the", "targets": [ 'anti-the'] } >- ] >- })); >+ var osrlt = KohaTable("opened_subscriptions", { >+ pagingType: "full", >+ order: [[2, "asc"]], >+ }, null, true); >+ >+ var csrlt = KohaTable("closed_subscriptions", { >+ order: [[2, "asc"]], >+ pagingType: "full", >+ }, null, true); > > var manarlt = $("#mana_results_datatable").dataTable($.extend(true, {}, dataTablesDefaults, { > "pagingType": "full", >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39814
:
181973
|
181984
|
181989
|
182019
| 187983