Bugzilla – Attachment 188232 Details for
Bug 41054
Standard ILL form should consider eISSN field
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41054: Add eISSN to Standard forms
Bug-41054-Add-eISSN-to-Standard-forms.patch (text/plain), 8.16 KB, created by
Pedro Amorim
on 2025-10-21 15:52:35 UTC
(
hide
)
Description:
Bug 41054: Add eISSN to Standard forms
Filename:
MIME Type:
Creator:
Pedro Amorim
Created:
2025-10-21 15:52:35 UTC
Size:
8.16 KB
patch
obsolete
>From 87e856b7aac937dcb5b3c43ca2b3d5b105199184 Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@openfifth.co.uk> >Date: Mon, 20 Oct 2025 09:25:55 +0000 >Subject: [PATCH] Bug 41054: Add eISSN to Standard forms > >Signed-off-by: Richard Bridgen <Richard.Bridgen@nhs.net> >--- > Koha/ILL/Backend/Standard.pm | 4 +++- > .../ill/backends/Standard/shared/form_input_helpers.inc | 1 + > .../ill/backends/Standard/shared/forms/conference.inc | 1 + > .../includes/ill/backends/Standard/shared/forms/resource.inc | 1 + > .../ill/backends/Standard/shared/form_input_helpers.inc | 1 + > .../ill/backends/Standard/shared/forms/conference.inc | 1 + > .../includes/ill/backends/Standard/shared/forms/resource.inc | 1 + > 7 files changed, 9 insertions(+), 1 deletion(-) > >diff --git a/Koha/ILL/Backend/Standard.pm b/Koha/ILL/Backend/Standard.pm >index 3a361e926b8..0e9602094b4 100644 >--- a/Koha/ILL/Backend/Standard.pm >+++ b/Koha/ILL/Backend/Standard.pm >@@ -677,7 +677,7 @@ sub migrate { > $new_request->updated( dt_from_string() ); > $new_request->store; > >- my @default_attributes = (qw/title type author year volume isbn issn article_title article_author pages/); >+ my @default_attributes = (qw/title type author year volume isbn issn eissn article_title article_author pages/); > my $original_attributes = > $original_request->extended_attributes->search( { type => { '-in' => \@default_attributes } } ); > >@@ -886,6 +886,7 @@ sub _get_core_fields { > conference_date => __('Conference date'), > doi => __('DOI'), > editor => __('Editor'), >+ eissn => __('eISSN'), > format => __('Format'), > genre => __('Genre'), > institution => __('Institution'), >@@ -1000,6 +1001,7 @@ sub _openurl_to_ill { > volume => 'volume', > isbn => 'isbn', > issn => 'issn', >+ eissn => 'eissn', > doi => 'doi', > year => 'year', > title => 'title', >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/ill/backends/Standard/shared/form_input_helpers.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/ill/backends/Standard/shared/form_input_helpers.inc >index b77c85ede4f..12015d7741c 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/ill/backends/Standard/shared/form_input_helpers.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/ill/backends/Standard/shared/form_input_helpers.inc >@@ -54,4 +54,5 @@ > [% PROCESS ill_text_input_field id = 'issue' label = t('Issue number') value = whole.value.other.issue %] > [% PROCESS ill_text_input_field id = 'year' label = t('Year') value = whole.value.other.year %] > [% PROCESS ill_text_input_field id = 'issn' label = t('ISSN') value = whole.value.other.issn %] >+ [% PROCESS ill_text_input_field id = 'eissn' label = t('eISSN') value = whole.value.other.eissn %] > [% END %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/ill/backends/Standard/shared/forms/conference.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/ill/backends/Standard/shared/forms/conference.inc >index ce74a27e59a..2ed715e4ca2 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/ill/backends/Standard/shared/forms/conference.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/ill/backends/Standard/shared/forms/conference.inc >@@ -9,6 +9,7 @@ > [% PROCESS ill_text_input_field id = 'volume' label = t('Volume') value = whole.value.other.volume %] > [% PROCESS ill_text_input_field id = 'isbn' label = t('ISBN') value = whole.value.other.isbn %] > [% PROCESS ill_text_input_field id = 'issn' label = t('ISSN') value = whole.value.other.issn %] >+ [% PROCESS ill_text_input_field id = 'eissn' label = t('eISSN') value = whole.value.other.eissn %] > [% PROCESS ill_text_input_field id = 'part_edition' label = t('Part') value = whole.value.other.part_edition %] > [% PROCESS ill_text_input_field id = 'paper_title' label = t('Paper title') value = whole.value.other.paper_title %] > [% PROCESS ill_text_input_field id = 'paper_author' label = t('Paper author') value = whole.value.other.paper_author %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/ill/backends/Standard/shared/forms/resource.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/ill/backends/Standard/shared/forms/resource.inc >index b24a76463cb..f3208efcb1e 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/ill/backends/Standard/shared/forms/resource.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/ill/backends/Standard/shared/forms/resource.inc >@@ -12,6 +12,7 @@ > [% PROCESS ill_text_input_field id = 'pages' label = t('Pages') value = whole.value.other.pages %] > [% PROCESS ill_text_input_field id = 'isbn' label = t('ISBN') value = whole.value.other.isbn %] > [% PROCESS ill_text_input_field id = 'issn' label = t('ISSN') value = whole.value.other.issn %] >+ [% PROCESS ill_text_input_field id = 'eissn' label = t('eISSN') value = whole.value.other.eissn %] > [% PROCESS ill_text_input_field id = 'doi' label = t('DOI') value = whole.value.other.doi %] > </ol> > </fieldset> >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/ill/backends/Standard/shared/form_input_helpers.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/ill/backends/Standard/shared/form_input_helpers.inc >index 8f67eafcc56..465727267f2 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/ill/backends/Standard/shared/form_input_helpers.inc >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/ill/backends/Standard/shared/form_input_helpers.inc >@@ -54,4 +54,5 @@ > [% PROCESS ill_text_input_field id = 'issue' label = t('Issue number') value = whole.value.other.issue %] > [% PROCESS ill_text_input_field id = 'year' label = t('Year') value = whole.value.other.year %] > [% PROCESS ill_text_input_field id = 'issn' label = t('ISSN') value = whole.value.other.issn %] >+ [% PROCESS ill_text_input_field id = 'eissn' label = t('eISSN') value = whole.value.other.eissn %] > [% END %] >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/ill/backends/Standard/shared/forms/conference.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/ill/backends/Standard/shared/forms/conference.inc >index ce74a27e59a..2ed715e4ca2 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/ill/backends/Standard/shared/forms/conference.inc >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/ill/backends/Standard/shared/forms/conference.inc >@@ -9,6 +9,7 @@ > [% PROCESS ill_text_input_field id = 'volume' label = t('Volume') value = whole.value.other.volume %] > [% PROCESS ill_text_input_field id = 'isbn' label = t('ISBN') value = whole.value.other.isbn %] > [% PROCESS ill_text_input_field id = 'issn' label = t('ISSN') value = whole.value.other.issn %] >+ [% PROCESS ill_text_input_field id = 'eissn' label = t('eISSN') value = whole.value.other.eissn %] > [% PROCESS ill_text_input_field id = 'part_edition' label = t('Part') value = whole.value.other.part_edition %] > [% PROCESS ill_text_input_field id = 'paper_title' label = t('Paper title') value = whole.value.other.paper_title %] > [% PROCESS ill_text_input_field id = 'paper_author' label = t('Paper author') value = whole.value.other.paper_author %] >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/ill/backends/Standard/shared/forms/resource.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/ill/backends/Standard/shared/forms/resource.inc >index b24a76463cb..f3208efcb1e 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/ill/backends/Standard/shared/forms/resource.inc >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/ill/backends/Standard/shared/forms/resource.inc >@@ -12,6 +12,7 @@ > [% PROCESS ill_text_input_field id = 'pages' label = t('Pages') value = whole.value.other.pages %] > [% PROCESS ill_text_input_field id = 'isbn' label = t('ISBN') value = whole.value.other.isbn %] > [% PROCESS ill_text_input_field id = 'issn' label = t('ISSN') value = whole.value.other.issn %] >+ [% PROCESS ill_text_input_field id = 'eissn' label = t('eISSN') value = whole.value.other.eissn %] > [% PROCESS ill_text_input_field id = 'doi' label = t('DOI') value = whole.value.other.doi %] > </ol> > </fieldset> >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41054
:
188144
|
188145
|
188161
|
188166
|
188231
| 188232 |
188233