Created attachment 188144 [details] [review] Bug 41054: Add test prove t/db_dependent/Koha/ILL/Backend/Standard.t
Created attachment 188145 [details] [review] Bug 41054: Add eISSN to Standard forms
Created attachment 188161 [details] [review] Bug 41054: Sort metadata keys alphabetically case insensitive This coincidentally+nicely puts eISSN before ISSN on the 'manage request page' while keeping the rest of the order as before Test plan: 1) Enable ILLModule 2) Create a new ILL request, visit: <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Pick type one of 'journal article', 'conference', 'journal', 'generic resource' 4) Enter cardnumber, library, eISSN and other data if you want 5) Notice 'eISSN' shows on the 'Manage request' page. 6) Test again by creating an OPAC request, visit: <opac_url>/cgi-bin/koha/opac-illrequests.pl?op=add_form&backend=Standard
Created attachment 188166 [details] [review] Bug 41054: Sort metadata keys alphabetically case insensitive This coincidentally+nicely puts eISSN before ISSN on the 'manage request page' while keeping the rest of the order as before Test plan: 1) Enable ILLModule 2) Create a new ILL request, visit: <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Pick type one of 'journal article', 'conference', 'journal', 'generic resource' 4) Enter cardnumber, library, eISSN and other data if you want 5) Notice 'eISSN' shows on the 'Manage request' page. 6) Test again by creating an OPAC request, visit: <opac_url>/cgi-bin/koha/opac-illrequests.pl?op=add_form&backend=Standard
Seems to work fine on ELMS test server. Please apply to LHL and ELMS live.
Created attachment 188231 [details] [review] Bug 41054: Add test prove t/db_dependent/Koha/ILL/Backend/Standard.t Signed-off-by: Richard Bridgen <Richard.Bridgen@nhs.net>
Created attachment 188232 [details] [review] Bug 41054: Add eISSN to Standard forms Signed-off-by: Richard Bridgen <Richard.Bridgen@nhs.net>
Created attachment 188233 [details] [review] Bug 41054: Sort metadata keys alphabetically case insensitive This coincidentally+nicely puts eISSN before ISSN on the 'manage request page' while keeping the rest of the order as before Test plan: 1) Enable ILLModule 2) Create a new ILL request, visit: <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Pick type one of 'journal article', 'conference', 'journal', 'generic resource' 4) Enter cardnumber, library, eISSN and other data if you want 5) Notice 'eISSN' shows on the 'Manage request' page. 6) Test again by creating an OPAC request, visit: <opac_url>/cgi-bin/koha/opac-illrequests.pl?op=add_form&backend=Standard Signed-off-by: Richard Bridgen <Richard.Bridgen@nhs.net>
Passing QA here but making note that I am ignoring these failures that I do not believe are valid: [FAIL] koha-tmpl/intranet-tmpl/prog/en/includes/ill/backends/Standard/shared/forms/conference.inc FAIL valid_template ill_text_input_field: not found [FAIL] koha-tmpl/intranet-tmpl/prog/en/includes/ill/backends/Standard/shared/forms/resource.inc FAIL valid_template ill_text_input_field: not found [PASS] koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt [PASS] koha-tmpl/opac-tmpl/bootstrap/en/includes/ill/backends/Standard/shared/form_input_helpers.inc [FAIL] koha-tmpl/opac-tmpl/bootstrap/en/includes/ill/backends/Standard/shared/forms/conference.inc FAIL valid_template ill_text_input_field: not found [FAIL] koha-tmpl/opac-tmpl/bootstrap/en/includes/ill/backends/Standard/shared/forms/resource.inc The QA script can't find ill_text_input_field because it's not in the same file, but it's imported by create.inc before importing the files in question.
Created attachment 191493 [details] [review] Bug 41054: Add test prove t/db_dependent/Koha/ILL/Backend/Standard.t Signed-off-by: Richard Bridgen <Richard.Bridgen@nhs.net> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 191494 [details] [review] Bug 41054: Add eISSN to Standard forms Signed-off-by: Richard Bridgen <Richard.Bridgen@nhs.net> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 191495 [details] [review] Bug 41054: Sort metadata keys alphabetically case insensitive This coincidentally+nicely puts eISSN before ISSN on the 'manage request page' while keeping the rest of the order as before Test plan: 1) Enable ILLModule 2) Create a new ILL request, visit: <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Pick type one of 'journal article', 'conference', 'journal', 'generic resource' 4) Enter cardnumber, library, eISSN and other data if you want 5) Notice 'eISSN' shows on the 'Manage request' page. 6) Test again by creating an OPAC request, visit: <opac_url>/cgi-bin/koha/opac-illrequests.pl?op=add_form&backend=Standard Signed-off-by: Richard Bridgen <Richard.Bridgen@nhs.net> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Nice work everyone! Pushed to main for 26.05
please add release notes