Bug 41054 - Standard ILL form should consider eISSN field
Summary: Standard ILL form should consider eISSN field
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: ILL (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Pedro Amorim
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-10-20 09:22 UTC by Pedro Amorim
Modified: 2025-10-21 15:52 UTC (History)
4 users (show)

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: ---
Crowdfunding goal: 0
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 41054: Add test (1.62 KB, patch)
2025-10-20 09:26 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 41054: Add eISSN to Standard forms (8.10 KB, patch)
2025-10-20 09:26 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 41054: Sort metadata keys alphabetically case insensitive (2.42 KB, patch)
2025-10-20 12:09 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 41054: Sort metadata keys alphabetically case insensitive (2.38 KB, patch)
2025-10-20 13:50 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 41054: Add test (1.68 KB, patch)
2025-10-21 15:52 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 41054: Add eISSN to Standard forms (8.16 KB, patch)
2025-10-21 15:52 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 41054: Sort metadata keys alphabetically case insensitive (2.43 KB, patch)
2025-10-21 15:52 UTC, Pedro Amorim
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Pedro Amorim 2025-10-20 09:22:57 UTC

    
Comment 1 Pedro Amorim 2025-10-20 09:26:51 UTC
Created attachment 188144 [details] [review]
Bug 41054: Add test

prove t/db_dependent/Koha/ILL/Backend/Standard.t
Comment 2 Pedro Amorim 2025-10-20 09:26:53 UTC
Created attachment 188145 [details] [review]
Bug 41054: Add eISSN to Standard forms
Comment 3 Pedro Amorim 2025-10-20 12:09:23 UTC
Created attachment 188161 [details] [review]
Bug 41054: Sort metadata keys alphabetically case insensitive

This coincidentally+nicely puts eISSN before ISSN on the 'manage request page' while keeping the rest of the order as before

Test plan:
1) Enable ILLModule
2) Create a new ILL request, visit:
<staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard
3) Pick type one of 'journal article', 'conference', 'journal', 'generic resource'
4) Enter cardnumber, library, eISSN and other data if you want
5) Notice 'eISSN' shows on the 'Manage request' page.
6) Test again by creating an OPAC request, visit:
<opac_url>/cgi-bin/koha/opac-illrequests.pl?op=add_form&backend=Standard
Comment 4 Pedro Amorim 2025-10-20 13:50:56 UTC
Created attachment 188166 [details] [review]
Bug 41054: Sort metadata keys alphabetically case insensitive

This coincidentally+nicely puts eISSN before ISSN on the 'manage request page' while keeping the rest of the order as before

Test plan:
1) Enable ILLModule
2) Create a new ILL request, visit:
<staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard
3) Pick type one of 'journal article', 'conference', 'journal', 'generic resource'
4) Enter cardnumber, library, eISSN and other data if you want
5) Notice 'eISSN' shows on the 'Manage request' page.
6) Test again by creating an OPAC request, visit:
<opac_url>/cgi-bin/koha/opac-illrequests.pl?op=add_form&backend=Standard
Comment 5 Richard Bridgen 2025-10-20 15:15:47 UTC
Seems to work fine on ELMS test server.  Please apply to LHL and ELMS live.
Comment 6 Pedro Amorim 2025-10-21 15:52:33 UTC
Created attachment 188231 [details] [review]
Bug 41054: Add test

prove t/db_dependent/Koha/ILL/Backend/Standard.t

Signed-off-by: Richard Bridgen <Richard.Bridgen@nhs.net>
Comment 7 Pedro Amorim 2025-10-21 15:52:35 UTC
Created attachment 188232 [details] [review]
Bug 41054: Add eISSN to Standard forms

Signed-off-by: Richard Bridgen <Richard.Bridgen@nhs.net>
Comment 8 Pedro Amorim 2025-10-21 15:52:37 UTC
Created attachment 188233 [details] [review]
Bug 41054: Sort metadata keys alphabetically case insensitive

This coincidentally+nicely puts eISSN before ISSN on the 'manage request page' while keeping the rest of the order as before

Test plan:
1) Enable ILLModule
2) Create a new ILL request, visit:
<staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard
3) Pick type one of 'journal article', 'conference', 'journal', 'generic resource'
4) Enter cardnumber, library, eISSN and other data if you want
5) Notice 'eISSN' shows on the 'Manage request' page.
6) Test again by creating an OPAC request, visit:
<opac_url>/cgi-bin/koha/opac-illrequests.pl?op=add_form&backend=Standard

Signed-off-by: Richard Bridgen <Richard.Bridgen@nhs.net>