Bugzilla – Attachment 188233 Details for
Bug 41054
Standard ILL form should consider eISSN field
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41054: Sort metadata keys alphabetically case insensitive
Bug-41054-Sort-metadata-keys-alphabetically-case-i.patch (text/plain), 2.43 KB, created by
Pedro Amorim
on 2025-10-21 15:52:37 UTC
(
hide
)
Description:
Bug 41054: Sort metadata keys alphabetically case insensitive
Filename:
MIME Type:
Creator:
Pedro Amorim
Created:
2025-10-21 15:52:37 UTC
Size:
2.43 KB
patch
obsolete
>From 7c82d538f00a328755f42e7f2538a9cbbc874069 Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@openfifth.co.uk> >Date: Mon, 20 Oct 2025 12:05:48 +0000 >Subject: [PATCH] Bug 41054: Sort metadata keys alphabetically case insensitive > >This coincidentally+nicely puts eISSN before ISSN on the 'manage request page' while keeping the rest of the order as before > >Test plan: >1) Enable ILLModule >2) Create a new ILL request, visit: ><staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard >3) Pick type one of 'journal article', 'conference', 'journal', 'generic resource' >4) Enter cardnumber, library, eISSN and other data if you want >5) Notice 'eISSN' shows on the 'Manage request' page. >6) Test again by creating an OPAC request, visit: ><opac_url>/cgi-bin/koha/opac-illrequests.pl?op=add_form&backend=Standard > >Signed-off-by: Richard Bridgen <Richard.Bridgen@nhs.net> >--- > .../intranet-tmpl/prog/en/modules/ill/ill-requests.tt | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt >index 6b82dae88df..ffdd043c31e 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt >@@ -750,11 +750,12 @@ > <div class="rows"> > <h4>Details from supplier ([% request.backend | html %])</h4> > <ol> >- [% FOREACH meta IN request.metadata %] >- [% IF meta.value %] >- <li class="requestmeta-[% meta.key.replace('\s','_') | html %]"> >- <span class="label">[% meta.key.replace('_',' ') | html %]:</span> >- [% meta.value | html %] >+ [% FOREACH meta IN request.metadata.keys.sort('lower') %] >+ [% val = request.metadata.${meta} %] >+ [% IF val %] >+ <li class="requestmeta-[% meta.replace('\s','_') | html %]"> >+ <span class="label">[% meta.replace('_',' ') | html %]:</span> >+ [% val | html %] > </li> > [% END %] > [% END %] >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41054
:
188144
|
188145
|
188161
|
188166
|
188231
|
188232
| 188233